Skip to content

🐛 fix(review): report each withheld not-hive-authored head once - #14886

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v6from
scanner/fix-14882
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v6from
scanner/fix-14882

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

withholdFix re-recorded an already-withheld head's exclusion every eval cycle, producing the 6-in-10m repetition behind #14870 and contradicting auditWithheldReviewFixes' doc ("The planner reports each head once"). Now the plan entry is recorded once per head (when the State.Withheld entry is first created) and the doc comment describes that. Adds a regression test running the planner twice over the same head. The INFO demotion from #14880 is untouched.

Closes #14882
Closes #14883

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14871 ✨ feat(governor): lexical search source for the prior-art gate same files src/cmd/hive/main.go

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Superseded by the v5 PR (fix base per CONTRIBUTING; forward-merges into v6).

@hivecommons-hive hivecommons-hive Bot closed this Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot deleted the scanner/fix-14882 branch October 28, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

0 participants