Skip to content

Review backlog (docs-currency): Function doc claims exclusions are reported once per head, but withholdFix re-records every cycle #14883

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #14880.

PR: #14880 (#14880)
Perspective: docs-currency
Severity: low (P3)
Evidence: src/pkg/review/dispatch.go:1400 (

for _, w := range p.State.Withheld {
)
Finding: Function doc claims exclusions are reported once per head, but withholdFix re-records every cycle

auditWithheldReviewFixes' doc (main.go:11146-11147) says 'The planner reports each head once, so this does not repeat on every eval cycle', yet withholdFix (dispatch.go:1400-1407) calls recordFixExclusion for an already-withheld head on every cycle, which is the 6-in-10m repetition seen in #14870. The PR fixes the log level (symptom) but the repetition and the inaccurate doc sentence remain. Pre-existing; backlog candidate.

Fingerprint: 86ad3a2bae5bb4266cee9a7d8afabccb79ae85c8248bb368925d46f5e07830c0

filed by Hive review backlog

Activity

  1. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #14882: both cite src/pkg/review/dispatch.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions