You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (intent-alignment): FixExclusions re-reports the same not-hive-authored head every cycle despite doc comment #14882
)
Finding: FixExclusions re-reports the same not-hive-authored head every cycle despite doc comment
withholdFix (dispatch.go:1400-1407) calls recordFixExclusion on every cycle when a matching State.Withheld entry already exists, so FixExclusions carries the same head each cycle; the auditWithheldReviewFixes doc comment (main.go ~11147) says 'The planner reports each head once'. This repetition is what made the WARN hit the 6-in-10m threshold. The PR's INFO demotion is a sufficient fix for #14870; dedup of the exclusion plan entry is a pre-existing adjacent concern.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Consolidated finding. This was filed as a separate issue; it references exactly the same files as this one (main.go, src/pkg/review/dispatch.go), so it was folded in here instead. Address it in the same PR as this issue — two PRs editing the same files would conflict.
Review backlog (intent-alignment): DispatchPlan.FixExclusions field doc still promises no silent planner branch
Blocked on PR #14887. This finding came from reviewing PR #14887 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #14887.
// FixExclusions are changes-requested PRs whose fix kick was deliberately
)
Finding: DispatchPlan.FixExclusions field doc still promises no silent planner branch
src/pkg/review/dispatch.go:485-487 documents FixExclusions as 'changes-requested PRs whose fix kick was deliberately not added to FixKicks this cycle. Callers log them so a stuck PR never disappears behind a silent planner branch.' After this PR, an already-withheld not-hive-authored head (State.Withheld match at dispatch.go:1400-1403) ends later cycles with neither a FixKick nor a FixExclusion, which is exactly the silent branch that sentence rules out. The withholdFix comment (dispatch.go:1395-1398) and main.go:11146-11149 were updated and are accurate; only the struct field doc lags. Adjacent doc drift, not a behavior defect; a one-clause exception on that field doc would close it.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #14887 (#14887) and folded into this issue because it is a intent-alignment finding at the same symbol or lines of src/pkg/review/dispatch.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
Review backlog (intent-alignment): DispatchPlan.FixExclusions field doc still promises no silent planner branch
DispatchPlan.FixExclusions field doc still promises no silent planner branch (src/pkg/review/dispatch.go:485)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/pkg/review/dispatch.go:485 (
// FixExclusions are changes-requested PRs whose fix kick was deliberately
)
Finding: DispatchPlan.FixExclusions field doc still promises no silent planner branch
src/pkg/review/dispatch.go:485-487 documents FixExclusions as 'changes-requested PRs whose fix kick was deliberately not added to FixKicks this cycle. Callers log them so a stuck PR never disappears behind a silent planner branch.' After this PR, an already-withheld not-hive-authored head (State.Withheld match at dispatch.go:1400-1403) ends later cycles with neither a FixKick nor a FixExclusion, which is exactly the silent branch that sentence rules out. The withholdFix comment (dispatch.go:1395-1398) and main.go:11146-11149 were updated and are accurate; only the struct field doc lags. Adjacent doc drift, not a behavior defect; a one-clause exception on that field doc would close it.
Activity
hivecommons-hive commentedon Oct 28, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 28, 2026
Consolidated finding. This was filed as a separate issue; it references exactly the same files as this one (
main.go,src/pkg/review/dispatch.go), so it was folded in here instead. Address it in the same PR as this issue — two PRs editing the same files would conflict.Review backlog (intent-alignment): DispatchPlan.FixExclusions field doc still promises no silent planner branch
Blocked on PR #14887. This finding came from reviewing PR #14887 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #14887.
PR: #14887 (#14887)
Perspective: intent-alignment
Severity: info (P3)
Evidence:
src/pkg/review/dispatch.go:485(hive/src/pkg/review/dispatch.go
Line 485 in 73c3062
Finding: DispatchPlan.FixExclusions field doc still promises no silent planner branch
src/pkg/review/dispatch.go:485-487 documents FixExclusions as 'changes-requested PRs whose fix kick was deliberately not added to FixKicks this cycle. Callers log them so a stuck PR never disappears behind a silent planner branch.' After this PR, an already-withheld not-hive-authored head (State.Withheld match at dispatch.go:1400-1403) ends later cycles with neither a FixKick nor a FixExclusion, which is exactly the silent branch that sentence rules out. The withholdFix comment (dispatch.go:1395-1398) and main.go:11146-11149 were updated and are accurate; only the struct field doc lags. Adjacent doc drift, not a behavior defect; a one-clause exception on that field doc would close it.
Fingerprint:
054978c4e9e98019a75a6afd47286ecc4afc280c8ae58c97677922a031bef5fefiled by Hive review backlog
hivecommons-hive commentedon Oct 28, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #14887 (#14887) and folded into this issue because it is a intent-alignment finding at the same symbol or lines of
src/pkg/review/dispatch.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.Review backlog (intent-alignment): DispatchPlan.FixExclusions field doc still promises no silent planner branch
src/pkg/review/dispatch.go:485)Perspective: intent-alignment
Severity: info (P3)
Evidence:
src/pkg/review/dispatch.go:485(hive/src/pkg/review/dispatch.go
Line 485 in 73c3062
Finding: DispatchPlan.FixExclusions field doc still promises no silent planner branch
src/pkg/review/dispatch.go:485-487 documents FixExclusions as 'changes-requested PRs whose fix kick was deliberately not added to FixKicks this cycle. Callers log them so a stuck PR never disappears behind a silent planner branch.' After this PR, an already-withheld not-hive-authored head (State.Withheld match at dispatch.go:1400-1403) ends later cycles with neither a FixKick nor a FixExclusion, which is exactly the silent branch that sentence rules out. The withholdFix comment (dispatch.go:1395-1398) and main.go:11146-11149 were updated and are accurate; only the struct field doc lags. Adjacent doc drift, not a behavior defect; a one-clause exception on that field doc would close it.
Fingerprint:
054978c4e9e98019a75a6afd47286ecc4afc280c8ae58c97677922a031bef5fefiled by Hive review backlog