Skip to content

🐛 Surface GitHub blocked-by dependencies on Actionable stage-tracker rows - #14772

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/stage-tracker-blocked-by
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/stage-tracker-blocked-by

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #14765

Problem

The scanner deliberately withholds issues with open GitHub "blocked by" dependencies (partitionBlockedIssues → kick list "do NOT start these"), but /api/stage-tracker rendered them as plain 010 Actionable / "Triaged and eligible; waiting for the scanner to pick it up". On the hosted hive today the search sub-issues #14635–#14641 sat at 010 for hours and read as intake starvation; nothing in the UI said they were sequenced behind #14633.

Fix

  • StageTrackerItem.BlockedOn (blocked_on, which stageTrackerBlockedTip in the UI already read but Go never populated) carries the open blocker keys from Issue.OpenBlockers().
  • Pre-claim stages (Open/010/015/017) get the blocked modifier (deduped against the blocked label), caption clause waiting on #14633, hivecommons/crux#19, actor its blockers.
  • The modifier chip reads blocked on #N with a tooltip explaining the scanner withholds it until the blocker closes.
  • Stages 020+ are untouched: the dependency no longer gates them.

Tests

TestStageTrackerBlockedByDependencyIsSurfaced, TestStageTrackerBlockerList. No time.Sleep.

…rows

An issue the scheduler withholds for an open "blocked by" dependency
rendered as plain Actionable ("waiting for the scanner"), so sequenced
RFC sub-issues read as intake starvation. The row now carries the
blocked modifier, blocked_on keys, and a "waiting on #N" caption; the
chip names the blocker.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker CONFLICT src/pkg/dashboard/static/index.html
#14779 🐛 fix: show GitHub dependency blockers in stage tracker CONFLICT src/pkg/dashboard/stage_tracker.go
#14651 🌱 dashboard: defer merge-gate pills until the PR reaches the gate same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 9de515f into v5 Oct 28, 2026
86 of 90 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/stage-tracker-blocked-by branch October 28, 2026 01:13
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1477288fb22d` sha256:ac5ef99a695b28f318b1b57f09a589c3f98c727a60728c688a3a5790b6924da0 — download from the dashboard or `hivectl review evidence #14772`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 88fb22d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves conflicts-with-open-pr Open PR has a merge conflict with another open PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 stage tracker: issues withheld for open GitHub blockers show as plain Actionable

1 participant