Repository navigation
Description
Summary
The stage tracker shows closed issues whose linked PR is still open, with no indication that the PR was superseded. Four rows on the hive-oke spoke (2026-10-27/28):
| Issue (closed) | Closed by | Open PR | Open PR author / size | Stage shown |
|---|---|---|---|---|
| #14789 | merge of #14791 (Fixes #14789, trusted-author auto-merge 01:52Z) |
#14795 | thatguywob (clanker), size/L | 072 returned-to-contributor + sentinel |
| #14765 | merge of #14772 (Fixes #14765, trusted-author auto-merge 01:13Z) |
#14779 | thatguywob (clanker), size/L | 072 returned-to-contributor |
| #14666 | merge of #14688 (hive's own scanner/fix-14666, 21:48Z) |
#14787 | clubanderson (human), size/L — opened 3.5 h after the issue closed | 071 needs-author |
| #14685 | merge of #14695 (Fixes #14685, trusted-author auto-merge 21:02Z) |
#14702 | Karibhou (clanker), size/XXL | 085 needs-decision |
In every case GitHub's closing keyword on a different merged PR closed the issue. Three of the four orphan PRs were opened after the eventual closer already existed (#14795 16 min after #14791; #14779 12 min after #14772; #14702 39 min after #14695) — nothing stopped a second author from opening a duplicate PR on an issue that already had an open PR.
What hive did (correctly, per current design)
SweepSupersededOpenPRs (pkg/github/pr_supersession_sweep.go, 15-min cadence) detected all four and posted <!-- hive:pr-supersession-sweep --> notices (#14702 21:16Z, #14779 01:38Z, #14787 01:38Z, #14795 01:55Z). Each notice says "Decision needed… touches files the merged PR did not. Recommended: keep open" and parks at stage/085-needs-decision. Spoke config: acmm_level: 6, supersession_sweep.close_contributor_prs: true. Logs: supersession sweep complete seen=30 commented=4 ×2, then commented=0 (notice already present → no-op).
Why the PRs stay open anyway (gaps)
- File-name-subset heuristic always says "keep open" for real duplicates.
supersessionExtraFilescompares file names; a duplicate implementation of the same fix nearly always adds/touches a different test or doc file, sosubset=false→ never eligible for auto-close, recommendation is "keep open". Independently,supersessionSizeAllowsAutoCloserefuses anything above size/M — all four are L/XXL. - The 085 supersession park is overwritten by the stage reconciler within minutes.
needs-rebase→ 072 (🐛 fix: show GitHub dependency blockers in stage tracker #14779 at 22:05 local, ✨ review: scale reviewer concurrency up and down with backlog #14702),check-failing→ 072/071 (🐛 fix: find default tmux sockets under arbitrary container UIDs #14795 at 21:59, 🐛 dco: re-home unsigned commits on adopted PRs so the gate can clear #14787 at 21:54). The tracker then shows "Returned to contributor / Needs author" and the superseded context is gone; the only trace is a mid-thread comment. - The stage tracker row has no "superseded" signal for a closed-issue → open-PR pair even though the data (
closedByPullRequestsReferences, the sweep marker) is already fetched by the sweep. - Owner's
/hive decision rejecton ✨ review: scale reviewer concurrency up and down with backlog #14702 was refused (pr_unpark_decision.go: "the hive did not open this PR, so it will not push to it") — the decision path only knows "fix it", not "close as superseded by #N", for non-hive-authored PRs. The dashboard hasdecide:close-supersededbut the comment command does not. - Hold labels silence the sweep entirely.
trySweepSupersededPRreturns before any check ifisHeld(incl. the sentinel label) ordo-not-merge— 🐛 fix: find default tmux sockets under arbitrary container UIDs #14795 now carriessentinel-alert, so even a future resolution won't be re-evaluated until the label clears. - Upstream: no claim/overlap check stops a second PR being opened against an issue that already has an open PR (or, for 🐛 dco: re-home unsigned commits on adopted PRs so the gate can clear #14787, against an already-closed issue).
Proposed fleet-generic fix
- Stage tracker: when an item's issue is closed and
closedByPullRequestsReferencesnames a merged PR ≠ this PR, render the row as "Superseded by #N — decide" regardless of 07x stage, and keep the 085 park sticky (reconciler must not downgrade a supersession park to 071/072 onneeds-rebase/check-failing, which are moot for a superseded PR). /hive decision reject/close superseded by #Non a non-hive PR should close the PR with a comment (no push required), mirroringdecide:close-superseded.- Supersession heuristic: treat extra files that are only
*_test.go, docs, or changelog fragments as not-blocking, or compare the overlapping files' hunks instead of file names; log the "keep open" reason into the stage-tracker row. - Issue-claim gate: when a PR is opened with
Fixes #Nand #N already has an open PR (or is closed), post the overlap notice immediately and park at 085 instead of letting it ride the normal lane to 072.
Activity
clubanderson commentedon Oct 28, 2026
Follow-up: how each duplicate PR got opened (provenance trace)
Source: spoke logs (
hive-oke, pod window starts 20:34 ET) + 3 GraphQL reads. Times ET.thatguywobviahive contribute(contribute-ws, cli=codex, tier=trusted); taskct-hivecommons/hive-14765-1793149524Fixes #14765had been open 9 minct-hivecommons/hive-14789-1793151599suppressing issue: open external PR covers it issue=14789 claimed_by_pr=14791— 4 min after the hand-outKaribhou(Claude Code;author/clanker, pre-log-window so channel unconfirmed, likely contribute-ws)feat/reviewer-autoscale)clubanderson(human, local Claude Code)Fixes #14666Fixes #closedThe single mechanism gap
ContributeWSHub.selectTask(pkg/dashboard/contribute_select.go) offers work from the cachedActionableIssuessnapshot. The "open external PR covers this issue" suppression lives inpkg/github/prclaims.goand only runs during a full enumeration pass (observed at 20:38, 21:44, 23:08, 23:20 — ~66 min apart during the incident). Webhook re-reads (eval_cycle_source.go→ApplyWebhookItem) upsert individual issue/PR items but do not re-run the PR→issue claim cross-link, so an owner PR opened withFixes #Nbetween passes leaves #N offerable.activeIssues/claimedIssueKeysonly cover live contributor/worker claims, not external PRs. Result: a contributor was assigned #14765 and #14789 while an open PR already fixed each.Fix
selectTask(orApplyWebhookItemfor PR snapshots), run the sameclaim.ExternalAuthor && !claim.MergedPRsuppression against the snapshot's open PRs /closingIssuesReferencesbefore offering an issue; also refuse issues whose state is closed.pull_request.openedwith closing keywords should patch the referenced issue out ofActionableIssuesimmediately.hivecommons-hive commentedon Oct 28, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 28, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).hivecommons-hive commentedon Oct 28, 2026
🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 28, 2026
🔓 Claim by @thatguywob released (lease revoked).
github-actions commentedon Oct 28, 2026
@clubanderson this issue was closed by @hivecommons-hive[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment
/reopenand it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.🐛 fix: preserve supersession decisions across stage reconciliation (#…