Skip to content

🐛 fix: show GitHub dependency blockers in stage tracker - #14779

Closed
thatguywob wants to merge 1 commit into
hivecommons:v5from
thatguywob:fix/14765-stage-github-blockers
Closed

thatguywob wants to merge 1 commit into
hivecommons:v5from
thatguywob:fix/14765-stage-github-blockers

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Issues withheld by open GitHub dependencies currently look ready for the scanner, making intentional sequencing look like intake starvation. The stage tracker now adds the blocked modifier from Issue.IsBlocked(), exposes unresolved canonical keys in blocked_by, and names predecessors in a waiting on #N caption. Stage 010 reads Actionable · blocked in the headline and active chevron, with dependency details in the tooltip. Scheduling remains unchanged.

Added API regression coverage for open, resolved, empty, duplicate, cross-repository, and label-only blockers, plus rendered UI assertions for the headline, chevron, tooltip, modifier pill, and compact view. Added a changelog fragment.

Validation: gofmt -l on changed Go files and git diff --check passed. Tests are delegated to CI per AGENTS.md; no local test suite was run.

Fixes #14765

— hive: backend=codex


🐝 Hive Agent: contributor | SHA: 22dd6ff1d

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14573 ✨ feat(dashboard): show a draft pill in the activity tracker same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_ui_test.go
src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

Show unresolved dependency keys and waiting captions alongside the blocked modifier. Mark the active Actionable step as blocked so operators can distinguish sequencing from scanner starvation.

Hive-Run: hivecommons#14765
Hive-Plan: stage-tracker-dependency-visibility
Hive-Spec: issue-14765#expected
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@thatguywob
thatguywob force-pushed the fix/14765-stage-github-blockers branch from 22dd6ff to e434e24 Compare October 28, 2026 01:16
@hivecommons-hive hivecommons-hive Bot added role/untrusted Author has no registry profile or verified hive claim (or is revoked); never auto-merged stage/050-review-pending Review swarm requested; awaiting a verdict for the current head role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act role/untrusted Author has no registry profile or verified hive claim (or is revoked); never auto-merged labels Oct 28, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#14765
  • Closing PR: #14772

Decision needed (@hivecommons): #14772 already merged and closed the claimed issue, but this PR touches files the merged PR did not. Recommended: keep open until the extra changes are reviewed, or close as superseded if they are not wanted. Another option: merge anyway.

Files the merged PR did not touch: changelog.d/fixed-14765-stage-dependency-blockers.md, src/pkg/dashboard/stage_tracker_blocked_test.go, src/pkg/dashboard/stage_tracker_ui_test.go.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive hivecommons-hive Bot added needs-human stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff at e434e24 against its merge-base 9de515f (#14772). The code looks correct to me; one framing note for whoever merges.

Verified:

  • stageTrackerBlockedBy (src/pkg/dashboard/stage_tracker.go:748-770) is still only reached from the issue path at stage_tracker.go:1368 with issue.OpenBlockers(), which already sorts (src/pkg/github/issue_dependencies.go:225-234), so slices.Compact is a real de-dupe here, not an adjacent-only one. The Stage > trackerNumberPossiblyExists guard is unchanged, so 020+ rows stay untouched (stage_tracker_blocked_by_test.go:61 now also asserts BlockedBy == nil there).
  • index.html: cur is in scope for the new stepBlocked test (const cur = Number(item.stage) || 0 a few lines above), stageTrackerBlockedTip prefers blocked_by and falls back to blocked_on, and the headline for a plain stage-10 row is still Waiting for a worker (asserted in stage_tracker_ui_test.go).
  • BlockedBy is a byte-for-byte copy of BlockedOn. That is fine — #14765 asked for the field to be called blocked_by, and keeping blocked_on matches "add, do not rename".

Framing note: #14765 was closed by #14772 (merged; it is this branch's base). #14772 already added the blocked modifier, blocked_on and the waiting on … caption. What this PR actually adds on top is: the blocked_by alias, the Actionable · blocked stage-010 headline/chevron, and the Triaged, but blocked; caption prefix — i.e. the parts of #14765's "Expected" list that #14772 left out. The body's "now adds the blocked modifier from Issue.IsBlocked()" describes #14772's work, not this diff. Not a defect, just worth knowing when reading Fixes #14765 against an already-closed issue.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge: the automerge lane will not merge this unattended.

Head: verdict approved @e434e24, 57/57 checks green, DCO yes, soak 7m0s of 30m0s.

How to release it:

  • Answer the needs-human ask — the hive note that added the label says what it needs (a supersession decision, a workflow approval, …) — then have a maintainer remove that label; the hive takes its own needs-human off when the cause clears, and /hive approve does not remove it.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/085-needs-decision A human decision is owed: sentinel alert, hold/needs-decision label, human-only rule or parked issue labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closed as superseded by #14772 by @clubanderson from the Hive dashboard.

Duplicate: #14765 (GitHub blocked-by dependencies on Actionable stage-tracker rows) was fixed by #14772, already merged on v5; this branch now conflicts with it. Thanks @thatguywob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change needs-human needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 stage tracker: issues withheld for open GitHub blockers show as plain Actionable

1 participant