Repository navigation
🐛 fix: show GitHub dependency blockers in stage tracker - #14779
thatguywob wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Show unresolved dependency keys and waiting captions alongside the blocked modifier. Mark the active Actionable step as blocked so operators can distinguish sequencing from scanner starvation. Hive-Run: hivecommons#14765 Hive-Plan: stage-tracker-dependency-visibility Hive-Spec: issue-14765#expected Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
22dd6ff to
e434e24
Compare
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
Decision needed (@hivecommons): #14772 already merged and closed the claimed issue, but this PR touches files the merged PR did not. Recommended: keep open until the extra changes are reviewed, or close as superseded if they are not wanted. Another option: merge anyway. Files the merged PR did not touch: This comment is edited in place by the supersession sweep; it is not duplicated. |
There was a problem hiding this comment.
Read the diff at e434e24 against its merge-base 9de515f (#14772). The code looks correct to me; one framing note for whoever merges.
Verified:
stageTrackerBlockedBy(src/pkg/dashboard/stage_tracker.go:748-770) is still only reached from the issue path atstage_tracker.go:1368withissue.OpenBlockers(), which already sorts (src/pkg/github/issue_dependencies.go:225-234), soslices.Compactis a real de-dupe here, not an adjacent-only one. TheStage > trackerNumberPossiblyExistsguard is unchanged, so 020+ rows stay untouched (stage_tracker_blocked_by_test.go:61now also assertsBlockedBy == nilthere).index.html:curis in scope for the newstepBlockedtest (const cur = Number(item.stage) || 0a few lines above),stageTrackerBlockedTipprefersblocked_byand falls back toblocked_on, and the headline for a plain stage-10 row is stillWaiting for a worker(asserted instage_tracker_ui_test.go).BlockedByis a byte-for-byte copy ofBlockedOn. That is fine — #14765 asked for the field to be calledblocked_by, and keepingblocked_onmatches "add, do not rename".
Framing note: #14765 was closed by #14772 (merged; it is this branch's base). #14772 already added the blocked modifier, blocked_on and the waiting on … caption. What this PR actually adds on top is: the blocked_by alias, the Actionable · blocked stage-010 headline/chevron, and the Triaged, but blocked; caption prefix — i.e. the parts of #14765's "Expected" list that #14772 left out. The body's "now adds the blocked modifier from Issue.IsBlocked()" describes #14772's work, not this diff. Not a defect, just worth knowing when reading Fixes #14765 against an already-closed issue.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge: the automerge lane will not merge this unattended. Head: verdict approved @e434e24, 57/57 checks green, DCO yes, soak 7m0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Closed as superseded by #14772 by @clubanderson from the Hive dashboard. Duplicate: #14765 (GitHub blocked-by dependencies on Actionable stage-tracker rows) was fixed by #14772, already merged on |
Issues withheld by open GitHub dependencies currently look ready for the scanner, making intentional sequencing look like intake starvation. The stage tracker now adds the
blockedmodifier fromIssue.IsBlocked(), exposes unresolved canonical keys inblocked_by, and names predecessors in awaiting on #Ncaption. Stage 010 readsActionable · blockedin the headline and active chevron, with dependency details in the tooltip. Scheduling remains unchanged.Added API regression coverage for open, resolved, empty, duplicate, cross-repository, and label-only blockers, plus rendered UI assertions for the headline, chevron, tooltip, modifier pill, and compact view. Added a changelog fragment.
Validation:
gofmt -lon changed Go files andgit diff --checkpassed. Tests are delegated to CI per AGENTS.md; no local test suite was run.Fixes #14765
— hive: backend=codex
🐝 Hive Agent:
contributor| SHA:22dd6ff1d