Skip to content

test: remove obsolete checks and consolidate test entry points - #338

Merged
guan4tou2 merged 4 commits into
mainfrom
chore/test-suite-cleanup
Oct 16, 2026
Merged

guan4tou2 merged 4 commits into
mainfrom
chore/test-suite-cleanup

Conversation

@guan4tou2

@guan4tou2 guan4tou2 commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Remove duplicate and obsolete tests while preserving coverage for recording, attribution, privacy and evidence integrity. Delete the standalone launch smoke, source-spelling bundle verifier test and deleted-plugin-host guard; retain the title assertion in the isolated project journey, real installed verifier coverage and four plugin manifest/tier cases in their coverage owners. Remove the permanently skipped obsolete HUD proposal while keeping six active HUD journeys. Consolidate numerical contrast in design-tokens without weakening readable-text thresholds.

Make the export-mask fixture wait for the resolved preview dialog’s actual confirm button instead of CSS or the trigger’s text. All three masking/error cases remain. The original Windows failure is preserved; local delayed-preview trials did not independently reproduce its scheduling, so no local RED claim is made for this fixture repair.

Replace TESTING.md with current commands, layers, coverage owners and platform boundaries; archive the historical Part 1–6 matrix. Update the installed-package walkthrough for actual setup, output, HTTP and export behavior. The final 17-path diff against the preceding main is confined to tests, documentation and CI commentary; product PTY repairs are delivered independently by #339.

Validation:

  • All five ordered local gates: 3,605 PASS / 24 explicit SKIP; related test files 39 PASS and all three mask cases PASS.
  • Real Electron project/HUD journeys: 9 PASS, strict JSON without skipped, flaky or not-exercised results.
  • Exact-head three-platform CI: macOS 3,612 PASS / 21 SKIP; Linux 3,608 / 21; Windows 3,290 / 343. Electron journeys 131 PASS / 5 explicit SKIP.
  • Installed Linux DEB: 6 PASS, strict report.

Merged into main and included in v0.18.3. The release’s four public binary downloads match SHA256SUMS; Windows updater metadata matches the actual NSIS binary. The downloaded Mac DMG reports 0.18.3 / isPackaged=true and passes all three strict installed journeys: 100 ordinary Zsh commands with stdout/stderr/failure boundaries, capture/HTTP(S)/export/verifier/restart, and owned installer cancellation. Native WSL and full manual first-install/Gatekeeper acceptance remain outside that evidence.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b9c760eb-99d1-43c6-befd-e9da414fecc0
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant