Repository navigation
test: remove obsolete checks and consolidate test entry points - #338
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate and obsolete tests while preserving coverage for recording, attribution, privacy and evidence integrity. Delete the standalone launch smoke, source-spelling bundle verifier test and deleted-plugin-host guard; retain the title assertion in the isolated project journey, real installed verifier coverage and four plugin manifest/tier cases in their coverage owners. Remove the permanently skipped obsolete HUD proposal while keeping six active HUD journeys. Consolidate numerical contrast in design-tokens without weakening readable-text thresholds.
Make the export-mask fixture wait for the resolved preview dialog’s actual confirm button instead of CSS or the trigger’s text. All three masking/error cases remain. The original Windows failure is preserved; local delayed-preview trials did not independently reproduce its scheduling, so no local RED claim is made for this fixture repair.
Replace TESTING.md with current commands, layers, coverage owners and platform boundaries; archive the historical Part 1–6 matrix. Update the installed-package walkthrough for actual setup, output, HTTP and export behavior. The final 17-path diff against the preceding main is confined to tests, documentation and CI commentary; product PTY repairs are delivered independently by #339.
Validation:
Merged into main and included in v0.18.3. The release’s four public binary downloads match SHA256SUMS; Windows updater metadata matches the actual NSIS binary. The downloaded Mac DMG reports 0.18.3 / isPackaged=true and passes all three strict installed journeys: 100 ordinary Zsh commands with stdout/stderr/failure boundaries, capture/HTTP(S)/export/verifier/restart, and owned installer cancellation. Native WSL and full manual first-install/Gatekeeper acceptance remain outside that evidence.