Repository navigation
fix: recheck PTY bytes after completion and release v0.18.3 - #339
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a remaining macOS output-loss race in the Zsh recorder: after an empty readiness poll, the recorder could be descheduled while the command wrote its final bytes and completed. Releasing the retained slave descriptors using that stale poll flushed unread PTY data on Darwin.
After observing completion, poll readiness again before releasing the descriptors and continue draining queued bytes. The production correction is five lines. A deterministic native-PTY test holds an empty poll until the command has written stdout/stderr and completed: RED loses both bodies; GREEN preserves exact bodies and byte counts. Fast handover, transient EOF/EIO, retirement, terminal control and the 100-command recording checks remain.
Prepare v0.18.3 metadata and release notes. Existing tags are preserved; v0.18.2 is retained as a prerelease with its known recording limitation.
Validation:
Merged into main and included with #338 in the stable v0.18.3 release. All four actual public binary downloads match their checksums and Windows updater metadata matches the actual installer. The public Mac DMG passes strict codesign verification, reports 0.18.3 / isPackaged=true and passes all three installed journeys, including 100 ordinary Zsh commands with stdout/stderr/failure boundaries. Full manual Kali/first-install timing, native WSL, and Mac quarantine/Dock/Developer ID/notarization are still explicitly unverified.