Skip to content

chore: tidy tests — drop e2e leftovers, document load-only races - #388

Merged
guan4tou2 merged 1 commit into
mainfrom
chore/test-tidy
Oct 18, 2026
Merged

guan4tou2 merged 1 commit into
mainfrom
chore/test-tidy

Conversation

@guan4tou2

Copy link
Copy Markdown
Owner

Audit of the suite first, then only what the audit supported:

  • Clean already: no .only, no assertion-free files, no stale test paths in docs/TESTING, RELEASE-SMOKE-TEST or PACKAGED-SMOKE, no tracked .pyc; the skips are environment guards (DB, shell, PowerShell), not dead tests; the slow files are real-PTY zsh tests. test: remove obsolete checks and consolidate test entry points #338 did the large consolidation; reorganising again would be churn.
  • Removed: bisect leftovers in e2e/screenshot-capture.spec.ts and e2e/project-flow.spec.ts (the assertion now carries the result).
  • Documented: coverage rows for the explicit PTY helper and the debug log, and a short section on load-only races (capture: macOS packaged redlog-session 單次 exit 0 卻無 canary 輸出,根因待確認 #333): measure the rate, find the mechanism, pin the property that removes it, and confirm the test fails on the old code — no idle stress loop that proves nothing.

Gates all green (3780 passed).

🤖 Generated with Claude Code

…cannot reproduce

screenshot-capture.spec.ts and project-flow.spec.ts carried console.log lines
from past debugging; the assertions now carry the information. TESTING.md
gets coverage rows for the explicit PTY helper and the debug log, and a short
section on how to treat load-only races (#333) and what to ask for first.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c108df1-d08d-4e0d-af58-69cbac5f4fc6
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@guan4tou2
guan4tou2 merged commit 4e41648 into main Oct 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant