Repository navigation
omamobile-shell: share once-only Chromium and Grok fitting - #581
latentoperator wants to merge 6 commits into
Conversation
|
Thank you, @latentoperator. Taking the browser's scale from the panel instead of the 7 Pro's 0.83 is the right fix, and the Pixel 9a needs it as much as your 6a (405 px at 0.83 is a 488 px layout). The description is also exactly as candid as I'd like about what has and hasn't run. Some direction while it's a draft:
On numbers: 0.2.109 is taken (main is at 0.2.113), and this and #582 both append to |
20c5baf to
b928834
Compare
Use one internal-output geometry path and the established 578 px layout target. Preserve historical setup markers, custom flags and intentional removals; migrate only the generated 0.83 line once. Query Chromium version only when writing a missing UA. Defer Chrome until its quote-aware launcher is released. Focused tests and scratch-home login checks cover migration, quoting, geometry, deliberately removed flags and divergent XDG variables. Full-package phone and reference-device checks remain gates. Package version is assigned by the maintainer at merge as requested on derekross#581. Co-Authored-By: Codex <noreply@openai.com>
|
Thank you, @latentoperator. I went through my six points against the new head and they're all answered. I repeated my scratch-home test: a new user gets the five lines, and after I delete the user agent and the input-method flags the next login leaves them deleted. A home shaped like my 7 Pro's (the old markers and the old file) comes out byte for byte the same and never starts Chromium, a 9a-shaped one moves Chromium from 0.83 to 0.70 once and leaves Grok alone, and later logins start no process at all. The tests pass here on today's main. Two things I'd like changed, both small:
With those in, please take it out of draft. What's left before merge is on phones, not in the code: I'll run it on my Pixel 7 Pro (an existing user and a fresh one, to see the new user-agent line reach Chromium as one argument), and I'd like a Pixel 9a owner to see the one-time 0.83 to 0.70 change. @den-kloot, if you have a moment once it's rebased, that would be you. I'll set the version when I merge. |
Use one internal-output geometry path and the established 578 px layout target. Preserve historical setup markers, custom flags and intentional removals; migrate only the generated 0.83 line once. Query Chromium version only when writing a missing UA. Defer Chrome until its quote-aware launcher is released. Focused tests and scratch-home login checks cover migration, quoting, geometry, deliberately removed flags and divergent XDG variables. Full-package phone and reference-device checks remain gates. Package version is assigned by the maintainer at merge as requested on derekross#581. Co-Authored-By: Codex <noreply@openai.com>
b928834 to
c53a888
Compare
Use one internal-output geometry path and the established 578 px layout target. Preserve historical setup markers, custom flags and intentional removals; migrate only the generated 0.83 line once. Query Chromium version only when writing a missing UA. Defer Chrome until its quote-aware launcher is released. Focused tests and scratch-home login checks cover migration, quoting, geometry, deliberately removed flags and divergent XDG variables. Full-package phone and reference-device checks remain gates. Package version is assigned by the maintainer at merge as requested on derekross#581. Co-Authored-By: Codex <noreply@openai.com>
c53a888 to
8a16a92
Compare
|
Thank you, @latentoperator. Both things from last time are in:
I ran it merged onto today's main: What's left is on phones, as we said. I'll run it on my Pixel 7 Pro with an existing user and a fresh one, and check that the new user-agent line reaches Chromium as one argument. @den-kloot, when you have a moment, could you install this on the Pixel 9a and confirm that Chromium's Two small notes, nothing to change now: #582 appends to |
|
The Pixel 7 Pro run is done, and it passes. The phone: Omarchy 4.5.0-3, An existing user. After the install and one shell restart:
A fresh user (the helper run for an empty home under the live session, so
One thing I noticed, not blocking: the fresh user's user agent is So from my side this is ready. What's left is the Pixel 9a check I asked @den-kloot for (Chromium's 0.83 becoming 0.70 once, Grok Bot's file left alone). I'll merge after that, as 0.2.126 unless something takes the number first. |
Use one internal-output geometry path and the established 578 px layout target. Preserve historical setup markers, custom flags and intentional removals; migrate only the generated 0.83 line once. Query Chromium version only when writing a missing UA. Defer Chrome until its quote-aware launcher is released. Focused tests and scratch-home login checks cover migration, quoting, geometry, deliberately removed flags and divergent XDG variables. Full-package phone and reference-device checks remain gates. Package version is assigned by the maintainer at merge as requested on derekross#581. Co-Authored-By: Codex <noreply@openai.com>
Document the exact combined userspace artifact, deferred-geometry and intentional-removal checks, preserved personal settings and remaining reference-phone gates. Co-Authored-By: Codex <noreply@openai.com>
Record the generic UA choice and completed Pixel 7 Pro check. Name the immutable integration branch so the earlier combined 6a test can be matched to source; the Pixel 9a migration remains a separate gate. Assisted-by: OpenAI Codex
shlex comment mode discards an unquoted URL fragment and every following flag. That made browser setup overlook an existing custom scale and UA, then append generated replacements. Recognize comments only at unquoted token boundaries, matching the launcher parsing behavior, and keep malformed-input refusal. A regression fails with the prior parser and verifies that an app URL followed by custom scale and UA remains unchanged. Direct helper tests also suppress bytecode writes into the packaged bin directory. Assisted-by: OpenAI Codex
…e evidence The exact November 11 package remains the historical phone checkpoint. Record the new URL-fragment preservation fix as an offline-validated follow-up so its coverage is not inferred from that earlier boot. Assisted-by: OpenAI Codex
8a16a92 to
d45d79e
Compare
|
Thank you, @latentoperator. I went through the rebase and the three new commits:
Merged onto today's main it's clean, and your 15 helper tests and the scratch-home test pass here. So the one thing left is the Pixel 9a look. @den-kloot, when you have a few minutes with the 9a: could you install this branch's shell and check that Chromium's |
|
@den-kloot, could you do one quick check of this on your 9a? With this branch installed, Chromium's If nobody with a 9a can try it in the next few days, I'll merge on my 7 Pro run and the 9a-shaped scratch home from 11-11. |
|
Done on the Pixel 9a (
Screenshots: Chromium and Grok Bot 1.0.1 (from the omarchy repo, started from an extracted copy with a throwaway profile), each with the factor given on the command line:
(Measured on my phone with Claude.) |
|
Thanks, @den-kloot. The Chromium result and the second-run byte comparison answer the one-time migration question. Your Grok result also matches this head's rule: an existing My description that the Grok file would stay unchanged was too broad. It stays unchanged when its existing value is already right for the panel, as on Derek's 7 Pro; the generated 0.83 fallback on this 9a is a migration case. I would retain that narrow migration rather than leave Grok clipped at the historical fallback. The screenshots support the 0.70 fit on this phone. Keeping the scope of the evidence precise: you ran |
|
Thank you both. @den-kloot, that was exactly the check I needed, and done the careful way: both files copied first, the helper run twice, and screenshots of each app at both factors. You were right to flag Grok Bot, and so is the code. I went back to main: the Grok step in So this is ready. When I merge I'll push two small things to your branch first: the shell version (0.2.133, after #425 takes 0.2.132), and one line in TOUCH-PLAN, which still says the 9a check "remains before merge", recording den-kloot's result. Then I'll merge once CI has run on that push. |




Share Chromium and Grok Bot's browser fitting through one geometry path and the established 578 px layout target: reference 480 logical px retains 0.83, Pixel 9a's 405 gets 0.70, and Pixel 6a's 360 gets 0.62 for a fresh default. Preserve custom flags, deliberately removed defaults and historical setup markers; migrate only the exact generated 0.83 line once. Chrome defaults remain deferred until launcher #2388 is released.
Chromium's UA/IME/first-run defaults do not wait for panel geometry. Only scale waits; the phone bar retries at shell start with live monitor geometry. A helper failure cannot abort later user setup. Fresh defaults intentionally use a generic Android mobile UA without a device model; existing UA choices stay intact.
November 19 update
Merged upstream
17f9a3cdinto the topic at419df7bf59. Kept both README sections. The browser helper and the package version are unchanged by this refresh. All 15 helper tests,tools/pr-check,tests/all, and all 33 package suites passed on the host. Derek has the version and TOUCH-PLAN edits at merge. Hosted policy, repository tests and all packages passed on this revision.November 14 source refresh
Rebased onto current main
54a6565, preserving the new auto-sleep setup block and its fixtures. Review found an additional preservation edge case: an unquoted URL fragment could make comment parsing hide later custom scale/UA flags. Comments now start only at unquoted token boundaries. The new regression fails on the prior helper and passes with the correction; direct helper tests avoid writing bytecode into the packaged bin directory.Policy, all 15 focused helper tests and the complete
omamobile-shellpackage suite pass. Independent review found no remaining source blocker. Fresh hosted CI run 43652939578 passes policy,tests/alland every package suite ond45d79e145829517b91aaa38a2ba0d7c1fa9b530. The maintainer assigns the package version at merge.Dated runtime evidence and remaining gate
The November 11 combined Pixel 6a package was
omamobile-shell 0.2.119-1, integration83326ed6d09684ae80f38c9360e8c4e864d32614, now published unchanged on bringup/bluejay-userspace-tested-20261111, kernel7.3.0-rc6-omamobile-bluejay-input-gated0. Its exact package SHA and observations remain in TOUCH-PLAN: six required smoke checks passed, 370 package files verified unchanged, geometry-free defaults followed by live 0.62 fitting, intentional UA/IME removals preserved, and the owner's custom 0.70/site zoom/personal plugins preserved.The maintainer's November 12 existing/fresh-user Pixel 7 Pro run passed on the earlier head, including a complete UA arriving as one Chromium argument. Those dated runs do not qualify the new parser edge-case correction or later unrelated main changes; no new phone operation is claimed here.
The Pixel 9a live-helper result is recorded below. Current PR #582's Back routing remains separate.
Pixel 9a live-helper result — November 15, 2026
The owner ran this head's helper directly in the live 9a session, without replacing the installed shell package. Chromium's generated 0.83 scale became 0.70 once; the second invocation left both files byte-identical. The Grok file also migrated 0.83 to 0.70 because it contained the exact unquoted generated default and the historical fit marker. The earlier expectation that Grok would always remain unchanged was too broad: the helper preserves custom values, quoted overrides and deliberately removed scale lines, while migrating that historical generated fallback. The 7 Pro's unchanged 0.83 case and this 9a migration case are distinct.
This supplies live helper migration/repeat evidence, not a new full package-install/login run. The follow-up records that scope and the intended narrow migration for maintainer review. No source change or new version bump was made for this update.