Repository navigation
omamobile-shell: route edge Back inside the shell - #582
latentoperator wants to merge 4 commits into
Conversation
|
Thank you, @latentoperator. Back that actually goes back in a browser is a real gap, and the care about the lock and about not sending browser keys to a prompt is what I'd want. Before you take it further, I'd like to change how it's built:
Practical notes: #521 landed today in the same handler of |
|
A data point from a Pixel 9a for the "no named Escape" case. The packaged back gesture does nothing on the phone with Hyprland 0.57.0 and omamobile-shell 0.2.100 plugins. Sending its Escape by hand:
|
|
@den-kloot, thank you, that's the data point I was asking for, and from a second phone. Two separate things in it, as I read it:
@latentoperator, this changes my third point a little: you don't need to reproduce the failing dispatch, it's here now. It doesn't make the case for |
Dismiss phone panels through in-process callbacks before choosing browser Back from current Wayland/Hyprland focus. Both edges remain Back by default, with Escape for uncertain focus, shell windows and dialogs. Preserve threshold haptics from derekross#521 and retain optional personal right-edge Forward. Use Hyprland keycodes with the existing ordered down/up path instead of a Python state-query helper or wtype. Exact candidate routing tests cover panel subpages, focus changes, Escape fallback, publisher reloads and both edges. Full-package 6a and reference-phone qualification remain required. The maintainer assigns the package version at merge as requested on derekross#582. Co-Authored-By: Codex <noreply@openai.com>
e66f4d1 to
d230d9f
Compare
|
I checked main's Back on my Pixel 7 Pro today (Hyprland 0.57.0, omamobile-shell 0.2.114): the edge swipe goes back in an app. So main's Escape dispatch works here, and what @den-kloot saw ("key not found" for |
|
Correction to my last comment: I was wrong, and @den-kloot was right. I ran the dispatch by hand on my Pixel 7 Pro (hyprland 0.57.0-3.2): The fix is its own small PR, as I said it should be if this turned out to be real: the gesture sends @latentoperator, when you pick this draft up again, please build on that: the Escape path is |
#637) The gesture sent Escape through Hyprland's send_key_state by name. Hyprland 0.57.0 answers key = "Escape" with "send_key_state: key not found" ("Esc" and "code:9" are accepted), so the swipe armed, ticked and sent nothing: Back did nothing anywhere. The dispatch's answer goes to /dev/null, which is why nothing showed it. It now sends code:9 (Escape: evdev's KEY_ESC + 8), which doesn't depend on the key's name or the keyboard layout. Reported by den-kloot on a Pixel 9a (#582). Confirmed and tested on a Pixel 7 Pro on 2026-11-10 (hyprland 0.57.0-3.2): by name "key not found", by code "ok"; with 0.2.116 installed the swipe closes dialogs and sheets again. Apps that don't treat Escape as back are a separate piece of work. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Dismiss phone panels through in-process callbacks before choosing browser Back from current Wayland/Hyprland focus. Both edges remain Back by default, with Escape for uncertain focus, shell windows and dialogs. Preserve threshold haptics from derekross#521 and retain optional personal right-edge Forward. Use Hyprland keycodes with the existing ordered down/up path instead of a Python state-query helper or wtype. Exact candidate routing tests cover panel subpages, focus changes, Escape fallback, publisher reloads and both edges. Full-package 6a and reference-phone qualification remain required. The maintainer assigns the package version at merge as requested on derekross#582. Co-Authored-By: Codex <noreply@openai.com>
637952e to
c9296bc
Compare
|
Thank you, @latentoperator, and thank you for taking all four points: the helper is gone, an uncertain focus ends in Escape, both edges are Back, and the haptic from #521 survived the rebase. The care in the focus check shows. Main moved under you twice more today, though, and I have to ask you to rebuild this on top of it rather than rebase. After the
Against that, here is what I think your PR still adds, and I'd like both parts:
And what I'd leave out: the dispatcher as the main path, One thing to settle between us: with Alt+Left a browser on its first page just stays there on Back, and home is the pill. I think that's fine; say so if you see it differently. Please keep it a draft until it's rebuilt. I'll run it on my Pixel 7 Pro before it merges, since it changes Back for every app, and I set the version at merge. If you'd rather split it, browser Back alone is the smaller and quicker of the two. |
7bf031c to
f17fb0e
Compare
derekross#637) The gesture sent Escape through Hyprland's send_key_state by name. Hyprland 0.57.0 answers key = "Escape" with "send_key_state: key not found" ("Esc" and "code:9" are accepted), so the swipe armed, ticked and sent nothing: Back did nothing anywhere. The dispatch's answer goes to /dev/null, which is why nothing showed it. It now sends code:9 (Escape: evdev's KEY_ESC + 8), which doesn't depend on the key's name or the keyboard layout. Reported by den-kloot on a Pixel 9a (derekross#582). Confirmed and tested on a Pixel 7 Pro on 2026-11-10 (hyprland 0.57.0-3.2): by name "key not found", by code "ok"; with 0.2.116 installed the swipe closes dialogs and sheets again. Apps that don't treat Escape as back are a separate piece of work. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Build browser Back on current main BackLink handling. Preserve keyboard-first, terminal Home and Escape keymap behavior. Register quick settings, drawer and recents in the existing active registry so browser navigation cannot pass underneath them. Choose history from coherent activated browser handles captured at gesture start. Share the packaged reader URL from personal clones. Exercise actual routing/native callbacks and keep the existing surface, haptic and model fixtures current. Full current-main package and attended qualification remain pending. Co-Authored-By: Codex <noreply@openai.com>
Separate physical browser/keyboard-first/Qt results from direct native-surface and permission checks. Name the exact installed artifact and retain latency and reference-phone gates. Co-Authored-By: Codex <noreply@openai.com>
Link the precise combined-package results and distinguish physical browser and Qt checks from handler checks and untested revised kernels. Co-Authored-By: Codex <noreply@openai.com>
f17fb0e to
1aee2fe
Compare
|
Thank you, @latentoperator. This is the rebuild I asked for, and it reads well: the keyboard and the registered surfaces still go first, quick settings with its panels, the drawer and recent apps are on Before it leaves draft:
Then I'll run it on my Pixel 7 Pro as agreed, and set the version when I merge. I didn't resolve the conflict or run the suite on a merge this round. |
Add browser history after main's native BackLink handling. Keyboard dismissal and the topmost registered shell surface run first. If neither consumes Back, a coherent activated non-modal Chrome/Chromium window gets Alt+Left through
wtype; the ordered Hyprland dispatch pair remains the fallback. Unknown, changed or modal focus keeps main's Escape/terminal-Home behavior.Quick settings (including nested Wi-Fi/Bluetooth/Record panels), the app drawer and recents register their existing navigation callbacks with BackLink. Both edges remain Back. Back.qml imports BackLink.js directly. A browser at its first history entry stays there; the home pill remains Home.
November 19 review changes
Head
b9edfe0908includes upstream17f9a3cd. Back always asks the native registry before sending a key. The clone loader, extra reader methods and clone-only test are gone. TOUCH-PLAN and the Bluejay note record the gestures, keyboard dismissal and Qt dialog result from the November 11 combined build at83326ed6.tools/pr-check,tests/all, the shell suite and the offline package build passed. The QML tests exercise both browser edges, changed or modal focus, keyboard precedence and nested shell surfaces. One local full-package run hit the intermittent modem NV overlay test failure. The shell package built as0.2.135-1, the upstream version, and the maintainer assigns its release version at merge.This draft still needs the current package installed on the Pixel 6a, the requested gesture checks and a fresh
tools/phone-smokereport. Derek will then run his Pixel 7 Pro check.