Repository navigation
google-chrome: preserve quoted arguments in user flags - #2388
latentoperator wants to merge 3 commits into
Conversation
0512594 to
8710c51
Compare
[Medium impact] The reviewed changes appear safe to merge. SummaryChrome’s launcher now preserves quoted user flags without running shell code.
The launcher’s source checksum matches. No actionable issues found. Reviews (3) · Last reviewed commit: "Refresh PR 2388 against current upstream..." · Reviewed by Greptile |
|
The URL-fragment finding is valid: This remains unresolved on |
The launcher split a quoted mobile user agent into separate URL arguments, opening broken tabs. Parse flags with shlex and exec an argv vector without evaluating shell code. Keep the config-file precedence over environment flags and preserve command-line arguments verbatim. Reject malformed quoting before Chrome starts. Add the Python runtime dependency, bump pkgrel and update the source hash. Tests cover quoting, comments, literal shell syntax, config paths with spaces, environment fallback and failure without launching the browser. The candidate entry point also ran an isolated aarch64 web-app profile on a Pixel 6a with the complete mobile user agent in one argument. Co-Authored-By: Codex <noreply@openai.com>
Treat a hash as a comment only at an unquoted token boundary, preserving URL fragments and later flags. Keep shlex validation and literal shell syntax. Retain current master vendor version and checksums after rebasing. Validation: ten launcher tests pass; the unquoted fragment regression fails against the old launcher. Pinned-source, metadata and local launcher checksum checks pass. Full builds of the current vendor version remain unverified. Co-Authored-By: Codex <noreply@openai.com>
8710c51 to
eb24a26
Compare
Chrome's old Bash launcher splits a quoted mobile user agent into URL arguments. Parse saved flags into an argv vector without shell evaluation, preserving file-over-environment precedence and command-line arguments. Comments start only at unquoted token boundaries, so
--app=https://example.test/#/inbox --disable-gpukeeps both the URL fragment and the following flag. Malformed quotes or escapes refuse before Chrome launches.November 19 update
Head
d9eaf826e3uses upstream Chrome158.0.8127.36, preserves both vendor checksums, and bumps pkgrel to 2. All ten launcher tests, the pinned-source check and the vendored-key check passed.Both architecture packages built with makepkg. Each archive contains the tested launcher and declares its Python dependency. On x86_64 the packaged launcher passed the complete quoted mobile user agent to headless Chrome. The aarch64 package installed with dependencies in an isolated ARM container. Pacman verified all 305 files, and the packaged launcher reported
Google Chrome 158.0.8127.36under emulation. The upstream Tests, Check Shadowed Packages and Build changed packages workflows await maintainer approval.The earlier package and runtime checks below used the November 14 head.
November 14 update
The November 14 refresh retained upstream
157.0.8103.78and both vendor archive checksums, bumps pkgrel to 2, adds the Python runtime dependency and updates the launcher source hash. It adds no mobile UA/scaling defaults.Validation on the November 14 head
makepkgvendor packages157.0.8103.78-2build for x86_64 and aarch64 with pinned source checks passing. Both archives contain the exact reviewed launcher and declared Python dependency; ELF architecture and all-root archive ownership checks pass.Mozilla/5.0 (Linux; Android) Mobileuser agent as one argument.Mobile #581 continues to defer Chrome defaults until this quote-aware launcher is released. The earlier .50 package results are historical; the current .78 replacement has the build/install/runtime checks above. Fresh hosted checks and maintainer build/workflow approval remain required.