Repository navigation
Conversation
omamobile-setup-user gives Chromium an Android user agent so sites send their phone versions. WhatsApp Web answers it with "Use WhatsApp Web by going to web.whatsapp.com from a browser on your computer" and no sign-in code, so the WhatsApp web app was no use on a phone (docs/TOUCH-PLAN.md 3.1 expected this). A new patch in both families (legacy-4.0.6/0031, patches/0029) makes omarchy-launch-webapp start https://web.whatsapp.com with its own profile (~/.local/share/omarchy/webapps/web.whatsapp.com) and a desktop user agent for the browser's major version and the machine. A user agent is per browser process, so the own profile is what lets it differ; it also skips the hand-off to a running browser. The window class stays chrome-web.whatsapp.com__-Default, which the shell's launch matching expects. Every other web app launches as before. Google Messages for Web shows the same page with either user agent, so it is not listed. Tested on a Pixel 9a with Chromium as the web-app browser and the setup-user flags: before, WhatsApp's "use a computer" page; with the patched launcher, its "Scan to log in" page, in a chrome-web.whatsapp.com__-Default window. test/all: 165 ok; with OMARCHY_PKG set to the signed aarch64 omarchy 4.0.6-1 (30 patches applied, none upstream) and 4.5.0-3 (the 4.5 series applies): pass. test/source-family.py counts 30 legacy patches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for this. TOUCH-PLAN 3.1 has been waiting for exactly this patch, One change before I merge, where the profile lives. The patch puts it Two smaller things, as you like:
On the version: #599 goes in first as 0.1.40, so 0.1.41 is right for this |
… name x86_64 in its user agent Review of derekross#610. ~/.local/share/omarchy is not a free name: Omarchy's upgrade tools still treat it as the old checkout, and omarchy-upgrade-to-quattro moves it aside and leaves a symlink to /usr/share/omarchy. On a phone where that happens, the WhatsApp sign-in would end up in the backup and Chromium would be asked to create its profile under /usr/share/omarchy. The profile now lives in a directory of ours, ${XDG_DATA_HOME:-$HOME/.local/share}/omamobile/webapps/<host>, in both families and their comments. Desktop Chromium on Linux sends "X11; Linux x86_64" on every CPU, so the user agent names x86_64 instead of $(uname -m), which gave aarch64, a string hardly any real desktop sends. Both patches were regenerated from the launcher in the signed aarch64 omarchy 4.0.6-1 and 4.5.0-3 packages and apply to them with --fuzz=0. On the Pixel 9a the new 4.0.6 launcher, with a throwaway profile, opened WhatsApp at "Scan to log in" in a chrome-web.whatsapp.com__-Default window, its profile under omamobile/webapps/web.whatsapp.com. docs/TOUCH-PLAN.md 3.1 records that WhatsApp is done and Google Messages needed nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the review. All three are in
Both patches were regenerated from the launcher in the signed aarch64 I didn't rebase, so the |
|
Thanks, all three are in and I checked them: the profile is under One thing left, and it's main's doing, not yours: 0.1.41 was taken this That push will also give this head its first CI run: your last commit After that I'll try the WhatsApp icon on my 7 Pro, sign-in included, and |
… after main's 0029 and 0030 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… after main's 0031 Main took 0.1.41 (derekross#632) and then went on to 0.1.48, and its 0031 is the first-run unit skip, so the WhatsApp patch moves to 0032 in the 4.5 family. The 4.0.6 family keeps 0031. TOUCH-PLAN 3.1 and item 5 name the new number and version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks @derekross, and sorry this took a while. Main moved on in the meantime, so 0.1.42 was taken too: I merged today's main (
Head |
|
Thank you, @den-kloot, and no need to apologise: main moved three times under this one. 0.1.49 is right today, in the I checked the patches again against the signed packages: the 4.5 one (0032) and the 4.0.6 one both apply to their launchers with no fuzz. I also ran the patched 4.5 launcher against stand-ins: WhatsApp's URLs get the own profile under One change, and it comes from a rule that landed after my last comment, not from anything you did. Since phones moved to Omarchy 4.5, After that the remaining step is mine: the WhatsApp icon on my 7 Pro, on Omarchy 4.5 with the package built from your branch, sign-in included. Your runs on the 9a used the 4.0.6 launcher, so this will be the 4.5 patch's first run on a phone. I'll post what I see, then merge. |
What and why
omamobile-setup-usergives Chromium an Android user agent so sites send their phone versions. WhatsApp Web answers that with "Use WhatsApp Web by going to web.whatsapp.com from a browser on your computer" and shows no sign-in code. So the WhatsApp web app is no use on a phone.docs/TOUCH-PLAN.md3.1 already expected this and suggested a per-site flag inomarchy-launch-webapp. This is that.A new Omarchy patch in both families (
legacy-4.0.6/0031,patches/0029) makesomarchy-launch-webappstarthttps://web.whatsapp.comdifferently:~/.local/share/omamobile/webapps/web.whatsapp.com($XDG_DATA_HOMEhonoured). Not under~/.local/share/omarchy: Omarchy's upgrade tools still treat that as the old checkout and move it aside.X11; Linux x86_64, as desktop Chromium on Linux sends on every CPU, with the browser's major version.A user agent is per browser process, and the own profile is what lets this one differ. It also skips the hand-off to a running browser. The window class stays
chrome-web.whatsapp.com__-Default, which the shell's launch matching (test/launch.py) expects. Every other web app launches as before. Google Messages for Web shows the same page with either user agent, so it isn't listed.Before and after, on a Pixel 9a. The QR code was still loading in the "after" shot, so no sign-in code is published.
Device and build
chromium-flags.conffrom setup-user (Android user agent, scale 0.83)uname -r): 7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78 (a local build; unrelated)Checks (no phone needed)
tools/pr-check upstream/mainpassestests/all: not runpackages/omamobile-omarchy/test/allwithOMARCHY_PKGset to the signed aarch64omarchy-4.0.6-1(30 applied, none upstream) andomarchy-4.5.0-3(every shipped runtime patch applied). After the review change, on the phone, one check fails in both runs, and the same way on unchangedupstream/main: the qmlformat parse of Omarchy'sBackground.qml(and, with 4.0.6,notifications/Service.qml), which this pull request doesn't touch. Both patches were regenerated from the launcher in those two packages and apply with--fuzz=0.test/source-family.pynow counts 30 legacy patchesCo-Authored-By:trailer, noSigned-off-by:On the phone
omarchy-launch-webappwith Chromium as the web-app browser, against a fresh profile each time (again after the review change: profile underomamobile/webapps/,x86_64in the user agent, still "Scan to log in"):chrome-web.whatsapp.com__-Defaultwindow.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)Not fixed here, the window width: on the 9a, Chromium at setup-user's 0.83 lays out wider than the 405 px screen, so the right edge of the page is cut off. That shows in the "after" shot and affects every Chromium window on narrower phones. #581 (browser scale from the output geometry) covers it, and this patch doesn't set a scale.
🤖 Generated with Claude Code