Repository navigation
omamobile-shell 0.2.108: the home strip under the keyboard on the home screen and over the drawer - #557
Conversation
…e screen and over the drawer With the keyboard up on the home screen (the dock's search pill) or over the drawer (its search field), the keyboard covers the dock, and with it the swipe up. The strip wasn't mapped there, so the only way out was the keyboard's Hide key first. While the keyboard is up the strip now shows on the home screen and over the open drawer too. Its swipe up hides the keyboard and opens the drawer from the home screen (as the dock's swipe does), or closes the drawer over it. Over the drawer a long swipe or a hold opens no recent apps: in the first version it did, and the drawer stayed half open over the app picked from them. The dock still reserves nothing on the home screen, so the strip is the only reserving bottom window there. test/pill-touch: the keyboard on home brings the strip (alone), a swipe in it on home opens the drawer and hides the keyboard, and over the drawer it closes the drawer with no recent apps. test/all follows the new condition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01176vSdGN6JWgiwDLYXe1ES
|
Thanks, this is a clear write-up, and I like that you put the invariant change in front of me rather than burying it. The branches read right (over the drawer close it, on home open it, over an app as before), the guard against recents over the drawer is a good catch from your hand test, and the three new pill-touch cases pass here along with the rest of the suite. Before I decide, I'd like to try two paths on my 7 Pro, because
If you can try those two on the 9a as well when you do your hand check, that would help. On versions: #553 also takes 0.2.108, and git merges two identical version lines without a conflict, so I'll merge #553 first and renumber this one to 0.2.109 myself. |
# Conflicts: # packages/omamobile-shell/version
|
Merged as omamobile-shell 0.2.113 (five shell PRs landed in a row today, so the number moved again). I tried both paths on my 7 Pro, the Wi-Fi password from the home screen and a lock taken from home, and I'm happy with the strip showing under any keyboard. Thank you, @den-kloot. |
…e screen and over the drawer (derekross#557) With the keyboard up on the home screen (the dock's search pill) or over the drawer (its search field), the keyboard covers the dock, and with it the swipe up. The strip wasn't mapped there, so the only way out was the keyboard's Hide key first. While the keyboard is up the strip now shows on the home screen and over the open drawer too. Its swipe up hides the keyboard and opens the drawer from the home screen (as the dock's swipe does), or closes the drawer over it. Over the drawer a long swipe or a hold opens no recent apps: in the first version it did, and the drawer stayed half open over the app picked from them. The dock still reserves nothing on the home screen, so the strip is the only reserving bottom window there. test/pill-touch: the keyboard on home brings the strip (alone), a swipe in it on home opens the drawer and hides the keyboard, and over the drawer it closes the drawer with no recent apps. test/all follows the new condition. Claude-Session: https://claude.ai/code/session_01176vSdGN6JWgiwDLYXe1ES Co-authored-by: den-kloot <1522975+den-kloot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Derek Ross <derekross@gmail.com>
What and why
With the keyboard up on the home screen (after a tap on the dock's search pill) or over the open drawer (its search field), the keyboard covers the dock, and with it the swipe up. The home strip wasn't mapped there (by design:
stripShownrequired an app on screen and a closed drawer), so the only way out was the keyboard's Hide key first. On the phone this felt like the gesture bar was simply missing.While the keyboard is up, the strip now shows on the home screen and over the open drawer too:
expand()), as the dock's swipe would.dismiss(0)). A long swipe or a hold opens no recent apps there: a first version did, and after picking an app from recents the drawer stayed half open over it (seen on the phone, screenshot kept locally).This deliberately changes an invariant the tests pinned ("nor the strip with the keyboard on home"), so it is up to you whether the strip belongs there. The dock still reserves nothing on the home screen, so the strip stays the only reserving bottom window (
test_never_two_reserving_bottom_windows_at_oncepasses for all 32 states).Device and build
uname -r): 7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78 (a local debug build)Checks (no phone needed)
tools/pr-check upstream/mainpassestests/all: not re-run for this branch; on the sibling branch (omamobile-shell 0.2.119: a swipe up closes the shade card and the Wi-Fi and Bluetooth panels #553) only twotests/kernel-pr-checkcases failed, which need a kernel tree the phone checkout doesn't havepackages/omamobile-shell/test/allpasses (301 ok);test/pill-touch27 passedCo-Authored-By:trailer, noSigned-off-by:New in
test/pill-touch:test_the_keyboard_on_home_brings_the_strip,test_swipe_in_the_keyboard_strip_on_home_opens_the_drawer,test_swipe_in_the_keyboard_strip_over_the_drawer_closes_it(the harness gains adismissstand-in).test_home_reserves_nothingloses its keyboard line, andtest/all's strip condition check follows the new condition.On the phone
~/.config/omarchy/plugins/omamobile.launcher) over omamobile-shell 0.2.100, not a built package. The local copy callsshell.summon(pluginId, "{}")where this PR callsexpand(), which does the same.hyprctl layers). It cannot swipe. I (the owner) tried it by hand: the strip appeared over the drawer's search, and my long swipe there left the drawer half open over the terminal, which led to the "no recents over the drawer" part. The final version is on the phone; I will confirm it by hand in a comment.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)🤖 Generated with Claude Code
https://claude.ai/code/session_01176vSdGN6JWgiwDLYXe1ES