Skip to content

docs/review: round 46's lessons (L-598 to L-657) - #570

Merged
derekross merged 1 commit into
mainfrom
docs-review-round46
Nov 9, 2026
Merged

derekross merged 1 commit into
mainfrom
docs-review-round46

Conversation

@derekross

Copy link
Copy Markdown
Owner

Round 46's review lessons, for the maintainer to confirm. Stacked on #551 (round 45's lessons, branch docs-review-round45): merge #551 first, then retarget this to main.

Sources: every round-46 review file's candidate lessons, the round's own process slips, and the 2026.11.08 release PRs (#547, #548, #549, #550, #560).

New lessons

Safety model (AGENTS.md section 1)

  • L-598 A code change that enables a protected-partition write waits until its evidence is called verified, not provisional.
  • L-599 (Provisional) A same-state row for slot metadata has no slot boot between its two reads.
  • L-600 A "read-only check" a contributor reports is also read for what the phone is running now.
  • L-601 A guard change that makes a partition writable is checked for a writer in the same tree.
  • L-602 A contributor's note that a documented recovery path didn't work on their phone is checked against what the PR changes before it lands in the device's notes.
  • L-603 A boot that replaces multi-user.target as the default loses everything wanted only there
  • L-604 A PR that touches AGENTS.md or CONTRIBUTING.md is word-diffed in full against its own parent, not only read where its topic is.
  • L-605 When a safety fix's only way back is a step the device can't take, the decision says so.

Shared code and the reference device

  • L-606 A shared stop-path fix proven on one phone's unit is checked against the other phone's unit settings.
  • L-607 "Enabled" read from systemctl is-enabled, or from "not masked", is wrong for a unit started by a vendor wants link in one device package and by nothing on the others.
  • L-608 A feature split into "opt-in" and "helper" parts is checked for which parts are actually behind the opt-in.
  • L-609 A hand copy that one PR's record reveals is checked against the package another open PR ships for that phone.
  • L-610 A stacked draft that carries another open PR's commits inherits that PR's pending reference-phone run, and the review says whose run it is.
  • L-611 A consumer-side "re-apply the pins" fix in a shared driver is shown cheetah-neutral through the pinctrl core's early returns, node by node.
  • L-612 Before planning a contributor's own test of a shared-driver path, check that their board's DT takes it.

Shell and scripts

  • L-613 An EXIT trap that clears a hang marker also runs when systemd times the unit out.
  • L-614 A flag that blocks a repeated user action is checked for where it is cleared.
  • L-615 When a PR serializes one caller of a shared state change, the review re-lists the callers on today's main, not on the PR's base.
  • L-616 Moving a UI removal behind an acknowledgment is checked against what the row's own animation leaves on screen while it waits.
  • L-617 A feature flag that a backend must report starts false in the UI.
  • L-618 A Qt fixture that stands in for a production animation is checked for how that animation is declared.
  • L-619 A gesture strip at z: 100 over a scrolling list is probed for which of the two takes an upward drag.
  • L-620 A drag handler that measures mouse.y - startY inside an item its own offset moves follows the finger at half speed.
  • L-621 A surface condition that adds "or the keyboard is up" is checked against every client that raises the keyboard, not only the one the PR is about.
  • L-622 Relaxing one term of a visibility condition can expose an old race that the term used to mask.
  • L-623 When a fix removes an error, check what that error was stopping.
  • L-624 A fix that refuses a command is grepped against our own runbooks for that command.
  • L-625 A sleep test run through a direct /sys/power/state freeze doesn't cover hooks added in the same PR.

Kernel (linux-omarchy-mobile)

  • L-626 A per-state "not for s2idle" switch is checked against the s2idle fallback, not only find_deepest_state().
  • L-627 A platform driver's sleep callback that "refuses before the PCI core suspends" its root port runs after it
  • L-628 A PMIC register a fix clears at power off is checked for who sets it again at boot.
  • L-629 A stopgap that publishes a sensor's fallback state publishes only the values the fallback gets right.
  • L-630 A "logging only" change to a retry path is re-counted against the base's current retry count.

The gates themselves

  • L-631 A detached-signature tamper test changes a byte inside the signed data or the signature packet.
  • L-632 A signature check behind an unsigned index proves who signed the file, not that it is current.
  • L-633 An identifier-scan exemption justified by IEEE address bits is checked against Bluetooth addressing, and scoped to the file that needed it.
  • L-634 The release scan's MAC pattern has blind spots a reviewer of an exemption should know
  • L-635 A gate's input collection is checked to land, not only its matcher.
  • L-636 A path-scoped exemption is mutation-tested for its scope, not only its content.
  • L-637 A count assertion over a series directory is a merge hazard.
  • L-638 kernel-pr-check's base device-tree build races with itself.
  • L-639 A new depends on a virtual name is checked for its provides.
  • L-640 A package bump is checked for version strings the package's own code prints.

Reviews and merging

  • L-641 Parallel reviewers work under a per-review topic, in ref names and in a per-review scratch subfolder, and never glob-delete shared names.
  • L-642 After a maintainer fixup to a contributor branch, run the touched package's whole test/all, not a subset.
  • L-643 A maintainer fixup on a contributor's branch is a new commit on top, not an amend.
  • L-644 A stacked branch under a squash-merged base is rebased with --onto <base head>, and the review says so.
  • L-645 An expectation we write into one PR about another PR's head goes stale when that PR is fixed, and the contributor may copy it into a runbook.
  • L-646 "The tested tree carries over" is checked per file by blob against a reconstructed tested tree, when the tested kernel was a local merge.

Claims and evidence

  • L-647 A flag file for an app from [omarchy] is checked against that app's launcher in the signed package.
  • L-648 A thread reply posted next to a notes commit is compared with the commit, fact by fact, in UTC.
  • L-649 A tool's documentation isn't a record of a run, and a console that ends at the confirm prompt doesn't show the write.
  • L-650 A phone run in an app's preview or demo mode is checked for what the mode skips.
  • L-651 A shell page with a pluggable backend is tested on the backend the repository ships, not only on a private one.
  • L-652 "Stopped after X" in a report about an upstream script is checked against that script's order at the version the phone runs.
  • L-653 Release notes started from the previous release's are grepped for that release's version and for every sentence that rested on its evidence.
  • L-654 A "fixed" line in release notes is checked against the open issue and the notes' own known issues.
  • L-655 "A kernel update through the hook" is checked against which images the hook wrote.
  • L-656 A record of a hook or push write that names only some images is a reproducibility question.
  • L-657 A NOTES entry that records harm from a step also updates the older gotcha that prescribes that step.

Corrections

Extended instead of duplicated

tools/pr-check origin/docs-review-round45: all ok.

🤖 Generated with Claude Code

Base automatically changed from docs-review-round45 to main November 9, 2026 18:16
Round 46's confirmed candidates from the reviews of the open
omarchy-mobile and linux-omarchy-mobile pull requests, the round's own
process slips (shared refs and scratch files deleted by glob, a
maintainer fixup that skipped the package's test/all, an amend on a
contributor branch) and the 2026.11.08 release PRs (#547, #548, #549,
#550, #560). Repeats of existing lessons extend them instead: L-45
(kernel #222), L-183 (#409), L-426 (the round's version collisions,
now set by hand at merge) and L-550 (#471 with #420). C-34 and C-35
correct our #290 shell suggestion and round 45's claim that
tests/dipper-probe guards anything.

Stacked on #551 (round 45's lessons).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross
derekross force-pushed the docs-review-round46 branch from 160c097 to ccecd20 Compare November 9, 2026 18:16
@derekross
derekross merged commit 3f110bd into main Nov 9, 2026
@derekross
derekross deleted the docs-review-round46 branch November 9, 2026 18:17
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
Round 46's confirmed candidates from the reviews of the open
omarchy-mobile and linux-omarchy-mobile pull requests, the round's own
process slips (shared refs and scratch files deleted by glob, a
maintainer fixup that skipped the package's test/all, an amend on a
contributor branch) and the 2026.11.08 release PRs (derekross#547, derekross#548, derekross#549,
derekross#550, derekross#560). Repeats of existing lessons extend them instead: L-45
(kernel derekross#222), L-183 (derekross#409), L-426 (the round's version collisions,
now set by hand at merge) and L-550 (derekross#471 with derekross#420). C-34 and C-35
correct our derekross#290 shell suggestion and round 45's claim that
tests/dipper-probe guards anything.

Stacked on derekross#551 (round 45's lessons).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant