Repository navigation
docs/review: round 46's lessons (L-598 to L-657) - #570
Merged
Merged
Conversation
Round 46's confirmed candidates from the reviews of the open omarchy-mobile and linux-omarchy-mobile pull requests, the round's own process slips (shared refs and scratch files deleted by glob, a maintainer fixup that skipped the package's test/all, an amend on a contributor branch) and the 2026.11.08 release PRs (#547, #548, #549, #550, #560). Repeats of existing lessons extend them instead: L-45 (kernel #222), L-183 (#409), L-426 (the round's version collisions, now set by hand at merge) and L-550 (#471 with #420). C-34 and C-35 correct our #290 shell suggestion and round 45's claim that tests/dipper-probe guards anything. Stacked on #551 (round 45's lessons). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross
force-pushed
the
docs-review-round46
branch
from
November 9, 2026 18:16
160c097 to
ccecd20
Compare
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
Round 46's confirmed candidates from the reviews of the open omarchy-mobile and linux-omarchy-mobile pull requests, the round's own process slips (shared refs and scratch files deleted by glob, a maintainer fixup that skipped the package's test/all, an amend on a contributor branch) and the 2026.11.08 release PRs (derekross#547, derekross#548, derekross#549, derekross#550, derekross#560). Repeats of existing lessons extend them instead: L-45 (kernel derekross#222), L-183 (derekross#409), L-426 (the round's version collisions, now set by hand at merge) and L-550 (derekross#471 with derekross#420). C-34 and C-35 correct our derekross#290 shell suggestion and round 45's claim that tests/dipper-probe guards anything. Stacked on derekross#551 (round 45's lessons). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 46's review lessons, for the maintainer to confirm. Stacked on #551 (round 45's lessons, branch
docs-review-round45): merge #551 first, then retarget this tomain.Sources: every round-46 review file's candidate lessons, the round's own process slips, and the 2026.11.08 release PRs (#547, #548, #549, #550, #560).
New lessons
Safety model (AGENTS.md section 1)
multi-user.targetas the default loses everything wanted only thereShared code and the reference device
systemctl is-enabled, or from "not masked", is wrong for a unit started by a vendor wants link in one device package and by nothing on the others.Shell and scripts
EXITtrap that clears a hang marker also runs when systemd times the unit out.z: 100over a scrolling list is probed for which of the two takes an upward drag.mouse.y - startYinside an item its own offset moves follows the finger at half speed./sys/power/statefreeze doesn't cover hooks added in the same PR.Kernel (linux-omarchy-mobile)
find_deepest_state().The gates themselves
kernel-pr-check's base device-tree build races with itself.dependson a virtual name is checked for itsprovides.Reviews and merging
test/all, not a subset.--onto <base head>, and the review says so.Claims and evidence
[omarchy]is checked against that app's launcher in the signed package.pushwrite that names only some images is a reproducibility question.Corrections
mapfile -t a < <(…) || die, can never fail; run a suggested shell error-handling form once with a failing command before posting it.tests/dipper-probepasses without checking anything calls it; L-586 applies totests/too.Extended instead of duplicated
test/allwithOMARCHY_PKGper family on the resolved tree.tools/pr-check origin/docs-review-round45: all ok.🤖 Generated with Claude Code