Repository navigation
omamobile-shell 0.2.132: the fingerprint glyph appears when the fingerprint stack starts after the shell - #425
Conversation
…rprint stack starts after the shell The fingerprint plugin reads the bridge's state file once at start and then follows it with a file watch, re-reading on a timer only while the glyph shows. When the fingerprint stack starts after the shell, the file and its directory don't exist yet, so the watch has nothing to follow and the glyph never appears, although fingerprint unlock works. On the palmtop on 2026-11-04 the stack started a few minutes after login and the lock screen showed no glyph until the shell was restarted. The re-read timer now also runs while there is no state, every 2 s, until the file appears.
|
Thank you, @W4HO-ham, for chasing this down. The diagnosis is spot on: with no state file and no directory when I think the fix covers only the first read, though. In Quickshell's Two more things:
One housekeeping note: #421 also takes shell 0.2.101, so whichever lands second will move to the next version. |
…e only where the stack is installed The plugin is on for every phone, and on one without the fingerprint stack the state file never appears, so the re-read every 2 s ran for the life of the shell. It now runs with no state only where omamobile-fp-chroot is installed, the same test the Setup menu's Fingerprint entry uses.
|
Thanks. On the watch: in the Quickshell the phones run (0.3.2.r7.g2b4501a), The limit is in. With no state, the timer now runs only where the fingerprint stack is installed, tested the way the Setup menu tests it ( The palmtop run you asked for still has to happen: a reboot where the stack starts after the shell, then the lock with fprintd verifying, the glyph and the state call, and a smoke report. The palmtop is in a suspend series now, so that comes after. |
|
Thank you, @W4HO-ham, and you're right about the watch. I went back to The new commit is just what I hoped for. The re-read with no state now runs only where the runner is installed, using the same test as the Setup menu and onboarding. A phone with the package but no running stack still checks every two seconds, but that's cheap and I'm happy with it. The only thing left is the palmtop run you described: a reboot where the stack starts after the shell, the lock with fprintd verifying, the glyph, the On the version: several shell PRs are open at 0.2.101 right now, so I'll set the number and the title myself when I merge. You don't need to push anything for that. |
…tack # Conflicts: # packages/omamobile-shell/version
Main took 0.2.126 for another change; the number is the maintainer's to set at merge.
|
Thanks for keeping this merged up with main. I went through it again against today's tree, now that the phones are on Omarchy 4.5 and the shell is at 0.2.126:
So the code is where we left it on 11-07, and the one thing still open is the same: a run on a phone with this head installed as a package. A boot where the fingerprint stack starts after the shell, then the lock with fprintd verifying, the glyph, the output of Two notes, nothing to do for either:
|
|
The palmtop run, on this head installed as a package (8bc5910, built on the palmtop with The late start, from a reboot. The 9a still starts its fingerprint stack from the bring-up unit (
So the plugin had the sensor within a poll of the file appearing, 9 s after a start that came 50 s into the boot, with no shell restart. The lock. The owner pressed Power to lock and again to wake. He saw the glyph about a quarter of a second after the press, put his finger on it and was let in. The plugin's state through it, asked every 0.25 s:
One thing I didn't record: a line from fprintd itself for the verify. The tools/phone-smoke, the same bootphone-smoke: teguKernel
Packages: hyprland 0.57.0-3.3, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.2-1, omamobile-audio 0.5.18-1, omamobile-device-tegu 0.2.16-1, omamobile-fingerprint 0.1.17-1, omamobile-firstboot 0.1.4-1, omamobile-gnss 0.2.9-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.20-1, omamobile-modem-sit 0.3.37-1, omamobile-omarchy 0.1.43-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.127-1, omamobile-telephony-tegu 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1.1 On |
|
Thank you, that is exactly the run I asked for, and done the careful way: the late start came from a reboot with the bring-up unit held back, nothing was stopped and started in one boot, and the unit is enabled again. It shows both halves. The plugin had the sensor within a poll of the state file appearing, 9 s after a start that came 50 s into the boot, with no shell restart. And at the lock, The smoke report is clean and from the same boot, and the package was built from this head. Nothing more is needed from you here. I'm merging it. The branch says 0.2.127, which main took yesterday with the Do Not Disturb change, so I'll push the next free number to your branch first and merge once CI has run on it; the title gets the same number. Thanks also for offering the same re-read for |
…tack # Conflicts: # packages/omamobile-shell/version
…tack # Conflicts: # packages/omamobile-shell/version
|
Thank you for merging main again and setting 0.2.132 yourself: that is the next free number, one above main's 0.2.131, so the version is settled without my push. The plugin file is byte for byte the one from your Pixel 9a run, CI is green on this head and it merges cleanly, so I'm merging it now. Sorry it took two more days after I said I would. |
The version numbers for this pull request. omamobile-shell takes 0.2.133 because derekross#425 took 0.2.132 on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On the palmtop this morning fingerprint unlock worked but the lock screen showed no fingerprint glyph. The fingerprint stack had started a few minutes after login, and the plugin only reads the bridge's state file at start and through a file watch; with no file and no directory yet, the watch never fires, and the timed re-read runs only while the glyph shows. A shell restart brought the glyph back.
The re-read timer now also runs while there is no state (every 2 s), so the glyph appears once the stack starts, whenever that is. The shell's test suite and tools/pr-check pass.