Skip to content

docs/review: lessons from round 42 (L-486 to L-530, C-30 to C-31) - #481

Merged
derekross merged 2 commits into
mainfrom
docs-review-round42
Nov 7, 2026
Merged

derekross merged 2 commits into
mainfrom
docs-review-round42

Conversation

@derekross

Copy link
Copy Markdown
Owner

Round 42's confirmed lessons and two corrections in docs/review/LESSONS.md.

  • L-486: A docs or roadmap PR is read for safety disclosures, not only for status words.
  • L-487: A guide that tells agents how to drive a phone carries AGENTS' shared-phone rules in its prompt.
  • L-488: A plan's account of a safety deviation is checked against what the contributor said in the thread.
  • L-489: A per-SoC flag keyed on a compatible is checked for that compatible's existence on the base.
  • L-490: A shared-path change gated on a pointer a probe-time table lookup can clear runs only on boards in that table.
  • L-491: A compositor or shell patch that changes what every phone shows is a reference-phone change, even when it fixes a bug the 7 Pro probably has.
  • L-492: A contributor's finding on one device's guard is checked against the same rule on the reference phone.
  • L-493: A "no-op on cheetah" premise is checked against the reference phone's logs, not a plan table, and a runbook's Expect is not a result.
  • L-494: A link constraint one PR documents for a shared C source is checked against every open PR editing that file.
  • L-495: A port of a hang-safe start script carries every guard of the original, not only the marker.
  • L-496: A script that writes a module parameter at boot loads the module first or orders itself after it.
  • L-497: A helper added beside a bundled tool goes into the bundle with it.
  • L-498: An extracted Omarchy package is read through its own usr/bin.
  • L-499: A stand-in named after an upstream stage replaces it in every release that calls that name, the pinned one included.
  • L-500: A base-system requirement a new upstream release adds is checked everywhere the release enforces it.
  • L-501: A file capability set during a rootless image build is checked by CapEff on the phone, not getcap.
  • L-502: A "keep it until confirmed" change in a bridge is checked for what clears an object whose confirmation can't arrive.
  • L-503: "Appended at the end, so no offset moves" is checked for structs that embed the grown struct.
  • L-504: A new ->set_cs branch for GPIO chip selects is dead unless the controller sets SPI_CONTROLLER_GPIO_SS.
  • L-505: A board PR that moves a bring-up overlay into the DTS is proven by comparing DTBs, not by a new boot.
  • L-506: A vendor command borrowed for a fallback reads its answer where the vendor driver does.
  • L-507: A board DT that gives a new node a GPIO or supply is checked against the board's other users of it.
  • L-508: A "new" panel driver is diffed against the closest merged one with names normalised.
  • L-509: A board added to the base after a PR's last gate inherits its shared-dtsi changes, so the re-gate validates it.
  • L-510: Agent identities and session trailers on every commit are a finding tools/pr-check doesn't catch.
  • L-511: A | grep -q flake that never shows on CI is reproduced with an unbuffered writer.
  • L-512: A package without test/all gets its patch series applied by hand in review.
  • L-513: A package test that skips without the repository can skip the assertion the fix adds.
  • L-514: A refused-method test entry a random string would also pass tests nothing about the device.
  • L-515: A gate is checked for who creates its precondition in the product, not in the test.
  • L-516: A plan check whose failure falls back to a plain list says "ok" for the case it exists to catch.
  • L-517: A migration hold list is run over the release's real migrations and checked against the holds we promised.
  • L-518: A test that greps a tool's source for an implementation detail proves nothing about behaviour.
  • L-519: A request or merge order that rests on another decision is re-derived when that decision changes.
  • L-520: A general call to affected users is checked against the thread above it.
  • L-521: A hand-written squash subject is checked against the PR's own files.
  • L-522: A GitHub comment draft is reflowed, never inside code fences.
  • L-523: When a series selector accepts exact versions, removing a pin moves the hold rather than lifting it.
  • L-524: A package claim about installed phones, or a way back we suggest, is simulated per image against the live repository order.
  • L-525: A negative control that fails only through failOnWarning proves a warning, not a failure.
  • L-526: An IPC reply quoted as an acknowledgment is checked against when the handler returns it.
  • L-527: A devinfo row whose retry byte disagrees with getvar for "the same state" is a disagreement, not evidence.
  • L-528: A comment copied from a sibling board is checked against the PR's own results.
  • L-529: A matrix number is checked for whether it was measured or configured.
  • L-530: A result that needs the Arch session can't come from a command line that stays in the initramfs.
  • C-30: Round 41 told omamobile-shell 0.2.132: the fingerprint glyph appears when the fingerprint stack starts after the shell #425's author that Quickshell's FileView::reload() doesn't re-arm its file watch; it does.
  • C-31: On 10-29 we told kernel tools/phone-mirror: the panel size from the phone #116's author the MIF restore is a no-op on cheetah because the bootloader leaves MIF at 3172 MHz.

🤖 Generated with Claude Code

derekross and others added 2 commits November 7, 2026 09:33
Round 42's confirmed candidate lessons, merged across batches, plus the
maintainer's own from today: squash subjects checked against the PR's
files, comment drafts reflowed outside code fences, behaviour tests over
source greps, and two corrections (Quickshell's FileView::reload() does
re-arm its watch; the 7 Pro's MIF is 2028 MHz at probe, not 3172 MHz).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross
derekross merged commit e6a7004 into main Nov 7, 2026
2 checks passed
@derekross
derekross deleted the docs-review-round42 branch November 7, 2026 15:48
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…rekross#481)

The confirmed lessons from review round 42 (2026-11-07), L-486 to L-530, and corrections C-30 (Quickshell's FileView::reload() does re-arm its watch) and C-31 (the Pixel 7 Pro's MIF reads 2028 MHz at probe, not 3172 MHz), so the next reviews know them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant