Repository navigation
docs/review: lessons from round 42 (L-486 to L-530, C-30 to C-31) - #481
Merged
Merged
Conversation
Round 42's confirmed candidate lessons, merged across batches, plus the maintainer's own from today: squash subjects checked against the PR's files, comment drafts reflowed outside code fences, behaviour tests over source greps, and two corrections (Quickshell's FileView::reload() does re-arm its watch; the 7 Pro's MIF is 2028 MHz at probe, not 3172 MHz). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…rekross#481) The confirmed lessons from review round 42 (2026-11-07), L-486 to L-530, and corrections C-30 (Quickshell's FileView::reload() does re-arm its watch) and C-31 (the Pixel 7 Pro's MIF reads 2028 MHz at probe, not 3172 MHz), so the next reviews know them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 42's confirmed lessons and two corrections in docs/review/LESSONS.md.
usr/bin.CapEffon the phone, notgetcap.->set_csbranch for GPIO chip selects is dead unless the controller setsSPI_CONTROLLER_GPIO_SS.tools/pr-checkdoesn't catch.| grep -qflake that never shows on CI is reproduced with an unbuffered writer.test/allgets its patch series applied by hand in review.failOnWarningproves a warning, not a failure.getvarfor "the same state" is a disagreement, not evidence.FileView::reload()doesn't re-arm its file watch; it does.🤖 Generated with Claude Code