Skip to content

omamobile-shell 0.2.127: the Do Not Disturb tile and home toggle read Omarchy 4.5's state - #694

Merged
derekross merged 1 commit into
mainfrom
shell-dnd-state-45
Nov 12, 2026
Merged

derekross merged 1 commit into
mainfrom
shell-dnd-state-45

Conversation

@derekross

Copy link
Copy Markdown
Owner

Found by the round 53 review of #652.

The quick-settings tile and the home screen's toggle read Do Not Disturb with the notification service's dndState call. Omarchy 4.5 renamed it to isDnd. On the Pixel 7 Pro (Omarchy 4.5.0-3) today:

Call Answer
notifications dndState Function not found.
notifications isDnd off

So on 4.5 both controls kept whatever state they started with: Do Not Disturb turned on from anywhere else never showed. Setting it from the tile still worked, because setDnd kept its name.

Fix: both run one line that asks isDnd first and dndState second, so a 4.0 phone behaves as before. test/dnd-state.sh takes that line from the QML itself and runs it against a stand-in for each service, and checks the two places use the same line.

Not run on the phone: the changed tile and toggle. The check is: turn Do Not Disturb on from a terminal (omarchy-shell notifications setDnd on), open quick settings, and the tile should read On.

Shell 0.2.127. #555 and #425 carry the same number and take the next one at merge.

🤖 Generated with Claude Code

… Omarchy 4.5's state

The quick-settings tile and the home screen's toggle read Do Not Disturb
with the notification service's dndState call. Omarchy 4.5 renamed it to
isDnd and answers "Function not found" to the old name, so on 4.5 both
kept whatever state they started with: turning Do Not Disturb on from
anywhere else never showed. Setting it from the tile still worked, since
setDnd kept its name.

Both now run one line that asks isDnd first and dndState second, so 4.0
phones are unchanged. test/dnd-state.sh takes that line from the QML and
runs it against a stand-in for each service.

On the Pixel 7 Pro (Omarchy 4.5.0-3): `notifications dndState` answers
"Function not found." and `isDnd` answers "off". The changed tile has
not been run on the phone.

Found by the round 53 review of #652.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross
derekross merged commit bb15d78 into main Nov 12, 2026
2 checks passed
@derekross
derekross deleted the shell-dnd-state-45 branch November 12, 2026 14:12
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
… Omarchy 4.5's state (derekross#694)

The quick-settings tile and the home screen's toggle read Do Not Disturb
with the notification service's dndState call. Omarchy 4.5 renamed it to
isDnd and answers "Function not found" to the old name, so on 4.5 both
kept whatever state they started with: turning Do Not Disturb on from
anywhere else never showed. Setting it from the tile still worked, since
setDnd kept its name.

Both now run one line that asks isDnd first and dndState second, so 4.0
phones are unchanged. test/dnd-state.sh takes that line from the QML and
runs it against a stand-in for each service.

On the Pixel 7 Pro (Omarchy 4.5.0-3): `notifications dndState` answers
"Function not found." and `isDnd` answers "off". The changed tile has
not been run on the phone.

Found by the round 53 review of derekross#652.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant