Repository navigation
omamobile-shell 0.2.127: the Do Not Disturb tile and home toggle read Omarchy 4.5's state - #694
Merged
Merged
Conversation
… Omarchy 4.5's state The quick-settings tile and the home screen's toggle read Do Not Disturb with the notification service's dndState call. Omarchy 4.5 renamed it to isDnd and answers "Function not found" to the old name, so on 4.5 both kept whatever state they started with: turning Do Not Disturb on from anywhere else never showed. Setting it from the tile still worked, since setDnd kept its name. Both now run one line that asks isDnd first and dndState second, so 4.0 phones are unchanged. test/dnd-state.sh takes that line from the QML and runs it against a stand-in for each service. On the Pixel 7 Pro (Omarchy 4.5.0-3): `notifications dndState` answers "Function not found." and `isDnd` answers "off". The changed tile has not been run on the phone. Found by the round 53 review of #652. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
8 of 9 tasks
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
… Omarchy 4.5's state (derekross#694) The quick-settings tile and the home screen's toggle read Do Not Disturb with the notification service's dndState call. Omarchy 4.5 renamed it to isDnd and answers "Function not found" to the old name, so on 4.5 both kept whatever state they started with: turning Do Not Disturb on from anywhere else never showed. Setting it from the tile still worked, since setDnd kept its name. Both now run one line that asks isDnd first and dndState second, so 4.0 phones are unchanged. test/dnd-state.sh takes that line from the QML and runs it against a stand-in for each service. On the Pixel 7 Pro (Omarchy 4.5.0-3): `notifications dndState` answers "Function not found." and `isDnd` answers "off". The changed tile has not been run on the phone. Found by the round 53 review of derekross#652. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the round 53 review of #652.
The quick-settings tile and the home screen's toggle read Do Not Disturb with the notification service's
dndStatecall. Omarchy 4.5 renamed it toisDnd. On the Pixel 7 Pro (Omarchy 4.5.0-3) today:notifications dndStateFunction not found.notifications isDndoffSo on 4.5 both controls kept whatever state they started with: Do Not Disturb turned on from anywhere else never showed. Setting it from the tile still worked, because
setDndkept its name.Fix: both run one line that asks
isDndfirst anddndStatesecond, so a 4.0 phone behaves as before.test/dnd-state.shtakes that line from the QML itself and runs it against a stand-in for each service, and checks the two places use the same line.Not run on the phone: the changed tile and toggle. The check is: turn Do Not Disturb on from a terminal (
omarchy-shell notifications setDnd on), open quick settings, and the tile should read On.Shell 0.2.127. #555 and #425 carry the same number and take the next one at merge.
🤖 Generated with Claude Code