Repository navigation
arm64: dts: exynos: google: gs201-lynx: enable Bluetooth on the APM UART - #98
Conversation
|
Thank you, @FlorencioJP. Bluetooth on a second gs201 phone is very welcome. The commit message already holds the two things I'd most want written down: the 3.2 Mbaud failure, with 1, 2 and 3 Mbaud working, and why the Some things need sorting out before it can merge:
Smaller things: one line of the message is 76 characters (checkpatch flags it). The node has no device-wake or host-wake line; that's fine for hci_qca, but it means Bluetooth can't wake the phone, so please say so. On order: #93 (touch) also appends to the end of |
674ef41 to
f58642f
Compare
|
Thanks for the review. Done on the branch (same tree, new commit
|
|
Thank you, @FlorencioJP, for the quick turnaround. The new commit fixes the identity: author and signer are both you, the Where things stand:
On order: I publish the pin controller, you rebase onto it with the PMU node, and once CI is green including Thanks again. This is careful work, and the 3.2 Mbaud finding and the |
|
Draft of the What changes against the reviewed head: the fixed regulator stays, as the PMU's input, and the Bluetooth node loses The choices, so you can object to any of them:
One thing for the module side, which goes in the package, not this PR: Next boot, once you have looked at this and the pin controller is out: the PMU version, with |
|
@derekross, the evidence boot on the PMU version, tonight, without waiting for your look at the draft, since it only cost a Boot. No line from
Power-off. Module order. The hazard from the draft is real on this phone: That file and One thing found on the way, package side, not the DT. After a rebind of
( Still not run: |
|
Thank you, @FlorencioJP, for sending the draft before spending a boot on it. It's the shape I hoped for. Your reading of the sequencer is right: the buck with its 7 ms startup delay, then BT_EN, then 50 ms, so the order and the delay before BT_EN match the version you tested. Off is BT_EN low and then the regulators, so Bluetooth still drops the buck until a Wi-Fi node takes the The pin controller is published: cb71d6e on Without it the file still compiles and validates, because the I built your draft on today's On your four choices:
On the module note, one correction. You're right that hci_qca discards the For the rebased commit, the points from before still stand: keep the sentence that Bluetooth owns Thanks again. Reading the binding and the driver this closely before a boot saves us both time. |
f58642f to
5127dc7
Compare
|
@derekross, rebased onto Evidence boot on this file's DTB (
Package side, done on the phone since: |
|
Thank you, @FlorencioJP. This is the version I hoped for: the PMU node, Our gate on this head, merged onto today's On your question, the smoke table on today's Two small things before I merge:
After the re-push, CI will need my approval again, and I'll approve it. If Thanks again for checking the module ordering and the rebind race on the phone. Those notes will save the next person a lot of time. |
The Pixel 7a carries the WCN6855 BT core on the APM USI1 UART (ttySAC18 in Google's kernel), as cheetah carries its BCM4389. Enable cmu_apm, usi_apm1, serial_apm1, pinctrl_peric0 and pinctrl_hsi2, and describe the controller as qcom,wcn6855-bt powered by a qcom,wcn6855-pmu node (pwrseq-qcom-wcn): BT_EN on gpp16-2, and the 0.95 V buck shared with Wi-Fi on gph2-5 as the sequencer's input, a fixed regulator with the 7 ms ramp stock btpower waits before BT_EN. The sequencer then holds BT_EN high and waits 50 ms. No wlan-enable-gpios is given: WLAN_EN (gph2-4) stays low until a PCIe node takes the sequencer's wlan target. With this node Bluetooth owns gph2-5 and drops it on power-off: off is BT_EN low and then the regulators, so the buck goes down whenever Bluetooth goes down (stock btpower never drops it), including once at every boot while the controller has no address yet. The five PMIC rails behind the chip's I/O, 1.3 V and 1.9 V inputs are an always-on stand-in regulator: stock's device tree names no supply on its cnss2 or btpower node, so which PMIC regulators feed them is unknown. No device-wake or host-wake line is described, so Bluetooth cannot wake the phone. max-speed is 3 Mbaud: at 3.2 Mbaud every TLV segment of the firmware download answers with "Frame reassembly failed (-84)" on this UART; 1, 2 and 3 Mbaud work. Tested on one phone (chip revision 0x400c0210; untested on 0x400c1211) with hci_uart/btqca, pwrseq-qcom-wcn and linux-firmware's qca/hpbtfw21.tlv + hpnv21.bin, on 7.3.0-rc6-omamobile-lynx-wifi1 with this file's DTB: the sequencer holds the buck (five users), BT_EN and gph2-5 read high, firmware loaded 3 s after boot, controller powered, a 20 s scan sees the neighbours, and unbinding the serdev driver drops both pins and disables the buck. The controller reports no public address; userspace sets the one the bootloader publishes in /chosen/config/bt_addr. Facts and log excerpts: derekross/omarchy-mobile#98 and device/lynx/NOTES.md there. These nodes must be enabled in the boot DTB: enabling cmu_apm through a runtime overlay oopses, since gs201_cmu_probe is __init. Assisted-by: LLM Signed-off-by: Jean-Paul Florencio <jpflorencio@version-tracker.app>
5127dc7 to
a28238c
Compare
|
@derekross, both done. The newline is back, in the same commit: a28238c, same parent cb71d6e, same message, only the last byte of |
|
Thank you, @FlorencioJP, both are done. a28238c differs from 5127dc7 only in the final newline: same parent, same message, and checkpatch no longer warns. Both comments now read One follow-up on the privacy point, nothing for you to do: GitHub keeps the original text of an edited comment in its edit history, which anyone can open from the "edited" menu, so the address is still visible there for both comments. I've deleted those two original revisions on my side. Our gate on this head, merged onto today's Thanks again for the patience across the rounds. This is a clean, well-evidenced node. |
Bluetooth for the Pixel 7a (lynx): the WCN6855 BT core on the APM USI1 UART, on the same shape as cheetah's BCM4389 block.
cmu_apm,usi_apm1,serial_apm1,pinctrl_peric0enabled;bluetoothchildqcom,wcn6855-bt, BT_EN gpp16-2, the Wi-Fi/BT 0.95 V buck on gph2-5 as a fixed regulator with a 7 ms startup delay (stockbtpowerorder). WLAN_EN stays low.max-speed = <3000000>: 3.2 Mbaud fails every TLV segment (Frame reassembly failed (-84)thencommand 0xfc00 tx timeout); 1, 2 and 3 Mbaud work.hci_uart/btqcaandlinux-firmware-atheros(qca/hpbtfw21.tlv,hpnv21.bin): SOC version0x400c0210, firmware loaded at 3 s,Powered: yes, scan lists the neighbours. The controller has no public address of its own; userspace sets the bootloader's/chosen/config/bt_addr, as cheetah'somamobile-bt-addrdoes (userspace side in derekross/omarchy-mobile, separate PR).cmu_apmby runtime overlay oopses (gs201_cmu_probeis__init), so the nodes live in the boot DTB.Context and logs: derekross/omarchy-mobile#36 (comment 6455522265).