Repository navigation
arm64: dts: exynos: google: gs201-lynx: enable the touchscreen - #93
Conversation
|
Thank you, @latentoperator. Touch on a second gs201 phone is a nice step, and the series is shaped the way I'd want it: the binding, then the driver, then the board, each with its own reason. The board change stays in One thing before it can merge: a rebase. #91 landed on Please also make one small change in that push: Things I checked against Google's source, and some suggestions, none holding this:
Once the rebase and the |
The GT9895 is a Berlin-series controller used over SPI in the Pixel 7a. It uses the same register map and supplies as the GT9916. Assisted-by: LLM Signed-off-by: Chris Gray <chrisgray70@gmail.com>
The GT9895 in the Pixel 7a uses the GT9916's register map, but its firmware reports 14 bytes per contact instead of 8: the usual status, x, y and width, then a pressure byte, both axes and an orientation. The checksum follows the last record as before. With 8-byte records every touch fails the checksum. Make the record size part of the per-chip data, keep 8 bytes as the default, and add a GT9895 entry that uses 14. The extra fields are not reported yet. Tested on a Pixel 7a: touches report with no checksum errors, and touch input works in the desktop session. Assisted-by: LLM Signed-off-by: Chris Gray <chrisgray70@gmail.com>
The touchscreen is a Goodix GT9895 on USI0's SPI, with the interrupt, reset and chip select on the same pins as on cheetah. Unlike cheetah, the bootloader leaves its supplies (S2MPG12 LDO25M and LDO26M) off, so describe the main PMIC with those two rails and let the driver enable them. LDO25M is the 1.8 V I/O rail (PP1800_L25M_TSP_DVDD), so it is fixed at 1.8 V rather than the LDO's 1.6-1.95 V range; LDO26M is fixed at 3.0 V as in stock's lynx PMIC description. The PMIC's RTC now sets the clock at boot. Tested on a Pixel 7a from slot B: the controller identifies, and touch input works in the desktop session. Assisted-by: LLM Signed-off-by: Chris Gray <chrisgray70@gmail.com>
4f21900 to
f9d10b0
Compare
|
Thanks @derekross. Rebased onto The phone hasn't booted the The rest I'll do with the next boot of an |
|
Thank you, @latentoperator. Everything I asked for is in. The rebase dropped the duplicate UFS commit, the binding and driver commits are unchanged, and the board commit now fixes Holding the chip select delay and the One heads-up: FlorencioJP's Bluetooth PR (#98) also adds a block at the end of I'll rebase-merge the three commits. |
What and why
Enables the touchscreen on the Pixel 7a (lynx). Three commits on today's
omamobile(rebased after #91 merged).PP1800_L25M_TSP_DVDDI/O rail) and LDO26M at 3.0 V, as stock's lynx PMIC file pins it. With the main PMIC described, its RTC also sets the clock at boot.Tracking issue: derekross/omarchy-mobile#36.
Device and build
7.3.0-rc6-omamobile-push1-g38b5a04d67e0from slot B with the Arch root. That build is on an olderomamobile; its PMIC and USI0 nodes and goodix-berlin sources are the same as these commits' except for theldo25mrange (below), and its touchscreen node differs only in also havingtouchscreen-x-mmandtouchscreen-y-mm, which the binding does not allow and goodix-berlin does not read, so they are dropped here.On the phone
input: Goodix Berlin Capacitive TouchScreen as .../10d10000.spi/spi_master/spi0/spi0.0/input/input0vddio-tsat 1800 mV (range 1600-1950 mV in that build) andavdd-tsat 3000 mV, both enabled, one consumer each. The rail already sat at 1.8 V, so fixingldo25mat 1800-1800 mV in this push only stops a consumer from moving it; that one line is not yet booted on the phone. The core logsavdd-ts: Bringing 3300000uV into 3000000-3000000uVonce at probe.touch data checksum errorin dmesg after 2 h 20 min up. Touch input works in the Hyprland session.s5m-rtc s2mpg12-rtc: registered as rtc0, and it sets the system clock at boot.Checks
tools/kernel-pr-check --build OUT --merge origin/omamobilefrom omarchy-mobile (a74e329), with dtschema installed, over the three commits:I used an AI assistant (Claude Code) for this; the commits carry
Assisted-by: LLM.🤖 Generated with Claude Code