Repository navigation
arm64: dts: exynos: google: oriole: describe disabled BCM4389 Bluetooth - #159
Conversation
ede647c to
7eb78da
Compare
|
Thanks for this. I've approved the CI runs. I'll review it properly once it's out of draft and the questions on omarchy-mobile#200 are answered. |
7eb78da to
fc47cf8
Compare
fc47cf8 to
fa104f7
Compare
|
Thank you, @Gr-linkk, and thanks for keeping it disabled until it's been tried on this kernel. I checked the wiring Two changes before I merge:
Two optional touches: the Our gate passes on today's |
Describe the BCM4389 on the existing APM USI1 UART, including the pin states required when the device is enabled later. The control lines and 3 Mbaud rate match Raven and Google's common gs101 Bluetooth wiring. Keep the controller disabled until this kernel and its native CMU_APM baud clock path have been qualified on Oriole. Historical bring-up used a different dirty kernel and a clock workaround. Signed-off-by: Garrett lindquist <gr_link@hotmail.com>
fa104f7 to
772d700
Compare
|
Thank you, @Gr-linkk. Both changes are in, and the optional ones too. The node and its three pin groups now match raven's line for line, the prefix is the file's own, and the board file carries only the child. Our gate passes on today's One small thing: the PR description still says "hardware qualification remains the draft's merge blocker". That's no longer true, and only the commit message lands, so it's just for anyone reading the PR later. When you get to trying it on the phone, the overlay will need to switch on |
Add Oriole's BCM4389 Bluetooth child on APM USI1/UART16, disabled together with its parent controllers pending current-kernel qualification. GPIOs and host-wakeup IRQ follow the retained Oriole bring-up wiring; maximum speed is 3 Mbaud.
Dependencies already present in base
51fb40d2b87398dd38ec860e9cda4e487fbf3b0d:b8c4ca7a6: GS101 APM USI1/UART16 SoC nodes, reused without duplication.b3664451c: corrected read-only APM mux descriptions, not reapplied.The UART baud clock uses CMU_APM
CLK_GOUT_APM_APM_USI1_UART_IPCLK, parentdout_apm_usi1_uart, sourced fromgout_apm_func. No fixed-factor workaround, assigned rate, or shared mux write is added. No dependency on PR #98 (GS201 Lynx) or #122 (Zumapro Tegu); existing open PRs were checked for overlap.Validation:
W=1: pass.git diff --checkand strict checkpatch (--no-signoff): pass.Limitations: no phone operations or current-kernel hardware validation. Historical loopback, HCI and BLE keyboard evidence belongs to
4bd35d34abb9-dirtywith the historical clock workaround; it does not qualify this clock path or kernel. Firmware/address provisioning, runtime UART/HCI qualification, audio and suspend are outside this disabled integration. The historical enable overlays reference the removed workaround clock and must be adapted before any future trial; no enable overlay is shipped here. Hardware qualification remains the draft's merge blocker.