Repository navigation
arm64: dts: exynos: google: gs201-panther: add Wi-Fi - #195
angelrenefm wants to merge 1 commit into
Conversation
026baf8 to
c9d7fd9
Compare
|
@angelrenefm, a second run on my Pixel 7, as derekross asked. It's on
The log lines worth knowing about, none of which stopped anything:
Not tested: the boot unit ( I'm working on this with AI help (Claude). 🤖 Generated with Claude Code |
|
@nesmeck, thank you for the stacked run on your Pixel 7, and for the UFS stress alongside it: that's the test this change most needed, and more than mine covered. I also checked the stacking on my side: this commit applies cleanly on top of #196 (on I used AI help (Claude) to work on this. |
|
Thank you, @angelrenefm, and thank you @nesmeck for the second run. The nodes are cheetah's exactly, with the restricted DMA pool and its Checks on my side: nesmeck's run is the one that matters most for merging: Merge order: omarchy-mobile#419 first, so every Pixel 7 has the autoload blacklist before a kernel with this node reaches it, then this one. Small things, none blocking:
Thanks for a careful, well-documented first kernel PR. |
The Pixel 7 has the Pixel 7 Pro's BCM4389 on the same PCIe lines: stock's panther MP overlay (board id 0x30406) puts WL_REG_ON on gph2-4, WL_DEV_WAKE on gph2-5 and WL_HOST_WAKE on gpa6-1, as cheetah's does, and keeps the PCIe rails always on. Google's own device tree agrees: in kernel/devices/google/pantah (branch android-gs-pantah-6.1-android16), gs201-panther-common.dtsi includes the same gs201-cloudripper-wlan.dtsi as the Pixel 7 Pro, and no panther file overrides those pins. Take cheetah's Wi-Fi nodes: the WL_REG_ON regulator, the restricted DMA pool and the Wi-Fi node's memory-region, PCIe GEN4A_1 and its PHY, the System MMU's DMA window and the pins, with the board type the Pixel 7's firmware names carry. Bluetooth is left to its own commit. On a Pixel 7, a kernel with these nodes and the Bluetooth ones brought up the link at Gen2 x1, found BCM4389/3 with the phone's own firmware, and connected wlp1s0 to a network. A second Pixel 7 ran omamobile with only the Bluetooth commit and this one: the link came up on the first try, and in two runs of Wi-Fi downloads alongside heavy writes to userdata every checksum matched. Assisted-by: LLM Signed-off-by: Ángel René <17342133+angelrenefm@users.noreply.github.com>
c9d7fd9 to
dff02cc
Compare
|
@derekross, thanks for the review. I've pushed the three small things, still as one commit:
Since #196 and the flash LED commit have landed, I rebased onto the current Moving the pin changes nothing in the build: Checks: I used AI help (Claude) to work on this. |
|
Thank you, @angelrenefm. All three small points are in, and the rebase onto today's One thing to know: this and your fingerprint PR (#207) both add their nodes at the very end of Order stays as before: omarchy-mobile#419 first, published, then this one. |
Wi-Fi (BCM4389 on PCIe GEN4A_1) for the Pixel 7, as on the Pixel 7 Pro, following derekross's notes on derekross/omarchy-mobile#342. Bluetooth is left to nesmeck's own commit, as agreed on that issue; this one will rebase onto it once it is open.
Why these lines. Stock's PANTHER MP overlay (board id 0x30406, from a Pixel 7's own OTA
dtbo) puts WL_REG_ON on gph2-4, WL_DEV_WAKE on gph2-5 and WL_HOST_WAKE on gpa6-1, the same as CHEETAH MP (0x30306), and keeps the PCIe rails (S2MPG13 LDO3S and LDO18S) always on, as cheetah. So the commit takes cheetah's Wi-Fi nodes as they are (the WL_REG_ON regulator, PCIe GEN4A_1 and its PHY, the System MMU's DMA window and the three pin groups), withbrcm,board-type = "google,gs201-panther", the name the Pixel 7's firmware files carry.The restricted DMA pool comes with it:
wifi_dma_pool(restricted-dma-pool, 16 MiB below 4 GiB) and the Wi-Fi node'smemory-region, as ings201-cheetah.dts.Tested on a second Pixel 7, not on
omamobilealone. The kernel was7.3.0-rc6-omamobile-push1-g4446f52aefe8:omamobileat fe9627c, plus #181's series as it stood that day (its five display commits and two zuma UFS commits it carried), plus this commit as first posted, which also carried cheetah's Bluetooth nodes. The Wi-Fi nodes here are the same as in that build.brcmfmacfound BCM4389/3 and loaded the Pixel 7's firmware 20.101.91 (from its own OTA withtools/extract-vendor-firmware -d panther; no firmware in any repository);wlp1s0came up and a scan saw 33 networks.…-g3631214cc15a, the same kernel plus a CMA change):brcmf_cfg80211_add_iface: add iface p2p-dev-wlp1s0 type 10 failed: err=-5andWLC_SET_ROAM_TRIGGER error (-52).wlp1s0worked regardless.Not tested: this commit on
omamobilewithout #181; power use; s2idle with Wi-Fi loaded (the suspend tests unloaded it first, as SUSPEND-PLAN does); this Wi-Fi-only build on the phone (it was built and checked, not booted).It needs the package side, derekross/omarchy-mobile#419, which blacklists
pcie_gs201andbrcmfmacand starts them behind a hang marker (Wi-Fi only too); that one should merge with or before this.Checks:
tools/kernel-pr-check --build OUT origin/omamobilepasses everything: the sign-off, no Co-Authored-By, the subject prefix, checkpatch --strict with no warnings, the policy checks, and the 9 device trees with W=1 anddtbs_check(dtschema 2026.9) with no new warnings.I used AI help (Claude) to work on this.