Skip to content

arm64: dts: exynos: google: gs201-panther: describe the fingerprint sensor - #207

Merged
derekross merged 1 commit into
derekross:omamobilefrom
angelrenefm:pr-panther-fingerprint
Nov 7, 2026
Merged

derekross merged 1 commit into
derekross:omamobilefrom
angelrenefm:pr-panther-fingerprint

Conversation

@angelrenefm

Copy link
Copy Markdown
Contributor

Adds the Pixel 7's fingerprint sensor, disabled: the Goodix node as gs201-cheetah has it, the sub-PMIC with LDO15S only, and the two pins. The stock dtbo for board 0x30406 has the same node as cheetah's 0x30306, and the vendor image ships the same trusted app and HAL. omarchy-mobile's bring-up overlay enables Trusty, the sub-PMIC, LDO15S and the sensor.

Tested on my Pixel 7 with these nodes and the overlay (kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795): LDO15S switches with the sensor and no other rail changes, and with the fingerprint stack in derekross/omarchy-mobile#458 a finger enrolled and unlocked the phone, also after a reboot. tools/kernel-pr-check --build: 10 device trees build with W=1 and pass dtbs_check with no new warnings.

That kernel also carried the camera nodes, which share the sub-PMIC node; they're not in this PR, and the fingerprint nodes are the same text. The package side is derekross/omarchy-mobile#458, which should go in with or before this.

I used AI help (Claude) to work on this.

…ensor

The Pixel 7 has the Pixel 7 Pro's Goodix optical under-display sensor.
The stock dtbo for board 0x30406 (the one ABL picks on this phone) has
the same goodixfp node as cheetah's 0x30306: compatible
"goodix,fingerprint", interrupt gpa9-2, reset gpp1-1 (output, no pull,
active low), and the same S2MPG13 LDO15S "L15S_UDFPS_AVDD" with a
2.5-3.3 V range. The vendor image ships the same trusted app (g7.app)
and HAL.

Add the node as gs201-cheetah has it, the sub-PMIC with LDO15S only,
and the two pins. Everything is disabled; a bring-up overlay enables
Trusty, the sub-PMIC, LDO15S and the sensor.

Tested on a Pixel 7 with kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795,
these nodes (the same text) and the overlay: goodix_fp switches LDO15S
on while the sensor is open and off after, with no other rail changing,
and with omarchy-mobile's fingerprint stack a finger enrolled and
unlocked the lock screen, also after a reboot
(device/panther/FINGERPRINT-PLAN.md in omarchy-mobile, gates P1-P5).

Assisted-by: LLM
Signed-off-by: Ángel René <17342133+angelrenefm@users.noreply.github.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, @angelrenefm. This is the 7 Pro's fingerprint description, carried over carefully: the sensor node and both pin groups are line for line what gs201-cheetah.dts has, and keeping LDO15S disabled on its own, so a later camera overlay that switches on the sub-PMIC leaves it alone, is a thoughtful touch. Google's public device tree agrees with your dtbo reading: in kernel/devices/google/pantah (android-gs-pantah-6.1-android16), both the Pixel 7's and the Pixel 7 Pro's *-common.dtsi include the same gs201/gs201-ravenclaw-fingerprint.dtsi, with the interrupt on gpa9-2 and the reset on gpp1-1. If you push again, that citation would be a nice addition to the message.

On my side, tools/kernel-pr-check --build --merge passes in the project container, and the device tree validates with no messages on its own and together with your Wi-Fi and reboot=warm PRs. I also checked that a broken copy is rejected, so the check really ran.

One heads-up: this and #195 both add their blocks at the very end of gs201-panther.dts, so whichever lands second conflicts. Keeping both blocks is the whole resolution; I've built it that way and it's clean, so I can resolve it at merge. Since the nodes are disabled, this can go in before or alongside omarchy-mobile#458.

@derekross
derekross merged commit 9f470db into derekross:omamobile Nov 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants