Skip to content

arm64: dts: exynos: google: gs201-panther: add the rear flash LED - #197

Merged
derekross merged 1 commit into
derekross:omamobilefrom
angelrenefm:pr-panther-torch
Nov 5, 2026
Merged

derekross merged 1 commit into
derekross:omamobilefrom
angelrenefm:pr-panther-torch

Conversation

@angelrenefm

Copy link
Copy Markdown
Contributor

The Pixel 7's rear flash LED, wired as the Pixel 7 Pro's. Stock's panther dtbo (board 0x30406, from this phone's own OTA) and cheetah's (0x30306) have equal hsi2c_15 fragments, flash-en pin state and LWIS flash-lm3644 node: the driver at 0x63 on I2C bus 15 (USI15, 400 kHz, shared with the camera EEPROM at 0x50 and the wireless charger at 0x3c), HWEN on gpp8-2.

So this adds cheetah's led-controller@63 node as it is, torch only, with the same 50 mA per channel bring-up cap (our limit, not a stock value). USI15 and its I2C controller stay disabled as in gs201.dtsi; the package's torch.dtso (derekross/omarchy-mobile#426) turns them on.

One difference from the 7 Pro: this phone's chip reads ID 0x02, an LM3644, not the 7 Pro's LM3644TT (ID 0x04). The driver handles both; the step table is then 36 steps instead of 17.

Measured on a second Pixel 7, kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795 (local branch, see K1) with a DTB carrying this node and torch.dtso (plus the phone's other bring-up overlays):

  • lm3644 5-0063: LM3644 (ID 0x02), torch: 36 steps, 977-49977 uA per channel, white:torch with max_brightness 36.
  • brightness 1 for 4 s: the LED lit (seen by the phone's owner) and went off at 0; the owner also switched it on by hand later.

Not checked: higher steps, the shell's quick-settings toggle, this commit on omamobile alone. It appends at the end of the DTS, as #195 does, so whichever merges second needs a trivial rebase.

Checks: tools/kernel-pr-check --build OUT --merge origin/omamobile passes everything: sign-off, no Co-Authored-By, prefix, checkpatch --strict with no warnings, policy, the 9 device trees with W=1 and dtbs_check with no new warnings. With torch.dtso applied to this DTB, dt-validate reports nothing.

tools/phone-smoke (the same phone, 2026-11-04T18:47Z)

phone-smoke: panther

Kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795, tools at 3435ed4, 2026-11-04T18:47Z.

Check Result Detail
boot (required) ok kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795, slot b, up 865s
storage guard (required) ok 55 partitions; only userdata and slot B's boot images writable
root (required) ok ext4 on userdata, 97G free
kernel health (required) ok no oops or BUG; 0 WARN, 8 error lines in dmesg (8 known, 0 new)
systemd units ok none failed
USB gadget (required) ok bound to 11210000.usb
display ok card2-DSI-1 connected, 1080x2400
GPU ok render node on panthor
session (required) ok Hyprland and the Omarchy shell running
lock ok PAM file present, the shell can lock (passwordPam true, locked true)
touch ok FocalTech FT3658
buttons ok gpio-keys
Wi-Fi ok wlp1s0 on brcmfmac, link up
Bluetooth ok hci0, powered true
battery ok 91% Charging, 33 °C
sound cards ok googleaocsndcar
sensors ok Accelerometer AmbientLight Proximity
cameras skip no libcamera tools
thermal ok hottest zone 49 °C

Packages: hyprland 0.57.0-3.1, libcamera 0.7.2-4.22, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-audio 0.5.13-1, omamobile-device-panther 0.1.5-1, omamobile-firstboot 0.1.3-1, omamobile-gnss 0.2.7-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-omarchy 0.1.28-1, omamobile-owl-widgets 0.1.1-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.79-1, omarchy 4.0.6-1, quickshell 0.3.2.r7.g2b4501a-1

I used AI help (Claude) to work on this.

The Pixel 7's stock dtbo for board 0x30406 wires the rear flash LED as
the Pixel 7 Pro's (board 0x30306): a TI LM3644 at 0x63 on I2C bus 15
(USI15), next to the camera EEPROM at 0x50 and the wireless charger at
0x3c, with the bus at 400 kHz and HWEN on gpp8-2. The hsi2c_15
fragments, the flash-en pin state and the LWIS "flash-lm3644" node
compare equal between the two dtbos.

So add cheetah's led-controller@63 node, torch only, with the same
50 mA bring-up cap per channel (our limit, not a stock value). USI15
and its I2C controller stay disabled as in gs201.dtsi; a bring-up
overlay turns them on.

Booted on a Pixel 7 with this node and that overlay: the driver reads
"LM3644 (ID 0x02)", not the Pixel 7 Pro's LM3644TT (ID 0x04), and
registers white:torch with 36 steps, 977-49977 uA per channel.
Brightness 1 for 4 s lit the LED (seen by the phone's owner).

I used AI help (Claude) to work on this.

Signed-off-by: Ángel René <17342133+angelrenefm@users.noreply.github.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, this is a careful port. The stock comparison holds up in Google's public source too: gs201-panther-camera.dtsi in kernel/devices/google/pantah has the same &hsi2c_15 block, the same flash-en pin and the LM3644 at 0x63 as the 7 Pro's camera dtsi. I'm also glad you noticed the chip is the plain LM3644 rather than the 7 Pro's LM3644TT: that path of the driver hasn't run on the 7 Pro, so keeping the bus behind the overlay for now is the right call.

It builds and validates here, alone and with the overlay from omarchy-mobile#426. The only snag is that it and the Wi-Fi PR (#195) both add to the end of gs201-panther.dts, so whichever goes second needs a trivial merge keeping both blocks; I'll take care of it.

@derekross
derekross merged commit 29a7a93 into derekross:omamobile Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants