Repository navigation
Conversation
|
Thank you, @nesmeck. This is a careful piece of work: staged one change per boot, with the runbook written down before each step, and the padded-row bug found and explained from DRM's own debugfs. The handed-over panel's state is the first commit, as you said it would be on #177, and it matches what the S6E3HC4 driver does today: Our gate passes on today's
One change, please, and then one thing on my side. 1. Please put the padded-row commit before the DECON0 enable. As the series stands, a bisect that stops on "gs201-panther: enable DECON0 for gs-decon" gets a Pixel 7 whose Hyprland modesets all fail and whose screen freezes on the console. That's exactly your D3c first try. The padded-row change only touches 2. The Pixel 7 Pro run is on me. You're right that the last commit changes the reference phone. With
I'll post the results here. One small thing for the last commit's message, not a blocker. Google's gs201 DPP code programs the source width from Thanks again. It's great to see the Pixel 7's screen go dark properly when it's off. |
|
Thanks for the thorough check. Both points are done, and the new head is
The base now includes kernel-pr-check passes on the new head:
omarchy-mobile#281's list of changes follows the new order. Thanks for taking the Pixel 7 Pro run. 🤖 Generated with Claude Code |
da2e805 to
0a132eb
Compare
|
Thank you, @nesmeck, both points are done exactly as asked. I checked the new head:
Nothing more is needed from you. The Pixel 7 Pro run I described last time is next on my side: a kernel built from |
|
D3 on a second Pixel 7 (stock factory unit, CP3A.261005.002.A1 on both slots, devinfo 3.15). Kernel
Not checked: the picture right after the runtime cold inits (measured from SSH only: counters and dmesg). I'm working on this with AI help (Claude). |
|
Thank you, @angelrenefm. A full D3 run on a second Pixel 7 with this PR's exact head is just what this series needed. Stage 0 found ABL's state as on nesmeck's unit, the frame counters show 60 Hz with no storm, 871 flips had no timeouts, and the @nesmeck, nothing more is needed from you here. The head hasn't moved since my last look, and on today's What's left is mine: the Pixel 7 Pro run I described, a kernel from |
0a132eb to
f763cfe
Compare
|
Rebased onto today's
Booted on my Pixel 7 from slot B ( 🤖 Generated with Claude Code |
|
Thank you, @nesmeck, for rebasing over #160 and for booting the result. I read the rebase with One fix, please, and one question: 1. The last commit's message has a diff in it. 2. Which tree booted? Your comment names Two notes for later, nothing to do now:
The Pixel 7 Pro run is still mine, and I'm sorry it has taken this long. It's the same list as before, now on |
f763cfe to
db288b7
Compare
|
Thank you for catching that. The diff was left over from the conflict resolution in my rebase. I've reworded the last commit, and it now ends with The tree that booted is this one.
🤖 Generated with Claude Code |
|
Thank you, @nesmeck. Both points are done. The last commit's message now ends with the two trailers, right after the test paragraph, and none of the five messages has diff text left in it. The tree you booted, I re-ran our gate on today's Nothing more is needed from you. What's left is my Pixel 7 Pro run, on today's One note for afterwards: #202 (the Pixel 7a) now also reads |
Mark a panel taken over from the bootloader as prepared and enabled, so drm_panel_disable() and drm_panel_unprepare() reach it, and track whether it is out of reset and sleep. While it is not, backlight updates only record the new state (drm_panel_enable() applies it through backlight_enable()). prepare() leaves the display off, which the reset does. Take the panel's lock in prepare/enable/disable/unprepare and in backlight updates, so their command sequences don't interleave. This follows the same change to the S6E3HC4 driver, for the Pixel 7 Pro, and lets gs-decon put the Pixel 7's panel to sleep with the screen off. Tested on a Pixel 7 from slot B (7.3.0-rc6), with gs-decon driving the screen: with gs_decon.screen_off=2, DPMS off put the panel to sleep and DPMS on woke it through the cold init (reset, the vendor init at 60 Hz, TE2 and DSC) with the picture correct; the power key's lock turned the screen off and a tap brought it back. No DSIM errors. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
Add the timers the Pixel 7's bootloader leaves on DSIM0 for its S6E3FC3 P10 panel at 60 Hz (UNDERRUN_CTRL 0x1cf8, CMD_TE_CTRL1 0x2a82306d, read on the phone), so gs-decon gets the link and the panel and can put the panel to sleep with the screen off. The set has no second rate: the panel's 90 Hz has no timers yet, so the link is never switched. Tested on a Pixel 7 from slot B (7.3.0-rc6): the driver logs "link timers for 60 Hz", and gs-decon takes the link and puts the panel to sleep and wakes it with the screen off. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
gs201 offered only the Pixel 7 Pro's 1440x3120 modes and refused to run when the bootloader scanned out any other size. Give each SoC a list of mode sets, one per panel, and pick the one whose first mode matches the size the bootloader left, which the probe already reads. Add the Pixel 7's S6E3FC3 P10 at 1080x2400 and 60 Hz, with the timings of Google's panel driver; its 90 Hz mode comes with the link timers for it. Tested on a Pixel 7 from slot B (7.3.0-rc6), with the padded-row change on top: gs-decon binds on the 1080x2400 set, counts frame starts at 60.02 Hz, and Hyprland runs on it at 1080x2400@60 with no flip timeouts. The Pixel 6 Pro's, 7 Pro's, 8 Pro's and 9a's sets are unchanged: one set each. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
gs-decon on gs201 took only framebuffers with the boot framebuffer's pitch. On the Pixel 7, whose DECON0 the next commit enables, Hyprland's buffers for the 1080x2400 panel have a 4352-byte pitch (1080 pixels padded to 64 bytes) where the boot framebuffer has 4320, so every modeset failed the plane check with -EINVAL and the screen froze on the boot console. The Pixel 7 Pro's 1440-pixel rows need no padding, which is why it never showed there. On gs201, DPP0 reads its source width as the row length in pixels, padding included, as G4 does; gs201 packs the source height into the upper half of the same register. This is measured on the Pixel 7, not taken from Google's driver, which programs the source width from fb->width and never scans out a padded stride: with 4352-byte rows and the stride written as the source width, the desktop shows unsheared, where an 8-pixel mismatch per row would shear every line. Set padded_pitch for gs201, write the height back with the width, and cap the width at the 16-bit field. With an unpadded buffer the register gets the same value the bootloader left. Tested on a Pixel 7 from slot B (7.3.0-rc6), with the next commit on top: before this change every Hyprland modeset failed and the screen froze on the boot console; with it the modesets pass, the desktop shows at 1080x2400@60 and stays smooth, with 2624 flips in ten minutes, no flip timeouts and no late flips (latency 8.9 ms on average, 16.8 ms at most). Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
Enable DECON0 with a pool for gs-decon's scanout buffers and the boot framebuffer, as on the Pixel 7 Pro: gs-decon keeps the bootloader's DECON, DSIM and DSC setup, flips DPP0 between buffers, and takes the screen over from simpledrm. The pool has room for five 1080x2400 XRGB8888 buffers, below 4 GiB since DPP0 takes 32-bit addresses with the DPU SysMMU bypassed, and is reusable. Tested on a Pixel 7 from slot B (7.3.0-rc6): gs-decon allocates its scanout buffers from the pool, takes the screen over from simpledrm, and Hyprland flips on it at 60 Hz. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
db288b7 to
3c21907
Compare
|
Rebased onto today's 🤖 Generated with Claude Code |
|
Thank you, @nesmeck, for rebasing again. I read it against the head I checked on the 13th: the four driver commits are unchanged (the three files are the same blobs), and in the DECON0 commit the only difference is that Nothing is needed from you. What's left is still my Pixel 7 Pro run, on today's For the others following: #263 (local HBM) goes in right after this, #268 (GNSS) doesn't conflict with it, and #195 (Wi-Fi) and #202 (the Pixel 7a) rebase onto it. |
The Pixel 7's display through
gs-decon, as on the Pixel 7 Pro: flip-only KMS on ABL's pipeline, vblanks from DECON's frame start, and the panel put to sleep with the screen off. It builds on #177 (the panel driver and the DSI command path). Five commits:drm_panel_disable()/unprepare()reach it;display_pool(five 1080x2400 XRGB8888 buffers, below 4 GiB, reusable) and the boot framebuffer, as on the Pixel 7 Pro.padded_pitchis now set for all of gs201, so each flip writes RDMA_SRC_SIZE.Tested on a Pixel 7 (slot B), staged as in
device/panther/DISPLAY-PLAN.mdD3, one change per boot. Kernel7.3.0-rc6-omamobile-push1-g53fab72d1489wasomamobilecaf5f8a with #133, #171, #170, #177 and this branch. After the rebase onto today'somamobile(8698185),git range-diffshows all five commits unchanged, and every panther file they touch is the same as on that kernel.gs_decon stage=0):screen_off=0sends black frames;screen_off=1stops the frames, with the trigger masked;screen_off=2also puts the panel to sleep, and DPMS on wakes it through the panel's cold init with the picture correct. That was the cold init's first run.screen_off=2, the power key's lock turns the screen off, a tap wakes it, and the PIN works.omamobile-device-panther0.1.5 settingallow_tx=1andscreen_off=2and no bring-up file, everything above comes up on its own. That's omarchy-mobile#281.phone-smoke from that boot
phone-smoke: panther
Kernel
7.3.0-rc6-omamobile-push1-g53fab72d1489, tools at05b472c, 2026-11-01T18:20Z.Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.21, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-device-panther 0.1.5-1, omamobile-firstboot 0.1.2-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-omarchy 0.1.12-1, omamobile-owl-widgets 0.1.1-1, omamobile-shell 0.2.28-1, omarchy 4.0.6-1, quickshell 0.3.2.r7.g2b4501a-1
Checks:
tools/kernel-pr-check --build OUT --merge origin/omamobilepasses everything:🤖 Generated with Claude Code