Repository navigation
feat(api): add the S3 storage identity type - #662
Merged
Merged
Conversation
S3 store IDs hash endpoint, region, bucket and prefix, matching the PVC identity's length-prefixed encoding. PageBroker does not compute this itself for S3 (unlike PVC's ComputeStoreID): #416 reads storeId as a literal config field, so there is no cross-language parity vector to pin here, unlike testdata/identity.json for PVC. Signed-off-by: Oleg Kushniriov <okushniriov@nvidia.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
oleg-kushniriov
added this pull request to stack #664
October 20, 2026 14:26
oleg-kushniriov
marked this pull request as ready for review
October 20, 2026 14:37
danbar2
approved these changes
Oct 21, 2026
oleg-kushniriov
added a commit
that referenced
this pull request
Oct 22, 2026
S3 store IDs hash endpoint, region, bucket and prefix, matching the PVC identity's length-prefixed encoding. PageBroker does not compute this itself for S3 (unlike PVC's ComputeStoreID): #416 reads storeId as a literal config field, so there is no cross-language parity vector to pin here, unlike testdata/identity.json for PVC. Signed-off-by: Oleg Kushniriov <okushniriov@nvidia.com>
oleg-kushniriov
added a commit
that referenced
this pull request
Oct 25, 2026
S3 store IDs hash endpoint, region, bucket and prefix, matching the PVC identity's length-prefixed encoding. PageBroker does not compute this itself for S3 (unlike PVC's ComputeStoreID): #416 reads storeId as a literal config field, so there is no cross-language parity vector to pin here, unlike testdata/identity.json for PVC. Signed-off-by: Oleg Kushniriov <okushniriov@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
storage.S3, hashing endpoint/region/bucket/prefix into a store ID with the same length-prefixed encoding asstorage.PVC.storage.Configgains anS3field alongsidePVC.Part of a stack targeting S3 support in the operator, agent and chart without depending on PageBroker's own S3 implementation (which lands independently). Base is #492.
S3 has no PageBroker-side identity computation to cross-check against: PageBroker reads
storeIdas a literal config field rather than deriving it (see the next PR in this stack), so unlike PVC there is no shared cross-language fixture to pin here.Which issue(s) this PR addresses
Part of #237.
How was this tested?
go build,go vet,gofmt -l,go test ./storage/...(containerized, golang:1.27.2) — all clean.Does this PR introduce an API change?