Repository navigation
Conversation
…alone
The restore report's item line printed its label in a plain span. In a
left-to-right interface the formatter doesn't isolate message values, so a
right-to-left name or one carrying a direction override reordered the
" · section · outcome" text after it. Render the label in a <bdi>, as the
profile line already does.
A profile's status ("· Restored") sits in an inline block that wrapped at
the ordinary space after its "·" when the status alone was wider than the
line, leaving the "·" on a line of its own. Join it to the word with the
same no-break space the item line already uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 36 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| ? t("web.admin.backups.restore.outcome.created") | ||
| : t(outcome.label), | ||
| })} | ||
| {keepSeparatorsWithNext( |
There was a problem hiding this comment.
S1 (low) — The Arabic “Left out” status can spill into the gutter. At a 315 CSS px viewport with a 45 px root font, I rendered the base and head report rows with the Arabic catalog in Chrome 157. The status had 55.25 px available. The base stayed inside the column, while the no-break space changed the emergency wrap in the head and one glyph extended 6 px into the gutter. The same row stayed contained in Firefox and WebKit.
Keep a breakable space as a fallback for Arabic outcomes, or use a separator layout that keeps the status within its column at this width.
There was a problem hiding this comment.
Confirmed in Chromium 153 with the app's Noto Sans Arabic font. With a 36.6 px status font in a 55.25 px column, the start of "مستبعد" overflows by 6 px, and by up to 11.3 px in a 50 px column. Chromium won't make an emergency break right after the no-break space, so "·", the space, and the first letter become the smallest piece it can place. Dropping the isolate characters or using a narrow no-break space gives the same result.
It shows only when the status column is narrower than about 1.8 em (45 to 65 px at that size). In that band the base leaves the "·" alone on a line, which is the bug this PR fixes, and below 45 px the base overflows too. German and Hebrew statuses don't overflow at any width I tried, and the item line on main already joins its "·" the same way. Any join that keeps the "·" with its word has this floor, and removing it brings the lone "·" back, so I'm keeping the change and leaving this thread open for the maintainer to decide.
🤖 Claude Code (claude-opus-5-5)
…ne-layout # Conflicts: # web/src/pages/admin-backups/RestoreRun.tsx
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (the backup restore report is a web admin page with no client counterpart)
Two lines on a backup restore's Run step report could render out of order or with a stray separator.
This change isolates the item's name with
<bdi>, as the profile line's name already is, and joins each profile status's "·" to its word with the no-break space the item line already uses.Approach
Both fixes stay in
RestoreRun.tsx. Making the formatter isolate values in left-to-right interfaces would also fix the item line, but it would change the bytes of every left-to-right message, whichdocs/architecture/i18n.mdrules out.When a profile status is wider than its line, it now breaks inside the word, with the "·" kept on the first part, as the item line already does. It no longer breaks between the "·" and the word.
One edge case is open for the maintainer (review thread S1): in Chromium, when the status column is narrower than about 1.8 em, the Arabic "Left out" status overflows it by up to 11 px, because Chromium won't break right after the no-break space. At those widths the base leaves the "·" alone instead, and the item line already behaves this way. On the real page after
main's row wrapper (#4921), the overflow (8.9 px in a 51 px column) stays inside the wrapper's padding, so nothing reaches past the row.Validation
main(f465d2d9, this PR's current base), and confirmed both are gone on the same deployment and restore job rebuilt at this branch's head (b23b70d, aftermainwas merged in). An earlier pair onc1e36dc4andac47312measured the same. The report covers three accounts: an Arabic name ending in "!", a name starting with a right-to-left override, and a merged account whose restored profile shows "Restored".b23b70d. Locally on the fix commit: web lint, format check, typecheck, production build, bundle budget,verify-local-paths, andverify-bidipass;make test-webhad 29 failures in four unrelated files (request deadlines, auth refresh, player client context) that also fail on the unfixed base on that host. No test covers this component.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/restore-report-line-layout/
Risks
None identified. The change is presentation-only and limited to one web admin component.
Checklist
Follow-ups
RestoreReview.tsx).Council review
Rounds: 2 (round 2 after
mainwas merged in), last reviewed b23b70dBackground review: S1 is the only finding; Sol, Opus, and Gemini found nothing else on
b23b70d, including in the merge resolution with #4921.Visual review: 2 rounds on captures from ac47312 (retaken on b23b70d; same measurements)
Round 2 added right-to-left wrapping at 300 px with a 24 px font, a long account name, and names ending in "!"; those pairs are identical before and after. Answered: a status wider than its line now breaks inside the word, as the item line already did. Pre-existing and left out of this change: the wider gap before a profile line's "·" (the name's end margin, a design call), and narrow-screen issues outside the report lines, which get their own follow-ups.
AI Disclosure
🤖 Generated with Claude Code
Note
Fix RTL text issues in restore report lines in
RestoreRun.tsxReportRowwith abdielement so their text direction is isolated from the surrounding section and outcome text. This stops names from reordering report lines in right-to-left locales.keepSeparatorsWithNextto the translated profile outcome text inAccountReport, so a no-break space keeps the "·" separator with the word it introduces when the line wraps.Both changes are in RestoreRun.tsx.
Macroscope summarized b23b70d.