Skip to content

fix(web): keep restore review names from reordering the text after them - #4969

Merged
Quick104 merged 1 commit into
mainfrom
fix/restore-review-caveat-isolation
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/restore-review-caveat-isolation

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (the backup restore flow exists only in the web admin)

On the backup restore Review step, the "Left out" list shows each caveat as <name>: <text>. In left-to-right interfaces such as English, a right-to-left account name or one containing a direction override (U+202E) changed the reading order of the colon and the sentence after it. An account named U+202E + override turned the whole sentence backwards ("…ereh rotartsinimda na"), and أحمد! put its ! on the colon's side. The formatter isolates message values only in right-to-left interfaces, so Arabic and Hebrew were already correct.

Found while reviewing #4938, which fixed the same mechanism on the Run step's report lines.

Approach

Each name in a caveat is now a <bdi>, in every language. Only the name is isolated, so the colon stays in the page's direction. A profile's caveat label joins two names ("account, profile"), so the caveat now carries both names and isolates each one separately. The plain joined label is still used for the tooltip. In right-to-left interfaces the pair used to take the direction of its first name. Now it follows the page, so the account name comes first in reading order.

The formatter could isolate values in left-to-right interfaces too, but docs/architecture/i18n.md keeps left-to-right output byte-for-byte, so the fix stays with the call site, as #4938 did for the Run step.

Validation

  • Live, on a dev sandbox: two admin accounts named أحمد! and U+202E + override, backed up, deleted, then restored as new so each gets the administrator caveat. On main, English shows the reversed sentence and the misplaced !. With the fix, each name stays inside its own isolate and the sentence reads normally. Arabic looks the same before and after. Checked at desktop and phone width.
  • Profile caveats: the sandbox can't easily produce one, because a library from the backup has to be missing. A temporary render test with an admin account أحمد! and a profile U+202E + override failed on main (names not isolated) and passed with the fix (each name isolated, comma and colon outside). The test is not part of this PR.
  • Web lint, format check, build, bundle budget, and the admin-backups tests pass. In the full web suite, 31 player, request-deadline, and auth tests fail on this host. The same files fail on main here (30 failures, one flaky test apart) and don't import the changed files.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/restore-review-caveat-isolation/

Risks

None identified. Rendering only: no API, stored data, or translation keys change.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Ran as a follow-up of the #4938 review run, with one reviewer per round.

Rounds: 1, last reviewed 5e6ce62

Member Round 1
Sol (gpt-6.2-sol, high) 9/10, no findings

Visual review: 1 round, captures from 5e6ce62

Member Round 1
Sol (gpt-6.2-sol, high) better, 9/10

Answered: the one visual nit, a one-word last line in the Left out description, looks the same before and after and is outside this change.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; T3 Code delegate_task (Codex) for the visual and background reviews
  • Model(s): claude-opus-5-5 (implementation, code review); claude-sonnet-5-5 (code-review cleanup finder and validation check); gpt-6.2-sol (visual and background review)
  • Involvement: Fully AI-generated; a maintainer has not yet verified it
  • Adversarial review: a medium code review (three finders and a validation check) found no defects. It led to one cleanup: a profile caveat's label is now built from its two names in one place. No plan council ran, because the fix is mechanical. See Council review.

🤖 Generated with Claude Code

The Review step's "Left out" list prints each caveat as "<name>: <text>". In
left-to-right interfaces the formatter adds no isolates, so a right-to-left
name or one with a direction override reordered the colon and the sentence
after it. Each name is now a <bdi>, with the colon outside it; a profile's
label isolates its account and profile names separately.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e951cfe8-ae1e-48ad-84cd-86726d6bc13c
Commits

Reviewing files that changed from the base of the PR and between b0d1372 and 5e6ce62.

Files selected for processing: 2

  • web/src/pages/admin-backups/RestoreReview.tsx
  • web/src/pages/admin-backups/restoreModel.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T07:41:34.457264Z 5e6ce62 PR opened
🔒 Security Review ✅ Completed 2026-11-21T07:43:14.723939Z 5e6ce62 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have javascript Pull requests that update javascript code priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit 34384f9 into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/restore-review-caveat-isolation branch November 21, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have javascript Pull requests that update javascript code priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant