Repository navigation
fix(web): keep restore review names from reordering the text after them - #4969
Conversation
The Review step's "Left out" list prints each caveat as "<name>: <text>". In left-to-right interfaces the formatter adds no isolates, so a right-to-left name or one with a direction override reordered the colon and the sentence after it. Each name is now a <bdi>, with the colon outside it; a profile's label isolates its account and profile names separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 2 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (the backup restore flow exists only in the web admin)
On the backup restore Review step, the "Left out" list shows each caveat as
<name>: <text>. In left-to-right interfaces such as English, a right-to-left account name or one containing a direction override (U+202E) changed the reading order of the colon and the sentence after it. An account named U+202E +overrideturned the whole sentence backwards ("…ereh rotartsinimda na"), andأحمد!put its!on the colon's side. The formatter isolates message values only in right-to-left interfaces, so Arabic and Hebrew were already correct.Found while reviewing #4938, which fixed the same mechanism on the Run step's report lines.
Approach
Each name in a caveat is now a
<bdi>, in every language. Only the name is isolated, so the colon stays in the page's direction. A profile's caveat label joins two names ("account, profile"), so the caveat now carries both names and isolates each one separately. The plain joined label is still used for the tooltip. In right-to-left interfaces the pair used to take the direction of its first name. Now it follows the page, so the account name comes first in reading order.The formatter could isolate values in left-to-right interfaces too, but
docs/architecture/i18n.mdkeeps left-to-right output byte-for-byte, so the fix stays with the call site, as #4938 did for the Run step.Validation
أحمد!and U+202E +override, backed up, deleted, then restored as new so each gets the administrator caveat. Onmain, English shows the reversed sentence and the misplaced!. With the fix, each name stays inside its own isolate and the sentence reads normally. Arabic looks the same before and after. Checked at desktop and phone width.أحمد!and a profile U+202E +overridefailed onmain(names not isolated) and passed with the fix (each name isolated, comma and colon outside). The test is not part of this PR.mainhere (30 failures, one flaky test apart) and don't import the changed files.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/restore-review-caveat-isolation/
Risks
None identified. Rendering only: no API, stored data, or translation keys change.
Checklist
Council review
Ran as a follow-up of the #4938 review run, with one reviewer per round.
Rounds: 1, last reviewed 5e6ce62
Visual review: 1 round, captures from 5e6ce62
Answered: the one visual nit, a one-word last line in the Left out description, looks the same before and after and is outside this change.
AI Disclosure
🤖 Generated with Claude Code