Skip to content

fix(web): wrap a page title's long word instead of cutting it off - #4974

Merged
Quick104 merged 1 commit into
mainfrom
fix/page-header-long-word-wrap
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/page-header-long-word-wrap

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (web layout fix; the Apple, Android and Roku apps lay out their own titles)

A page title with one word wider than its column was cut off at the right edge. On a narrow phone with a large browser font, the German backup restore title "Sicherung vom wiederherstellen" showed as "…wiederherstell": at 300 px with a 24 px browser font, the word is 322 px wide in a 252 px column, and the app shell clips the overflow. The Settings → Signed-in sessions title did the same in Danish ("Loginsessioner"). It also pushed its description past the column.

Now a word that can't fit on a line by itself breaks at the column edge and continues on the next line. Titles whose words fit wrap exactly as before.

Approach

The title in the shared admin and settings page header (PageHeader) gets break-words (overflow-wrap: break-word), which breaks a word only when it can't fit on a line by itself. Two titles copy the header's classes instead of using the component, and they get the same rule:

  • the plugin detail title, since plugin names come from manifests and can be one long word. Its column's 220 px minimum is also capped at the available width, so on a very narrow window it can't stay wider than the page;
  • the Settings → Signed-in sessions title. Its column also gets min-w-0, because as a flex item it otherwise grew to the word's width instead of letting the word wrap.

The user detail header already wraps long words, and I left it unchanged. I kept the change to these class strings and didn't move the copies into a shared constant. That cleanup isn't needed for the fix.

A break at the column edge can leave a short tail: at 360 px the German title ends "wiederherstelle / n", because the word is a few pixels too wide for the line. I tried automatic hyphenation (hyphens: auto) to get "wiederher- / stellen", but with balanced titles it also hyphenated words that fit on their own line, such as Polish "Zaplano- / wane zadania" where main shows "Zaplanowane / zadania". The change leaves it out, so only a word that would otherwise be cut off ever breaks.

This doesn't overlap the Text Size work in #4861 and #4874. #4861 changes a font size two lines below the plugin title and leaves the title line alone. Neither PR touches title wrapping.

Validation

  • Live, on a Silo dev deployment built from main (980e455), then on one built from this branch (Chromium). I tested the backup restore page in German and English, Signed-in sessions in Danish, a plugin page in German, and Autoscan Activity and Scheduled tasks in Polish. Sizes were 300 and 360 px with a 24 px browser font, then 390, 820 and 1440 px at the default font, plus the plugin page at 230 px. Before, the German restore title measured 322 px wide in a 252 px box at 300 px, and 322 in 312 at 360 px, and the Danish Sessions title grew to 287 px in a 300 px window. After, all three fit their box. The plugin title's column measures 182 px at 230 px, where it used to stay 220 px wide and run past the window. Every other title measures the same as before, the Polish titles wrap between words as on main, and the console shows no errors.
  • Web tests for the components that render these titles, typecheck, ESLint and Prettier: pass.
  • No test added. The change is CSS class names, and the before and after measurements above are the proof.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/page-title-long-word-wrap/

Risks

None identified. overflow-wrap: break-word changes nothing for a title whose words fit their line, and the plugin column's minimum changes only when the window is narrower than about 270 px.

Follow-ups

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

This ran as a follow-up of the #4938 review, so each round has one member instead of the council.

Background review: 2 rounds, last reviewed 706cf63

Member Round 1 (febee43) Round 2 (706cf63)
Sol (gpt-6.2-sol, high) 8/10 8/10

Fixed in round 1: hyphenation split a Polish word that fits whole ("Aktywno- / ść"), and the plugin title's 220 px column minimum clipped on a 230 px window (now capped at the available width). Fixed after round 2: hyphenation still split fitting words ("Zaplano- / wane zadania"), so b089c51 removes it. Round 2's review couldn't be posted (the GitHub connector returned an authorization error), so its one finding is recorded here. b089c51 only removes classes that round 2 reviewed, so that round's findings still hold for this head.

Visual review: 2 rounds, captures from febee43; the after set was recaptured on b089c51

Member Round 1 Round 2
Sol (gpt-6.2-sol, high) better, 8/10 better, 9/10

Round 1 found the "wiederherstelle / n" tail at 360 px; round 2 reviewed the hyphenated version that fixed it. The background review then showed hyphenation splitting words that fit, so the final head goes back to round 1's rendering for the wide-word case, and I accepted the short tail as the lesser cost. Its captures are back to round 1's layout, measured line for line.

AI Disclosure

  • Harness: Claude Code, launched from T3 Code
  • Tool(s): Claude Code, T3 Code, Codex (review member), headless Chromium for captures
  • Model(s): claude-opus-5-5 (implementation, plan check, code-review finders), claude-sonnet-5-5 (code-review finder and validation check), gpt-6.2-sol (visual and background review)
  • Involvement: Fully AI-generated; the agent verified it on a sandbox, and no person has reviewed it yet
  • Adversarial review: One Opus plan check at medium effort, then code-review at medium. The plan check cut a shared class constant from the plan; code-review found no defects in the diff. Its candidates outside the diff are a constant to share the title classes, which I skipped, and other title styles without wrapping, which are separate. A simplify pass changed nothing. See Council review for the visual and background reviews.

🤖 Generated with Claude Code

A page title with one word wider than its column (German
"wiederherstellen" on a narrow phone with a large browser font) ran
past the column and the app shell clipped its end. The shared page
header, the plugin page header and the Settings sessions title now
hyphenate such a word in the interface language, and break it anywhere
when the browser has no hyphenation dictionary for that language. The
sessions title's column also gets min-w-0 so it can shrink to the row
instead of pushing past it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b396af86-69b6-4a98-9a2a-4c62c77bfee6
Commits

Reviewing files that changed from the base of the PR and between 34384f9 and febee43.

Files selected for processing: 3

  • web/src/components/page/PageHeader.tsx
  • web/src/components/sessions/LoginSessionsPanel.tsx
  • web/src/pages/AdminPluginDetail.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T07:59:51.711309Z febee43 PR opened
🔒 Security Review ✅ Completed 2026-11-21T08:01:35.799690Z febee43 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed febee43)

AI disclosure: written by gpt-6.2-sol (Codex) as an automated adversarial review.

Comment thread web/src/components/page/PageHeader.tsx Resolved
Comment thread web/src/pages/AdminPluginDetail.tsx Resolved
@Quick104
Quick104 merged commit e6bef22 into main Nov 21, 2026
22 checks passed
@Quick104
Quick104 deleted the fix/page-header-long-word-wrap branch November 21, 2026 08:12
@Quick104

Copy link
Copy Markdown
Contributor Author

This PR merged at febee43. The description above was edited after the merge and describes later commits that never landed. What's on main: break-words hyphens-auto on the three titles and min-w-0 on the Sessions title's column, without the hyphenation limit or the plugin column cap. With balanced titles, that hyphenation also splits Polish words that fit ("Zaplanowa- / ne zadania", "Aktywno- / ść Autoscan"). #5031 removes the hyphenation and caps the plugin column.

Quick104 added a commit that referenced this pull request Nov 21, 2026
…lugin title on narrow screens (#5031)

Page titles got automatic hyphenation in #4974. With balanced titles it
also split words that fit on their own line: Polish "Zaplanowa- / ne
zadania" on Scheduled tasks and "Aktywno- / ść Autoscan" on Autoscan
Activity, which wrapped between words before. Titles now break inside a
word only when that word can't fit on a line by itself.

The plugin title's column kept a fixed 220 px minimum, so on a window
narrower than about 270 px a long plugin name still ran past the page
edge. The minimum is now capped at the available width.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant