Repository navigation
fix(web): keep the restore report's buttons inside the page on narrow screens - #4989
Merged
Merged
Conversation
… screens
Long button labels on the restore Run step's report ("Download report",
"Choose again") now wrap inside the button instead of running past the
right edge with a narrow screen and a large browser font.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (no client-visible change; backup restore is a web admin page with no Apple, Android, or Roku counterpart)
On a backup restore's Run step, the report ends with "Download report" and "Choose again". On a narrow screen with a large browser font, a translated label can be wider than the page, and the button doesn't wrap it. In German at 300 px with a 24 px font, "Bericht herunterladen" ran 40 px past the right edge and was cut off.
This change lets both buttons wrap a label that doesn't fit onto more lines inside the button. At normal sizes they look as before.
Approach
The two buttons get a local class set that allows wrapping, caps the width at the row, and lets the height grow, keeping the usual 36 px minimum. It's the same set
AdminTaskDetail's conflict actions use, and it follows how the restore refusal button (#4798) and other panels fixed this without changing the sharedButton. OnlyRestoreRun.tsxchanges, and it doesn't touch the report lines #4938 edits.Validation
main(34384f96): with a German interface at 300 px and a 150% root font, the "Bericht herunterladen" button spans x=24 to 316 while its row ends at x=276.admin-backupsweb tests (33) pass. ESLint, Prettier, andmake lint-changedpass.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/pr-4989/
Risks
None identified. Only these two buttons change, and only when the label doesn't fit on one line.
Checklist
Council review
This ran as a follow-up of #4938's visual review, with one reviewer per round.
Background review: 1 round, reviewed 6913155
Visual review: 1 round on captures from
34384f96plus the fix (the same change as the head)Answered: the 36 px button height and the faint outline border are the shared outline Button's styling everywhere in the app, unchanged here.
AI Disclosure
AdminTaskDetail's, which keeps the house pattern of a file-local constant. The plan round was skipped because the fix is mechanical. See Council review for the visual and background reviews.🤖 Generated with Claude Code
Note
Fix restore report buttons overflowing on narrow screens
Adds a shared class string (
RUN_ACTION) for the restore-report action buttons in RestoreRun.tsx. It caps button width at 100%, allows labels to wrap with balanced breaks, and sets a minimum height. Applies to the Download report and Choose again buttons.Macroscope summarized 6913155.