Skip to content

fix(web): keep the restore report's buttons inside the page on narrow screens - #4989

Merged
Quick104 merged 1 commit into
mainfrom
fix/restore-run-buttons-narrow
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/restore-run-buttons-narrow

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (no client-visible change; backup restore is a web admin page with no Apple, Android, or Roku counterpart)

On a backup restore's Run step, the report ends with "Download report" and "Choose again". On a narrow screen with a large browser font, a translated label can be wider than the page, and the button doesn't wrap it. In German at 300 px with a 24 px font, "Bericht herunterladen" ran 40 px past the right edge and was cut off.

This change lets both buttons wrap a label that doesn't fit onto more lines inside the button. At normal sizes they look as before.

Approach

The two buttons get a local class set that allows wrapping, caps the width at the row, and lets the height grow, keeping the usual 36 px minimum. It's the same set AdminTaskDetail's conflict actions use, and it follows how the restore refusal button (#4798) and other panels fixed this without changing the shared Button. Only RestoreRun.tsx changes, and it doesn't touch the report lines #4938 edits.

Validation

  • Reproduced on a dev sandbox built from main (34384f96): with a German interface at 300 px and a 150% root font, the "Bericht herunterladen" button spans x=24 to 316 while its row ends at x=276.
  • After the fix, on the same sandbox, database, and restore job: the button spans x=24 to 276 and wraps onto two lines. English at the same size, the German phone width (390 px), and English desktop (1280 px) measure exactly as before. The keyboard focus ring surrounds the wrapped button. No console errors.
  • The admin-backups web tests (33) pass. ESLint, Prettier, and make lint-changed pass.
  • No new test: this is CSS layout, which jsdom can't measure.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/pr-4989/

Risks

None identified. Only these two buttons change, and only when the label doesn't fit on one line.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

This ran as a follow-up of #4938's visual review, with one reviewer per round.

Background review: 1 round, reviewed 6913155

Member Round 1
Sol (gpt-6.2-sol, high) 9/10, no findings

Visual review: 1 round on captures from 34384f96 plus the fix (the same change as the head)

Member Round 1
Sol (gpt-6.2-sol, high) better, 8.5/10

Answered: the 36 px button height and the faint outline border are the shared outline Button's styling everywhere in the app, unchanged here.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code, T3 Code delegated tasks (Codex), headless Chromium captures
  • Model(s): claude-opus-5-5 (implementation and code review); claude-sonnet-5-5 (code-review cleanup finder and validation check); gpt-6.2-sol (visual and background review)
  • Involvement: Fully AI-generated. The agent verified it live on a dev deployment; a person has not verified it yet.
  • Adversarial review: a multi-agent code review at medium effort found no defects. It noted that the class set duplicates AdminTaskDetail's, which keeps the house pattern of a file-local constant. The plan round was skipped because the fix is mechanical. See Council review for the visual and background reviews.

🤖 Generated with Claude Code

Note

Fix restore report buttons overflowing on narrow screens

Adds a shared class string (RUN_ACTION) for the restore-report action buttons in RestoreRun.tsx. It caps button width at 100%, allows labels to wrap with balanced breaks, and sets a minimum height. Applies to the Download report and Choose again buttons.

Macroscope summarized 6913155.

… screens

Long button labels on the restore Run step's report ("Download report",
"Choose again") now wrap inside the button instead of running past the
right edge with a narrow screen and a large browser font.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T08:53:50.187299Z 6913155 PR opened
🔒 Security Review ✅ Completed 2026-11-21T08:55:08.614017Z 6913155 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The restore report download and choose-again buttons now use shared styles that limit their width and allow long labels to wrap.

Changes: Restore report actions

Layer / File(s) Summary
Shared restore action styles
web/src/pages/admin-backups/RestoreRun.tsx
A shared class constrains button width and allows long labels to wrap. The download-report and choose-again buttons now use it.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related issues

  • Issue 4927 reports button labels being cut off when a browser minimum font size is set. This change applies wrapping and width styles to two restore-run buttons, but does not change the shared Button component.
Merge Risk: Minimal · up to 69131

This change lets the restore report buttons wrap long labels on narrow screens. No actionable merge risk was found, and the change is easy to revert.

Security architecture risk: Minimal · up to 69131

The change adjusts button layout without changing restore behavior, permissions, report downloads, or action callbacks. No introduced or worsened architecture-level security risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the fix and its scope: keeping the restore report's buttons inside the page on narrow screens. The raw summary and objectives confirm the change adds wrapping and width limits to the D…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is specific to the changeset. It states that the Run step's Download report and Choose again buttons in the backup restore page overflow on narrow screens with large fonts. It names th…
Full details: Title check

Explanation

The title names the fix and its scope: keeping the restore report's buttons inside the page on narrow screens. The raw summary and objectives confirm the change adds wrapping and width limits to the Download report and Choose again buttons in RestoreRun.tsx. The title is specific and matches the main change.

Full details: Description check

Explanation

The description is specific to the changeset. It states that the Run step's Download report and Choose again buttons in the backup restore page overflow on narrow screens with large fonts. It names the file the change touches (RestoreRun.tsx), the approach (local class set allowing wrapping, width capped at the row, minimum height kept at 36 px), and the validation performed. It is not generic or off-topic, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 58c37d6d-7b05-4763-a9e9-80c85f60cd9e
Commits

Reviewing files that changed from the base of the PR and between ea131fa and 6913155.

Files selected for processing: 1

  • web/src/pages/admin-backups/RestoreRun.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

@Quick104
Quick104 merged commit 8b85d1b into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/restore-run-buttons-narrow branch November 21, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant