Skip to content

fix(web): keep restore names that can't wrap inside their box - #4921

Merged
Quick104 merged 2 commits into
mainfrom
fix/restore-unbreakable-name-overflow
Nov 21, 2026
Merged

Quick104 merged 2 commits into
mainfrom
fix/restore-unbreakable-name-overflow

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (backup restore is only in the web admin)

On the backup restore screens, a library, collection, or account name that holds a run no line break can split, such as many emoji joined by zero-width joiners, ran past its box and was cut off at the screen edge. On a phone, choosing such an item made it worse: the Choose step's summary panel widened the page's only column from 328 to 560 px on a 360 px screen, so every section ran past the edge and the Users section's "All" checkbox could no longer be reached. This change clips such a run at the edge of its box on each of those surfaces and keeps the summary panel from widening the page. Every other name renders as before.

The affected places:

  • Choose step: the library heading above a section's rows, and the "Silo will" summary panel. The panel lists the same plan sentences as the Review step but didn't wrap them at all, so a long name with no spaces also widened the column on a phone, and on a desktop was cut off mid-word inside the panel's scroll area.
  • Review step: the plan sentences and the "Left out" list.
  • Run report: each item's line and each profile's line.

Server-side, usernames are only trimmed and capped at 255 characters, and collection titles and library names accept the same run, so real data can produce these names. #4755 fixed this for the Choose step's profile rows, and #4849 fixes the Choose step's item and account rows.

Approach

Each surface uses the classes #4755 settled for this: overflow-x-clip with 0.25em of padding offset by a negative margin. That clips sideways only, so tall marks above and below a line stay visible, and letters whose ink reaches past their edge stay whole. The clip goes on the box that already sets the line width, so the words around the run still wrap and only the run is cut:

  • the heading's text span (with min-w-0, and max-w-full on its button so the button can't grow past the row);
  • each plan list, on its end side only, since its start padding holds the bullets that clipping an item would cut off. The Review step and the summary panel now share one PlanSentences list;
  • the "Left out" list;
  • the Run report row's text column, which covers the item line and the account's profile lines.

The summary panel gets min-w-0. On a phone it shares the sections' grid column, and without it the panel's widest sentence set the column's width. Names that are clipped get a title on the name element with the full name. The plan sentences don't, since the name sits inside a translated sentence and a tooltip on every sentence would only repeat it.

Web only, in RestoreChoose.tsx, RestoreReview.tsx, and RestoreRun.tsx. No API, text, or translation changes.

Validation

  • Reproduced on a Silo dev deployment built from main: library 1 renamed to 21 "👩" joined by zero-width joiners, collections and accounts with that run in their names, a backup, then a restore. At 360 px the heading's run painted 16 px past its section, the column grew to 560 px after choosing, the Review sentences ran 54 px past the page, and the Run report's item and profile lines ran 53 to 62 px past it.
  • Rebuilt from this branch, same data, same restore job: every one of those lines now stops inside the screen, the column stays 328 px, and the long no-space name wraps in the summary panel. At 1024 px the Review and Run report measurements match main exactly, and the summary panel, which on main cut the long name off mid-word and hid the rest behind a sideways scroll, now wraps it in full. In Arabic the Run report clips at the line's end (left) edge, inside the screen.
  • A fixture rendered each changed surface with the app's built CSS and fonts, with main's classes and with this change's, for 14 names in Latin, Telugu, Devanagari, Arabic, Thai, Vietnamese, combining marks, a long spaced name, a long name with no spaces, and the emoji run, at 300, 360, and 900 px, default and x-large text, 1x and 2x, left to right and right to left. Every name other than the emoji run renders pixel-identical to main, except that the long no-space name now wraps in the summary panel at phone widths. The "Left out" list is checked there only, because the sandbox data gives these items no caveat.
  • Lint, format, build, bundle budget, local paths, size ratchet, bidi, and case collisions: pass. Web tests: failures only in seven files that share no code with this change. Four fail the same way with main's version of the changed files, and the other three passed when rerun.
  • No browser console errors on either build. No passed case on the v1.0 validation board reaches the restore screens.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/restore-unbreakable-name-overflow/

Risks

The last glyph of a clipped run can be cut mid-glyph at the box's edge; an ellipsis can't go inside one grapheme. The Run report clips its whole text column, so the end of an unbreakable run inside a server message or a title list is clipped there too; on a phone that text already ran off the screen.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Follow-ups

Two pre-existing defects that main shows the same way, each fixed in its own pull request:

  • The omitted-accounts warning's name sample (BackupWarningDetails.tsx, on the Choose step and the Backups page) has the same overflow.
  • In Arabic, a Run report item whose name is an emoji run wider than the line starts on the second line, leaving the first line empty beside the icon. The isolation marks the translator adds around the name leave a break point before the emoji.

Council review

Plan round: skipped as a mechanical fix. The source shows each box that overflows, and the change applies the classes #4755 settled at those boxes.

Background review: 1 round, on 78eb2e8, finished after merge

Member Round 1
Sol (gpt-6.2-sol, xhigh) 9/10
Opus (claude-opus-5-5, high) 8/10
Gemini (gemini-4-neon, xhigh) unavailable (provider quota)

Open: Sol's S1, a keyboard- and touch-accessible way to read a clipped name in the plan, is a design decision for the maintainer. A follow-up fix makes these clips apply only while a name overflows, after Firefox was found to clip overflow-x: clip vertically too.

Visual review: 1 round, on captures taken before this branch merged main. Main's pinned summary panel changed the desktop before; the desktop after looks the same.

Member Round 1
Sol better, 8/10
Opus better, 7/10
Gemini better, 6/10

Answered: all three noted that a clipped run ends 3 to 4 px past the dividers. That is the 0.25em of room #4755 keeps for letters whose ink reaches past their edge, so it stays. Gemini read two of those runs as reaching the screen edge; the measurements put them 12 px inside it. The empty first line in the Arabic report (Sol, Gemini) shows the same way on main and is a follow-up. A lone "items." at the end of some sentences also shows on main.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code, T3 Code delegated tasks, Codex, Antigravity
  • Model(s): claude-opus-5-5 (implementation and code review), gpt-6.2-sol, claude-opus-5-5, gemini-4-neon (visual and adversarial review), claude-sonnet-5-5 (code-review subagents)
  • Involvement: Fully AI-generated. The agent verified it on a dev sandbox and in a browser fixture; a person has not verified it yet.
  • Adversarial review: code review at high (three finders and a validation check) removed the tooltip from plan sentences and fixed a comment. A simplify pass merged the two plan lists into one component. The plan round, visual review, and background review are under Council review.

🤖 Generated with Claude Code

Note

Fix restore wizard text overflow by clipping unbreakable names within their rows

  • Long restore names that cannot wrap (library names, plan sentences, report labels) previously overflowed their boxes sideways. The Choose, Review, and Run steps now clip overflowing text horizontally with inline padding and a negative margin.
  • Adds a shared PlanSentences component in RestoreReview.tsx, used by both the Choose summary and Review plan lists.
  • Full library names, caveat labels, and report item labels are exposed via title attributes so clipped content stays reachable.

Macroscope summarized 78eb2e8.

Quick104 and others added 2 commits November 20, 2026 23:19
A name holding a run no line break can split, such as emoji joined by
zero-width joiners, ran past its box on the backup restore screens: the
Choose step's library heading and its summary panel, the Review step's
plan sentences and left-out list, and the Run report's item and profile
lines. In the summary panel the sentence also set the width of the
phone layout's only column, so every section ran past the screen.

Each of these now clips such a run sideways at its edge, as the profile
rows do since #4755. The summary panel no longer widens the column, and
its sentences wrap like the Review step's. Every other name renders as
before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le-name-overflow

# Conflicts:
#	web/src/pages/admin-backups/RestoreChoose.tsx
@silo-triage silo-triage Bot added the size/M 50–199 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 546bfff7-5e0c-45f0-8079-ee9dcacc0a05
Commits

Reviewing files that changed from the base of the PR and between 5d52158 and 78eb2e8.

Files selected for processing: 3

  • web/src/pages/admin-backups/RestoreChoose.tsx
  • web/src/pages/admin-backups/RestoreReview.tsx
  • web/src/pages/admin-backups/RestoreRun.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T05:25:58.772242Z 78eb2e8 PR opened
🔒 Security Review ✅ Completed 2026-11-21T05:28:53.336684Z 78eb2e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment on lines +60 to +65
"-me-[0.25em] list-disc space-y-1.5 overflow-x-clip ps-5 pe-[0.25em] text-sm wrap-anywhere",
className,
)}
>
{sentences.map((sentence, position) => (
<li key={position}>{t("web.admin.backups.restore.plan.sentence", { sentence })}</li>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug medium

Clipped plan names cannot be inspected in the summary or review

Users cannot distinguish selected plans with the same visible prefix when their names are clipped. Provide an accessible way to reveal the full sentence on Choose and Review.

Prompt for LLM
File web/src/pages/admin-backups/RestoreReview.tsx, lines 60-65:

Clipped plan names cannot be inspected in the summary or review

Clipping the plan sentence without exposing the original text prevents users from identifying the full selected name on both Choose and Review, including when two names share the same visible prefix. Provide an accessible way to reveal the complete sentence or name without relying on the clipped text.

Suggested code:

<li key={position} title={sentence}>{t("web.admin.backups.restore.plan.sentence", { sentence })}</li>

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

sideways at the row's edge, in the item's line and in its profiles' lines; the words
around it still wrap. The 0.25em of padding, offset by a negative margin, keeps
letters whole whose ink reaches past their edge. */}
<div className="-mx-[0.25em] min-w-0 flex-1 overflow-x-clip px-[0.25em]">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug medium

Report row clipping hides portions of restore diagnostics

Users can lose diagnostic details in unbreakable text from item.error, item.message, notes, and profile diagnostics. Restrict clipping to name-bearing lines or provide a way to inspect the full text.

Prompt for LLM
File web/src/pages/admin-backups/RestoreRun.tsx, line 99:

Report row clipping hides portions of restore diagnostics

The new clipping container also truncates unbreakable runs in `item.error`, `item.message`, notes, and profile diagnostics, none of which have a title or other full-text view. Restrict clipping to the name-bearing lines or provide a way to inspect the complete diagnostic text.

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

@silo-triage silo-triage Bot added bug Something isn't working impact: usability Core flow broken or severely blocked javascript Pull requests that update javascript code priority: P2 Limited scope, workaround exists, or polish triaged High-confidence review completed; does not mean fixed, validated, or accepted for release. labels Nov 21, 2026
@Quick104
Quick104 merged commit 594b74c into main Nov 21, 2026
23 checks passed
@Quick104
Quick104 deleted the fix/restore-unbreakable-name-overflow branch November 21, 2026 05:44
Quick104 added a commit that referenced this pull request Nov 21, 2026
…estore-choose-your-data

main's #4921 moved the Choose summary's plan list to the shared
PlanSentences, which already wraps long names, so this branch's change
to that list is dropped. The notice and the Your data note keep
wrap-anywhere.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed 78eb2e8)

I used Codex in T3 Code with gpt-6.2-sol for the review and browser fixture checks.

return (
<ul
className={cn(
"-me-[0.25em] list-disc space-y-1.5 overflow-x-clip ps-5 pe-[0.25em] text-sm wrap-anywhere",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S1 (P3) — Keep clipped names distinguishable in the restore plan

At a 1024 px viewport with default Text Size, two library names made from 41 joined emoji that differ only in the last emoji render identically in both Choose and Review. In a Chromium fixture using the app CSS, main’s Choose summary could scroll 474 px sideways to reveal the difference. With this change it has zero horizontal scroll, and neither plan displays the differing character. An admin can no longer tell those entries apart by reading the plan before restoring.

Keep the list inside its column and offer a keyboard- and touch-accessible way to read the full name when a line clips. Limit that reveal to clipped names so ordinary sentences don’t gain tooltips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: usability Core flow broken or severely blocked javascript Pull requests that update javascript code priority: P2 Limited scope, workaround exists, or polish size/M 50–199 added + deleted lines (all files); change volume, not priority. triaged High-confidence review completed; does not mean fixed, validated, or accepted for release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant