Skip to content

fix(web): clip a name that can't wrap in the restore Choose notice - #4982

Merged
Quick104 merged 1 commit into
mainfrom
fix/restore-choose-notice-clip-unbreakable-names
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/restore-choose-notice-clip-unbreakable-names

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (web admin restore page, no client counterpart)

On the backup restore Choose step, the amber notice above Review ("Also chose the account “…”") scrolls sideways when a name holds a run that no line break can split, such as emoji joined by zero-width joiners. On desktop the rest of the run hides behind a horizontal scroll: a sideways trackpad swipe or find-in-page moves the notice until only the emoji show. Below the lg breakpoint the run spills past the summary panel to the screen edge. Every other name on the restore screens already clips this case (#4921, #4849, #4755). This change makes the notice clip it too.

The notice sets lg:overflow-y-auto so it can scroll vertically within its 8rem cap. That makes overflow-x compute to auto as well. wrap-anywhere (#4875) wraps names that can break, but can't split one grapheme cluster, so the run overflows sideways.

Found in review of #4875.

Approach

The sideways clip goes on the notice's existing inner block, with 0.25em of room on each side, offset by a negative margin, so glyphs at the edge stay whole. The notice gets the same 0.25em of padding, so the inner block's box sits inside it and the notice has no horizontal overflow left to scroll. The text keeps the same position and wrap width, and the notice still scrolls vertically, takes keyboard focus when it does, and shows its focus outline.

Putting overflow-x-clip on the notice itself, as PlanSentences does, doesn't work here. Next to overflow-y: auto, clip computes to hidden, which script and find-in-page can still scroll.

Validation

  • Live, on a Silo dev deployment: a deleted account named with 40 😀 joined by zero-width joiners, chosen through its profile. Before, at 1440 px the notice held 640 px of content in a 278 px box and a scripted scroll moved it 362 px; at 390 px the run ran past the summary panel. After, the content fits the box at 1440 and 390 px, and neither a script nor a sideways wheel moves it. The notice still scrolls vertically and takes keyboard focus. An account named with 18 family emoji behaves the same way.
  • Fixture page with the notice's styles at main and with this change, scrolled sideways with a 400 px wheel: main moves 360 px in Chromium 153, 400 px in WebKit 26.6, and 265 px in Firefox 155; this change doesn't move in any of them.
  • Web lint, format check, build with typecheck, and bundle budget pass.
  • Web unit tests: 3098 pass. 33 fail only on the validating host's Node 26, whose built-in localStorage shadows jsdom's. 32 of them pass on Node 24. The last, a 5 s timeout in AdminCollections.select.test.tsx, fails and passes on main too under the same load. No test file imports the restore page.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/restore-choose-notice-clip/

Risks

None identified. The change is two class lists on one element and its child.

Open #4861 changes this notice's font-size class on the same line, so one of the two will need a one-line rebase.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Follow-up run: one member per round. No plan round: the fix is mechanical.

Rounds: 1, last reviewed f81a360

Member Round 1
Sol (gpt-6.2-sol, high) 9/10, no findings

Visual review: 1 round, captures of f81a360 (built before a comment-only rewording)

Member Round 1
Sol better, 8/10

Answered: three nits, each the same before and after or about the test fixture: a comma that wraps after a clipped name, a truncated section label elsewhere in the panel, and the fixture's quote mark.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code and its review subagents; T3 Code delegated tasks (Codex) for the visual and adversarial reviews; Playwright (Chromium, WebKit, Firefox) for captures and measurements
  • Model(s): claude-opus-5-5 (implementation and code review), claude-sonnet-5-5 (code-review cleanup finder and validation check), gpt-6.2-sol (visual and adversarial review)
  • Involvement: Fully AI-generated. The agent verified it live on a dev deployment; a person has not verified it yet.
  • Adversarial review: code review at medium found no defects; it shortened one comment and suggested a shared clip constant for the restore screens, left for a separate change; the plan round was skipped because the fix is mechanical; the simplify pass changed nothing. See Council review above.

🤖 Generated with Claude Code

Note

Fix restore Choose notice clipping for unwrappable names

The restore notice in RestoreChoose.tsx could overflow horizontally when a name cannot wrap. The notice paragraph now uses horizontal padding with a matching negative margin, and the text span clips horizontal overflow while keeping edge glyph space. Vertical scrolling behavior is unchanged.

Macroscope summarized f81a360.

A name holding a run no line break can split, such as emoji joined by
zero-width joiners, scrolled the restore Choose step's "Also chose ..."
notice sideways at lg and wider, and spilled past the summary panel
below lg. The notice scrolls vertically, so a sideways clip on it would
compute to hidden and still scroll by script and find-in-page. Clip on
its inner block instead, with 0.25em of ink room that the notice's
matching padding holds, so it has nothing to scroll sideways.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 428423df-cb19-461e-a2d8-82a91cae7a66
Commits

Reviewing files that changed from the base of the PR and between 8d253ad and f81a360.

Files selected for processing: 1

  • web/src/pages/admin-backups/RestoreChoose.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T08:31:57.272699Z f81a360 PR opened
🔒 Security Review ✅ Completed 2026-11-21T08:34:36.039269Z f81a360 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit e62100f into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/restore-choose-notice-clip-unbreakable-names branch November 21, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant