Repository navigation
fix(web): clip a name that can't wrap in the restore Choose notice - #4982
Conversation
A name holding a run no line break can split, such as emoji joined by zero-width joiners, scrolled the restore Choose step's "Also chose ..." notice sideways at lg and wider, and spilled past the summary panel below lg. The notice scrolls vertically, so a sideways clip on it would compute to hidden and still scroll by script and find-in-page. Clip on its inner block instead, with 0.25em of ink room that the notice's matching padding holds, so it has nothing to scroll sideways. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 12 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (web admin restore page, no client counterpart)
On the backup restore Choose step, the amber notice above Review ("Also chose the account “…”") scrolls sideways when a name holds a run that no line break can split, such as emoji joined by zero-width joiners. On desktop the rest of the run hides behind a horizontal scroll: a sideways trackpad swipe or find-in-page moves the notice until only the emoji show. Below the
lgbreakpoint the run spills past the summary panel to the screen edge. Every other name on the restore screens already clips this case (#4921, #4849, #4755). This change makes the notice clip it too.The notice sets
lg:overflow-y-autoso it can scroll vertically within its 8rem cap. That makesoverflow-xcompute toautoas well.wrap-anywhere(#4875) wraps names that can break, but can't split one grapheme cluster, so the run overflows sideways.Found in review of #4875.
Approach
The sideways clip goes on the notice's existing inner block, with 0.25em of room on each side, offset by a negative margin, so glyphs at the edge stay whole. The notice gets the same 0.25em of padding, so the inner block's box sits inside it and the notice has no horizontal overflow left to scroll. The text keeps the same position and wrap width, and the notice still scrolls vertically, takes keyboard focus when it does, and shows its focus outline.
Putting
overflow-x-clipon the notice itself, asPlanSentencesdoes, doesn't work here. Next tooverflow-y: auto,clipcomputes tohidden, which script and find-in-page can still scroll.Validation
localStorageshadows jsdom's. 32 of them pass on Node 24. The last, a 5 s timeout inAdminCollections.select.test.tsx, fails and passes on main too under the same load. No test file imports the restore page.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/restore-choose-notice-clip/
Risks
None identified. The change is two class lists on one element and its child.
Open #4861 changes this notice's font-size class on the same line, so one of the two will need a one-line rebase.
Checklist
Council review
Follow-up run: one member per round. No plan round: the fix is mechanical.
Rounds: 1, last reviewed f81a360
Visual review: 1 round, captures of f81a360 (built before a comment-only rewording)
Answered: three nits, each the same before and after or about the test fixture: a comma that wraps after a clipped name, a truncated section label elsewhere in the panel, and the fixture's quote mark.
AI Disclosure
🤖 Generated with Claude Code
Note
Fix restore Choose notice clipping for unwrappable names
The restore notice in RestoreChoose.tsx could overflow horizontally when a name cannot wrap. The notice paragraph now uses horizontal padding with a matching negative margin, and the text span clips horizontal overflow while keeping edge glyph space. Vertical scrolling behavior is unchanged.
Macroscope summarized f81a360.