Skip to content

fix(web): wrap long names in the restore Choose notice and Your data import notes - #4875

Merged
Quick104 merged 3 commits into
mainfrom
fix/wrap-long-names-restore-choose-your-data
Nov 21, 2026
Merged

Quick104 merged 3 commits into
mainfrom
fix/wrap-long-names-restore-choose-your-data

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (backup restore and the profile data import exist only in the web app; the Apple, Android, and Roku apps don't call those endpoints)

A name with no spaces runs past its box in two web screens. On the backup restore Choose step, choosing a profile whose account isn't chosen yet shows "Also chose the account , which is needed by what you chose." in the summary panel. On desktop a long username is cut off at the panel's edge, behind a sideways scroll in the notice; on a phone it runs past the panel and off the screen. On Settings → Your data, the import summary's notes can name a collection ("2 of this profile's collections are named …"), and a long name runs past the box on a phone.

This change lets those names break at any character, as the Review and Run steps (#4738) and the Choose summary's plan list (#4921) already do.

Approach

The Choose summary's notice and each import note on Your data get wrap-anywhere (overflow-wrap: anywhere). Words that fit still wrap at spaces. The plan list in the same panel already wraps through PlanSentences since #4921, which also keeps the panel from widening the phone layout.

Validation

  • Reproduced on a dev deployment with a 78-character username and a 79-character collection name, both without spaces, on main and on this branch merged with it. Before: the notice ran 282 px past its box at 1440 px (hidden behind a sideways scroll) and 244 px at 390 px (207 px past the screen); on Your data at 390 px the collection note ran 210 px past its box. After: both end inside their box at 390, 820, and 1440 px, with no sideways scroll. A run no line break can split, such as emoji joined by zero-width joiners, still overflows the notice; that predates this change and is a follow-up. Lines that already fit measure the same before and after, and the browser console shows no errors.
  • Web lint, format check, build, and bundle budget pass. Web unit tests: 34 failures in 8 files, none of which imports the changed components; seven of those files fail on main without this change too, and the eighth (PlaybackSettings.test.tsx) passes when run on its own.
  • Validation board: no passed case covers backups, restore, or profile data import.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/restore-choose-your-data-wrap/

Risks

None identified; the change adds CSS classes only. #4861 (open) changes the notice's font size class on the same line, so whichever merges second needs a one-line rebase that keeps wrap-anywhere.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Background review: 3 rounds. Round 1 reviewed this change alone; later rounds reviewed it after merges of main (#4797 rebuilt the summary panel, #4921 took over the plan list).

Member Round 1 (4c93b4e) Round 2 (d9a7005) Round 3 (38513a6)
Sol (gpt-6.2-sol, xhigh) 9/10 stopped, head replaced stopped at merge
Opus (claude-opus-5-5, high) 9/10 9/10 no score; one nit (O1)
Gemini (gemini-4-neon, xhigh) 9.5/10 unavailable (provider quota) unavailable (provider quota)

Visual review: 2 rounds; round 2 on captures retaken from 38513a6 against main 980e455

Member Round 1 (4c93b4e) Round 2 (38513a6)
Sol better, 8/10 stopped at merge
Opus better, 8/10 better, 8/10
Gemini better, 8/10 unavailable (provider quota)

Fixed: nothing in this PR. Follow-up: a name holding a run no line break can split, such as joined emoji, still scrolls sideways in the notice (Opus, round 3, O1); it measures the same without this change, and a separate fix applies #4921's clip to the notice. Answered (visual review): breaks inside a name and a short word left alone before or after it come from breaking a name with no spaces (Opus). The floating phone header over scrolled text, "deleted." alone on a line in the import summary heading, the summary's count rows, the notice divider shown only on desktop, and the amber notice's styling look the same before this change (Sol, Gemini, Opus). A restore row that shortens a name at tablet width but wraps it on a phone is the row's existing layout (Opus).

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; T3 Code delegated tasks (Codex, Claude, Antigravity) for the council reviews; Playwright (headless Chromium) for captures and measurements
  • Model(s): claude-opus-5-5 (implementation); council: gpt-6.2-sol, claude-opus-5-5, gemini-4-neon; code-review subagents: claude-opus-5-5 and claude-sonnet-5-5
  • Involvement: Fully AI-generated. The agent verified it live on a dev deployment; a person has not verified it yet.
  • Adversarial review: code-review at xhigh (three finders, a validation agent, and a verifier) found no defect in this diff; its sibling findings on the Review and Run steps are fixed by fix(web): wrap long names on the restore Review and Run steps #4738. The plan round was skipped because the fix was three class additions at the root cause (two after fix(web): keep restore names that can't wrap inside their box #4921 took over the plan list). The simplify pass changed nothing. See Council review for the visual and background reviews.

🤖 Generated with Claude Code

Note

Fix long unbroken names overflowing in restore Choose summary and Your data import notes

Adds the wrap-anywhere class to the restore notice paragraph in RestoreChoose.tsx and to each import note span in YourDataSettings.tsx. Long unbroken text, like long names, can now wrap instead of overflowing its container.

Macroscope summarized 38513a6.

… import notes

A library, account, or collection name with no spaces ran out of the
restore Choose step's summary panel, and below the lg breakpoint it
widened the whole page column past a phone screen. The same happened to
the import notes on Settings > Your data, which can name a collection.

Break those names anywhere, as the restore Review and Run steps already
do. overflow-wrap: anywhere also lowers the text's min-content width, so
the summary panel no longer sets the one-column grid's width.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c3ba0aa1-10b7-4a5a-91d0-df21473086fd
Commits

Reviewing files that changed from the base of the PR and between 980e455 and 38513a6.

Files selected for processing: 2

  • web/src/pages/admin-backups/RestoreChoose.tsx
  • web/src/pages/settings/YourDataSettings.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T06:01:56.526471Z 38513a6 New commits
🔒 Security Review ✅ Completed 2026-11-21T06:03:44.376139Z 38513a6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish triaged High-confidence review completed; does not mean fixed, validated, or accepted for release. labels Nov 21, 2026
Quick104 and others added 2 commits November 21, 2026 00:29
…estore-choose-your-data

# Conflicts:
#	web/src/pages/admin-backups/RestoreChoose.tsx
…estore-choose-your-data

main's #4921 moved the Choose summary's plan list to the shared
PlanSentences, which already wraps long names, so this branch's change
to that list is dropped. The notice and the Your data note keep
wrap-anywhere.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Quick104 Quick104 changed the title fix(web): wrap long names in the restore Choose summary and Your data import notes fix(web): wrap long names in the restore Choose notice and Your data import notes Nov 21, 2026
@Quick104
Quick104 merged commit f7c4c4f into main Nov 21, 2026
18 checks passed
@Quick104
Quick104 deleted the fix/wrap-long-names-restore-choose-your-data branch November 21, 2026 06:13

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (Claude Opus 5.5, reviewed 38513a6)

The merge dropped only the plan-list hunk; PlanSentences from #4921 covers it. Against main, the diff is exactly the two wrap-anywhere additions. On the notice, wrap-anywhere works with its current structure. Wrapping makes the text taller, not wider. useScrolls watches the block child, so a notice that now scrolls vertically gets its tabIndex, and the focus outline is unchanged. The Your data note is also fine: the server formats names there with %q, which escapes U+200D, so a name joined by zero-width joiners reaches the client as ASCII that wraps.

One nit, inline (O1): the notice is the only name on the restore screens that #4921's sideways clip doesn't reach.

Earlier rounds: no findings were posted, so there is nothing to resolve.

Review by Claude Opus 5.5 (claude-opus-5-5), run in Claude Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority. triaged High-confidence review completed; does not mean fixed, validated, or accepted for release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant