Repository navigation
fix(web): wrap long names in the restore Choose notice and Your data import notes - #4875
Conversation
… import notes A library, account, or collection name with no spaces ran out of the restore Choose step's summary panel, and below the lg breakpoint it widened the whole page column past a phone screen. The same happened to the import notes on Settings > Your data, which can name a collection. Break those names anywhere, as the restore Review and Run steps already do. overflow-wrap: anywhere also lowers the text's min-content width, so the summary panel no longer sets the one-column grid's width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 36 minutes. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
…estore-choose-your-data # Conflicts: # web/src/pages/admin-backups/RestoreChoose.tsx
…estore-choose-your-data main's #4921 moved the Choose summary's plan list to the shared PlanSentences, which already wraps long names, so this branch's change to that list is dropped. The notice and the Your data note keep wrap-anywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (Claude Opus 5.5, reviewed 38513a6)
The merge dropped only the plan-list hunk; PlanSentences from #4921 covers it. Against main, the diff is exactly the two wrap-anywhere additions. On the notice, wrap-anywhere works with its current structure. Wrapping makes the text taller, not wider. useScrolls watches the block child, so a notice that now scrolls vertically gets its tabIndex, and the focus outline is unchanged. The Your data note is also fine: the server formats names there with %q, which escapes U+200D, so a name joined by zero-width joiners reaches the client as ASCII that wraps.
One nit, inline (O1): the notice is the only name on the restore screens that #4921's sideways clip doesn't reach.
Earlier rounds: no findings were posted, so there is nothing to resolve.
Review by Claude Opus 5.5 (claude-opus-5-5), run in Claude Code.
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (backup restore and the profile data import exist only in the web app; the Apple, Android, and Roku apps don't call those endpoints)
A name with no spaces runs past its box in two web screens. On the backup restore Choose step, choosing a profile whose account isn't chosen yet shows "Also chose the account , which is needed by what you chose." in the summary panel. On desktop a long username is cut off at the panel's edge, behind a sideways scroll in the notice; on a phone it runs past the panel and off the screen. On Settings → Your data, the import summary's notes can name a collection ("2 of this profile's collections are named …"), and a long name runs past the box on a phone.
This change lets those names break at any character, as the Review and Run steps (#4738) and the Choose summary's plan list (#4921) already do.
Approach
The Choose summary's notice and each import note on Your data get
wrap-anywhere(overflow-wrap: anywhere). Words that fit still wrap at spaces. The plan list in the same panel already wraps throughPlanSentencessince #4921, which also keeps the panel from widening the phone layout.Validation
mainand on this branch merged with it. Before: the notice ran 282 px past its box at 1440 px (hidden behind a sideways scroll) and 244 px at 390 px (207 px past the screen); on Your data at 390 px the collection note ran 210 px past its box. After: both end inside their box at 390, 820, and 1440 px, with no sideways scroll. A run no line break can split, such as emoji joined by zero-width joiners, still overflows the notice; that predates this change and is a follow-up. Lines that already fit measure the same before and after, and the browser console shows no errors.mainwithout this change too, and the eighth (PlaybackSettings.test.tsx) passes when run on its own.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/restore-choose-your-data-wrap/
Risks
None identified; the change adds CSS classes only. #4861 (open) changes the notice's font size class on the same line, so whichever merges second needs a one-line rebase that keeps
wrap-anywhere.Checklist
Council review
Background review: 3 rounds. Round 1 reviewed this change alone; later rounds reviewed it after merges of
main(#4797 rebuilt the summary panel, #4921 took over the plan list).Visual review: 2 rounds; round 2 on captures retaken from 38513a6 against main 980e455
Fixed: nothing in this PR. Follow-up: a name holding a run no line break can split, such as joined emoji, still scrolls sideways in the notice (Opus, round 3, O1); it measures the same without this change, and a separate fix applies #4921's clip to the notice. Answered (visual review): breaks inside a name and a short word left alone before or after it come from breaking a name with no spaces (Opus). The floating phone header over scrolled text, "deleted." alone on a line in the import summary heading, the summary's count rows, the notice divider shown only on desktop, and the amber notice's styling look the same before this change (Sol, Gemini, Opus). A restore row that shortens a name at tablet width but wraps it on a phone is the row's existing layout (Opus).
AI Disclosure
🤖 Generated with Claude Code
Note
Fix long unbroken names overflowing in restore Choose summary and Your data import notes
Adds the
wrap-anywhereclass to the restore notice paragraph in RestoreChoose.tsx and to each import note span in YourDataSettings.tsx. Long unbroken text, like long names, can now wrap instead of overflowing its container.Macroscope summarized 38513a6.