Skip to content

fix(web): wrap long folder paths in settings and restore status lines - #4810

Merged
Quick104 merged 1 commit into
mainfrom
fix/wrap-long-setting-status-text
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/wrap-long-setting-status-text

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (web only: SettingFieldStatus is a web component, and the Apple, Android, and Roku apps have no admin settings or restore screens)

On a phone, a settings or restore status line whose text holds a long word with no place to break, such as a folder path, ran past the edge of its panel. The admin layout clips anything wider than the page, so the end of the path was cut off and couldn't be read. In Arabic it was the start of the path. The clearest case is the restore Choose step. A library whose folder this server can't open says "This server cannot open ." and then repeats the path on the next line. At 393 px both lines ran 110 to 166 px past the row. Settings pages that show a path or a long name in a status had the same problem.

Approach

SettingFieldStatus is an inline-flex box, so its text is a flex item that can't shrink below its longest word. Adding wrap-anywhere lets that text shrink and break inside a word that doesn't fit the line. break-words wouldn't help here, because it doesn't lower the flex item's minimum width. Every page that uses the status gets the fix, and the icon stays on the first line. The restore details line that repeats the missing paths is a plain paragraph and gets the same class.

Text that already fits lays out as before. A word that is wider than its line is now the only thing that breaks mid-word. I checked the call sites where a narrower minimum width could matter:

  • The backup table's status cell: on desktop the cell doesn't wrap at all, and on a phone its grid column still gets its full width.
  • Flex rows that put a status next to a button: these only differ once the status would have overflowed.

Validation

  • Reproduced on a Silo dev deployment built from main: I added a library with a long folder path, took a backup, then deleted the library and its folder. The restore plan then reported "This server cannot open ." for that library. On the restore Choose step at 393 px, the status ran 166 px past its row and the repeated path line 110 px. At 320 px they ran 239 and 183 px past. The page doesn't scroll sideways, so the end of the path was cut off.
  • Same deployment rebuilt from this branch, same data: both lines now end inside the row at 393 and 320 px, with the icon still on the first line. At 1440 px they already fit, and nothing changed. In Arabic, both lines stay inside the row at 320, 393, 834, and 1440 px.
  • Other pages that show a status: I captured Backups (a table status) and the General, Playback, Sign-in, Requests, and Downloads settings pages before and after the fix. Together they show six status lines, three of them beside their controls. At 393 px the before and after captures are byte-identical. At 1440 px the only difference is the build hash in the sidebar.
  • Web checks: lint (0 errors), format check, build, and bundle budget pass. Web unit tests: 3054 pass, and 29 fail in four files that don't import these components (request deadline, auth core, player client context, player auth refresh). The same 29 fail on main.
  • Repository checks: make lint-changed (no Go changes), and the local-path, case-collision, bidi, and size-ratchet checks pass.
  • No test added: the change is one class on two elements, and the measurements above check it.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/wrap-long-setting-status-text/

Surface and build: web admin, the restore Choose step and settings pages, at 320, 393, 834, and 1440 px, in English and Arabic. Before is main at f964c3a, and after is this branch at f4d8fe4.

Risks

None identified. overflow-wrap: anywhere is supported by every browser the web app targets.

Follow-ups

  • Fix-forward for this PR: let the ChatGPT retry rows wrap, so the warning isn't squeezed beside its button (S1), and drop the redundant classes in SubtitlesStep.tsx (O1). In progress.
  • Older overflows found in review, each fixed in its own PR: connection-check error messages with a long URL (G1), and the restore "Never restored" setting keys at 320 px (G2).
  • The restore library details still show the missing path twice: once in the server's English sentence and again in the translated line under it. [bug] Restore explanations in the expanded row and report stay in English #4669 covers the cause, since the row prefers the server's English message over the translated reason, and its fix removes the repeat.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Background adversarial review: 1 round, reviewed f4d8fe4 (finished after the merge)

Member Round 1
Sol (gpt-6.2-sol, xhigh) 7/10
Opus (claude-opus-5-5, high) 9/10
Gemini (gemini-4-neon, xhigh) 8/10

Left for a follow-up PR, since this one had merged:

  • S1: this change made an existing overflow worse in the ChatGPT retry rows in AI settings. The row can't wrap, so with a long translation on a narrow phone the warning gets squeezed beside its Retry button.
  • O1: SubtitlesStep.tsx keeps a local copy of the fix that is now redundant.

Answered:

Visual review: 2 rounds. Round 1 used captures from a dev-only page that rendered the real components. Round 2 used captures from a live dev deployment, before and after the fix.

Member Round 1 Round 2
Sol better, 8/10 better, 8.5/10
Opus better, 8/10 better, 8/10
Gemini better, 7.5/10 better, 8.5/10

Fixed: no changes needed. The captures the reviewers asked for were added: the live restore page, 320 px, Arabic at 320, 834, and 1440 px, and settings rows with statuses beside their controls. Answered:

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code, T3 Code, Codex (council review), Antigravity (council review), Playwright (captures)
  • Model(s): claude-opus-5-5 (implementation), claude-sonnet-5-5 (review finders), gpt-6.2-sol, gemini-4-neon
  • Involvement: Fully AI-generated. The agent verified it live on a dev deployment; a person has not verified it yet.
  • Adversarial review: a multi-agent code review on claude-opus-5-5 and claude-sonnet-5-5 (three finders, a validation pass, and an xhigh sweep) found no defects in the change. Its two other findings were about older code next to the change: the repeated path, which [bug] Restore explanations in the expanded row and report stay in English #4669 tracks, and a right-to-left concern that turned out not to be a problem, since the i18n formatter already isolates the path. The plan round was skipped because the fix is two class names at the root cause. A simplify pass only reworded the doc comment. See Council review for the background and visual reviews.

🤖 Generated with Claude Code

Note

Fix wrapping of long folder paths in admin settings and restore status lines

  • Adds the wrap-anywhere class to the status text in the SettingFieldStatus component so long paths can break within words instead of overflowing the line.
  • Applies the same fix to the missing-library-path paragraph in the restore backup rows in RestoreRows.tsx.
  • Updates the SettingFieldStatus docs to explain how wrap-anywhere differs from break-words for a flex item.

Macroscope summarized f4d8fe4.

A settings or restore status line whose text held a word with no break
opportunity, such as a folder path, ran past its panel on a phone, and the
admin layout's clip cut off the end of the path. The status is an inline-flex
box, so its text is a flex item that could not shrink below its longest word.

wrap-anywhere lets that text shrink and break inside a word that does not
fit, on every page that uses SettingFieldStatus. The restore details line
that repeats the missing folder paths gets the same class. Text that fits
lays out as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c35e51fc-0949-481c-90a0-6fe5b0a8956f
Commits

Reviewing files that changed from the base of the PR and between 0f28b82 and f4d8fe4.

Files selected for processing: 2

  • web/src/pages/admin-backups/RestoreRows.tsx
  • web/src/pages/admin-settings/SettingField.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:10:21.335005Z f4d8fe4 PR opened
🔒 Security Review ✅ Completed 2026-11-21T03:11:54.437162Z f4d8fe4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed f4d8fe4)

S2 (P3) · The restore Review and Result screens still clip long library names

Select a restorable library named Classic_Hollywood_Film_Noir_Restorations_and_Alternate_Cuts. The Choose row can wrap it. The Review plan (RestoreReview.tsx:56) and result heading (RestoreRun.tsx:84) both render it without a fallback break. At 320 CSS px in Chromium fixtures with the shipped layout and font, the name extended about 151 px and 165 px beyond the clipped viewport, respectively. Add wrap-anywhere to the two text containers. Both fit with that change in the same fixtures. This is a pre-existing gap in the restore flow.

AI-assisted review with Codex (gpt-6.2-sol).

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (claude-opus-5-5, reviewed f4d8fe4)

One nit, no defects. I checked each SettingFieldStatus call site under web/src: table cells, the phone backup grid, flex rows next to a Button, SettingFieldRow status slots, and the restore Choose and Users details. I found none where text that fits today would lay out differently. Tailwind is 4.2.1, which ships wrap-anywhere, and other components already use the class. The cantOpen paragraph is a block in a block column, so break-words would have fixed it too. wrap-anywhere matches the status above it and costs nothing, so I'm not asking for a change there.

O1 (nit): see the inline comment. The setup wizard's subtitle status keeps a local copy of this fix that the root class now covers.

AI disclosure: written by Claude Opus 5.5 (claude-opus-5-5).

@Quick104
Quick104 merged commit 6ddee8d into main Nov 21, 2026
23 checks passed
@Quick104
Quick104 deleted the fix/wrap-long-setting-status-text branch November 21, 2026 03:20

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gemini-4-neon, reviewed f4d8fe4)

The two diff changes hold up against CSS Text 3, Flexbox, and Grid rules and across all 75 SettingFieldStatus call sites (BackupTable desktop whitespace-nowrap, phone grid-cols-[minmax(0,1fr)_auto], flex rows with shrink-0 buttons, and RTL). Three nearby surfaces still clip unbroken strings into AdminLayout's overflow-x-clip on phones for the same reason:

G1 (Medium) — ConnectionCheckAction status text overflows its flex row

  • File: web/src/components/admin/ConnectionCheckAction.tsx:45-51
  • Trigger: Run a failing connection check on Storage, Redis, Search, Recommendations, or Plugin config at 320 px or 393 px viewport width when the server error includes an endpoint URL or hostname.
  • Impact: <span role="status"> sits inside <div className="flex flex-wrap items-center gap-3 py-3.5"> without wrap-anywhere. Its automatic minimum width stays at the longest unbroken word, so endpoint errors run past the panel and clip in AdminLayout. In headless Chromium, a 60-character quoted URL token overflows by 131 px at 320 px (288 px content width) and 58 px at 393 px (361 px content width).
  • Evidence: web/src/components/admin/ConnectionCheckAction.tsx:29-53; handlers in internal/api/handlers/admin_settings_checks.go (lines 170, 219, 321, 466, 470, 499, 503, 559) and internal/api/handlers/plugins.go:555 return raw err.Error() strings.
  • Suggested repair: Add wrap-anywhere to <span role="status"> on line 48.

G2 (Low) — Restore Choose "Never restored" key list overflows at 320 px

  • File: web/src/pages/admin-backups/RestoreChoose.tsx:354-361
  • Trigger: Open the Restore Choose step for any backup at 320 px viewport width, go to Settings, and expand "Show them" under "Never restored".
  • Impact: <p className="text-muted-foreground ps-5 pt-1 text-xs leading-relaxed"> renders raw <code className="font-mono">{key}</code> tokens without wrap-anywhere or BreakableKey. ServerSpecificSettings() always includes recommendations.policy_marked_generation (40 chars), which overflows the 268 px indented line box by ~25 px (scrollWidth: 313 vs clientWidth: 288 in Chromium) and clips on 320 px phones (and wider viewports at larger browser font sizes).
  • Evidence: web/src/pages/admin-backups/RestoreChoose.tsx:354-361, internal/backup/selective_plan.go:812, internal/backup/settings_classes.go:53. Compare web/src/pages/admin-backups/RestoreRows.tsx:137-139, which wraps setting keys in <BreakableKey> with break-words.
  • Suggested repair: Render <BreakableKey value={key} /> (exported from RestoreRows.tsx:100) inside each <code> and add wrap-anywhere to the <p> on line 354.

G3 (Low) — Restore Review caveats and refusal (and Run profile lines) lack wrapping

  • File: web/src/pages/admin-backups/RestoreReview.tsx:66-77, 86 (and web/src/pages/admin-backups/RestoreRun.tsx:146-163)
  • Trigger: Choose a Settings page with a differing built-in restart-required key such as catalog.search.meilisearch.matching_strategy (44 chars) or catalog.search.meilisearch.semantic_enabled (43 chars) and open Step 2 (Review) at 320 px; or trigger a restore refusal naming a long path or URL at 320 px or 393 px.
  • Impact: restoreModel.ts:700 interpolates raw comma-separated keys into web.admin.backups.restore.caveat.restartKeys, and RestoreReview.tsx:66-77 renders the list without wrap-anywhere or break-words (unlike Step 3 RestoreRun.tsx:94, which sets break-words on the same sentence). In Chromium at 320 px (288 px content width), catalog.search.meilisearch.matching_strategy overflows by ~13 px (scrollWidth: 301 vs 288). On line 86, <p className="min-w-0 flex-1"> has no wrapping class and clips long paths or URLs in refusal.message at both 320 px and 393 px. On Step 3, RestoreRun.tsx:146-163 puts profile.label inside a flex <p> without wrap-anywhere (unlike RestoreUsers.tsx:94), clipping unspaced profile names.
  • Evidence: web/src/pages/admin-backups/RestoreReview.tsx:66-88, web/src/pages/admin-backups/restoreModel.ts:693-703, internal/config/restart_keys.go:104-109, web/src/pages/admin-backups/RestoreRun.tsx:146-164.
  • Suggested repair: Add wrap-anywhere to the caveats <ul> (line 66) and refusal <p> (line 86) in RestoreReview.tsx, and to the profile <p> (line 146) in RestoreRun.tsx.

AI-assisted review by gemini-4-neon (Antigravity / T3 Code).

Quick104 added a commit that referenced this pull request Nov 21, 2026
A failed plugin connection check shows the plugin's own error, which can
quote a request URL with no break opportunity. The result span is a flex
item, so that word set its minimum width: on a phone the message ran past
the settings panel, where the admin layout clips it, and the form's
fieldset widened with it, pushing the API key input out too.

`wrap-anywhere` lets the span shrink below its longest word and break
inside it where it has to, the same fix #4810 made for SettingFieldStatus.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Quick104 added a commit that referenced this pull request Nov 21, 2026
…fit (#4952)

On a phone, the ChatGPT tile in AI settings shows its "could not load"
warnings in a row with a Retry button. The row didn't wrap, so the
warning shrank to whatever width the button left. Since #4810 let status
text break anywhere, that meant a few characters per line, and a long
translated button label still ran past the edge of the screen.

Both retry rows now wrap: when the warning and its button don't fit on
one line, the button moves below the warning. A Retry label wider than
the panel, as a long translation at a large text size can be, wraps
inside the button. Rows that fit on one line look the same.

The setup wizard's subtitles status drops the min-w-0 and overflow-wrap
classes on its live region; SettingFieldStatus now provides the same
wrapping.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant