Repository navigation
fix(web): wrap long folder paths in settings and restore status lines - #4810
Conversation
A settings or restore status line whose text held a word with no break opportunity, such as a folder path, ran past its panel on a phone, and the admin layout's clip cut off the end of the path. The status is an inline-flex box, so its text is a flex item that could not shrink below its longest word. wrap-anywhere lets that text shrink and break inside a word that does not fit, on every page that uses SettingFieldStatus. The restore details line that repeats the missing folder paths gets the same class. Text that fits lays out as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 20 minutes. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (gpt-6.2-sol, reviewed f4d8fe4)
S2 (P3) · The restore Review and Result screens still clip long library names
Select a restorable library named Classic_Hollywood_Film_Noir_Restorations_and_Alternate_Cuts. The Choose row can wrap it. The Review plan (RestoreReview.tsx:56) and result heading (RestoreRun.tsx:84) both render it without a fallback break. At 320 CSS px in Chromium fixtures with the shipped layout and font, the name extended about 151 px and 165 px beyond the clipped viewport, respectively. Add wrap-anywhere to the two text containers. Both fit with that change in the same fixtures. This is a pre-existing gap in the restore flow.
AI-assisted review with Codex (gpt-6.2-sol).
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (claude-opus-5-5, reviewed f4d8fe4)
One nit, no defects. I checked each SettingFieldStatus call site under web/src: table cells, the phone backup grid, flex rows next to a Button, SettingFieldRow status slots, and the restore Choose and Users details. I found none where text that fits today would lay out differently. Tailwind is 4.2.1, which ships wrap-anywhere, and other components already use the class. The cantOpen paragraph is a block in a block column, so break-words would have fixed it too. wrap-anywhere matches the status above it and costs nothing, so I'm not asking for a change there.
O1 (nit): see the inline comment. The setup wizard's subtitle status keeps a local copy of this fix that the root class now covers.
AI disclosure: written by Claude Opus 5.5 (claude-opus-5-5).
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (gemini-4-neon, reviewed f4d8fe4)
The two diff changes hold up against CSS Text 3, Flexbox, and Grid rules and across all 75 SettingFieldStatus call sites (BackupTable desktop whitespace-nowrap, phone grid-cols-[minmax(0,1fr)_auto], flex rows with shrink-0 buttons, and RTL). Three nearby surfaces still clip unbroken strings into AdminLayout's overflow-x-clip on phones for the same reason:
G1 (Medium) — ConnectionCheckAction status text overflows its flex row
- File:
web/src/components/admin/ConnectionCheckAction.tsx:45-51 - Trigger: Run a failing connection check on Storage, Redis, Search, Recommendations, or Plugin config at 320 px or 393 px viewport width when the server error includes an endpoint URL or hostname.
- Impact:
<span role="status">sits inside<div className="flex flex-wrap items-center gap-3 py-3.5">withoutwrap-anywhere. Its automatic minimum width stays at the longest unbroken word, so endpoint errors run past the panel and clip inAdminLayout. In headless Chromium, a 60-character quoted URL token overflows by 131 px at 320 px (288 pxcontent width) and 58 px at 393 px (361 pxcontent width). - Evidence:
web/src/components/admin/ConnectionCheckAction.tsx:29-53; handlers ininternal/api/handlers/admin_settings_checks.go(lines 170, 219, 321, 466, 470, 499, 503, 559) andinternal/api/handlers/plugins.go:555return rawerr.Error()strings. - Suggested repair: Add
wrap-anywhereto<span role="status">on line 48.
G2 (Low) — Restore Choose "Never restored" key list overflows at 320 px
- File:
web/src/pages/admin-backups/RestoreChoose.tsx:354-361 - Trigger: Open the Restore Choose step for any backup at 320 px viewport width, go to Settings, and expand "Show them" under "Never restored".
- Impact:
<p className="text-muted-foreground ps-5 pt-1 text-xs leading-relaxed">renders raw<code className="font-mono">{key}</code>tokens withoutwrap-anywhereorBreakableKey.ServerSpecificSettings()always includesrecommendations.policy_marked_generation(40 chars), which overflows the 268 px indented line box by ~25 px (scrollWidth: 313vsclientWidth: 288in Chromium) and clips on 320 px phones (and wider viewports at larger browser font sizes). - Evidence:
web/src/pages/admin-backups/RestoreChoose.tsx:354-361,internal/backup/selective_plan.go:812,internal/backup/settings_classes.go:53. Compareweb/src/pages/admin-backups/RestoreRows.tsx:137-139, which wraps setting keys in<BreakableKey>withbreak-words. - Suggested repair: Render
<BreakableKey value={key} />(exported fromRestoreRows.tsx:100) inside each<code>and addwrap-anywhereto the<p>on line 354.
G3 (Low) — Restore Review caveats and refusal (and Run profile lines) lack wrapping
- File:
web/src/pages/admin-backups/RestoreReview.tsx:66-77, 86(andweb/src/pages/admin-backups/RestoreRun.tsx:146-163) - Trigger: Choose a Settings page with a differing built-in restart-required key such as
catalog.search.meilisearch.matching_strategy(44 chars) orcatalog.search.meilisearch.semantic_enabled(43 chars) and open Step 2 (Review) at 320 px; or trigger a restore refusal naming a long path or URL at 320 px or 393 px. - Impact:
restoreModel.ts:700interpolates raw comma-separated keys intoweb.admin.backups.restore.caveat.restartKeys, andRestoreReview.tsx:66-77renders the list withoutwrap-anywhereorbreak-words(unlike Step 3RestoreRun.tsx:94, which setsbreak-wordson the same sentence). In Chromium at 320 px (288 pxcontent width),catalog.search.meilisearch.matching_strategyoverflows by ~13 px (scrollWidth: 301vs288). On line 86,<p className="min-w-0 flex-1">has no wrapping class and clips long paths or URLs inrefusal.messageat both 320 px and 393 px. On Step 3,RestoreRun.tsx:146-163putsprofile.labelinside aflex<p>withoutwrap-anywhere(unlikeRestoreUsers.tsx:94), clipping unspaced profile names. - Evidence:
web/src/pages/admin-backups/RestoreReview.tsx:66-88,web/src/pages/admin-backups/restoreModel.ts:693-703,internal/config/restart_keys.go:104-109,web/src/pages/admin-backups/RestoreRun.tsx:146-164. - Suggested repair: Add
wrap-anywhereto the caveats<ul>(line 66) and refusal<p>(line 86) inRestoreReview.tsx, and to the profile<p>(line 146) inRestoreRun.tsx.
AI-assisted review by gemini-4-neon (Antigravity / T3 Code).
A failed plugin connection check shows the plugin's own error, which can quote a request URL with no break opportunity. The result span is a flex item, so that word set its minimum width: on a phone the message ran past the settings panel, where the admin layout clips it, and the form's fieldset widened with it, pushing the API key input out too. `wrap-anywhere` lets the span shrink below its longest word and break inside it where it has to, the same fix #4810 made for SettingFieldStatus. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…fit (#4952) On a phone, the ChatGPT tile in AI settings shows its "could not load" warnings in a row with a Retry button. The row didn't wrap, so the warning shrank to whatever width the button left. Since #4810 let status text break anywhere, that meant a few characters per line, and a long translated button label still ran past the edge of the screen. Both retry rows now wrap: when the warning and its button don't fit on one line, the button moves below the warning. A Retry label wider than the panel, as a long translation at a large text size can be, wraps inside the button. Rows that fit on one line look the same. The setup wizard's subtitles status drops the min-w-0 and overflow-wrap classes on its live region; SettingFieldStatus now provides the same wrapping. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (web only:
SettingFieldStatusis a web component, and the Apple, Android, and Roku apps have no admin settings or restore screens)On a phone, a settings or restore status line whose text holds a long word with no place to break, such as a folder path, ran past the edge of its panel. The admin layout clips anything wider than the page, so the end of the path was cut off and couldn't be read. In Arabic it was the start of the path. The clearest case is the restore Choose step. A library whose folder this server can't open says "This server cannot open ." and then repeats the path on the next line. At 393 px both lines ran 110 to 166 px past the row. Settings pages that show a path or a long name in a status had the same problem.
Approach
SettingFieldStatusis aninline-flexbox, so its text is a flex item that can't shrink below its longest word. Addingwrap-anywherelets that text shrink and break inside a word that doesn't fit the line.break-wordswouldn't help here, because it doesn't lower the flex item's minimum width. Every page that uses the status gets the fix, and the icon stays on the first line. The restore details line that repeats the missing paths is a plain paragraph and gets the same class.Text that already fits lays out as before. A word that is wider than its line is now the only thing that breaks mid-word. I checked the call sites where a narrower minimum width could matter:
Validation
main: I added a library with a long folder path, took a backup, then deleted the library and its folder. The restore plan then reported "This server cannot open ." for that library. On the restore Choose step at 393 px, the status ran 166 px past its row and the repeated path line 110 px. At 320 px they ran 239 and 183 px past. The page doesn't scroll sideways, so the end of the path was cut off.main.make lint-changed(no Go changes), and the local-path, case-collision, bidi, and size-ratchet checks pass.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/wrap-long-setting-status-text/
Surface and build: web admin, the restore Choose step and settings pages, at 320, 393, 834, and 1440 px, in English and Arabic. Before is
mainat f964c3a, and after is this branch at f4d8fe4.Risks
None identified.
overflow-wrap: anywhereis supported by every browser the web app targets.Follow-ups
SubtitlesStep.tsx(O1). In progress.Checklist
Council review
Background adversarial review: 1 round, reviewed f4d8fe4 (finished after the merge)
Left for a follow-up PR, since this one had merged:
SubtitlesStep.tsxkeeps a local copy of the fix that is now redundant.Answered:
mainby fix(web): wrap long names on the restore Review and Run steps #4738.Visual review: 2 rounds. Round 1 used captures from a dev-only page that rendered the real components. Round 2 used captures from a live dev deployment, before and after the fix.
Fixed: no changes needed. The captures the reviewers asked for were added: the live restore page, 320 px, Arabic at 320, 834, and 1440 px, and settings rows with statuses beside their controls. Answered:
/or_would also change how ordinary text such asREDIS_URLwraps.main: the path shown twice ([bug] Restore explanations in the expanded row and report stay in English #4669), the disabled checkbox's faint outline, the chip strip that cuts off at 320 px, and the settings label column's 520 px cap.AI Disclosure
🤖 Generated with Claude Code
Note
Fix wrapping of long folder paths in admin settings and restore status lines
wrap-anywhereclass to the status text in theSettingFieldStatuscomponent so long paths can break within words instead of overflowing the line.SettingFieldStatusdocs to explain howwrap-anywherediffers frombreak-wordsfor a flex item.Macroscope summarized f4d8fe4.