Repository navigation
fix(web): put the ChatGPT retry buttons under a warning that doesn't fit - #4952
Merged
Merged
Conversation
On a phone, the ChatGPT tile in AI settings shows its "could not load" warnings in a row with a Retry button. The row didn't wrap, so the warning shrank to whatever width the button left. Since #4810 let status text break anywhere, that meant a few characters per line, and a long translated button label still ran past the edge of the screen. Both retry rows now wrap: when the warning and its button don't fit on one line, the button moves below the warning. A Retry label wider than the panel, as a long translation at a large text size can be, wraps inside the button. Rows that fit on one line look the same. The setup wizard's subtitles status drops the min-w-0 and overflow-wrap classes on its live region; SettingFieldStatus now provides the same wrapping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
#4895 gave the saved-account Reconnect and Disconnect buttons a class that lets a long label wrap inside the button. This branch's Retry buttons needed the same thing, so the two constants become one, WRAPPING_BUTTON, used by all four buttons in the ChatGPT tile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (web admin settings page; the Apple, Android, and Roku apps have no ChatGPT settings screen)
On a phone, the ChatGPT tile in Settings → AI shows a "could not load" warning next to a Retry button when the account or the model list fails to load. The row didn't wrap, so when the two didn't fit on one line the warning shrank to whatever width the button left, and a long translated button label still ran off the screen. Since #4810 let status text break anywhere, the warning could shrink to a couple of characters per line: in Russian at 320 px, the models warning was 30 px wide across 63 lines and its button ended past the edge of the screen. This change, a fix-forward for #4810, moves the button below the warning when the two don't fit.
Approach
Both retry rows (account load failed, models failed) now wrap, with the 4 px row gap the other warning-and-button rows in admin settings use. A Retry label wider than the panel, which happens in Russian or Ukrainian at the app's larger text sizes, wraps inside the button. It uses the class #4895 gave the tile's Reconnect and Disconnect buttons, now named
WRAPPING_BUTTONand shared by all four. Rows that fit on one line are unchanged, and a button on one line keeps its size.English on a phone changes too: its models warning never fit on one line at phone widths, so the button now sits under the warning instead of beside a three-line warning.
The setup wizard's subtitles status drops
min-w-0 [overflow-wrap:anywhere]from its live-region span. That was a local workaround from #4739, andSettingFieldStatusnow provides the same wrapping, so the span lays out the same without it.The sign-in setup field's "Saved" / "Will be cleared" row with Keep / Clear has the same shape but short text. With the longest translations at 320 px and x-large text it stays inside its column, so it's unchanged.
Validation
Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/pr-4952/
Risks
None identified. The change is class names on two rows and their buttons, and one redundant class removal.
Follow-ups
main; this branch merges it and shares its class.Checklist
Council review
Background adversarial review: 1 round, reviewed 12cf0f2 (finished after the merge). The merge of
main(2c59c46), which joined this change's Retry class with #4895's, merged before a second round could run.Resolved by the merge: S1, a long translated word (Ukrainian "завантажити") could stick out of the Retry button with a large browser font plus Silo's x-large text. The merged Retry buttons use #4895's class, which adds
wrap-anywhere, the fix the review tested.Visual review: 2 rounds, on captures from a dev-only page that rendered the real component. The evidence page now shows captures from 2c59c46, where wrapped labels are centered like #4895's buttons.
Fixed: the gap between a warning and its wrapped Retry button is now 4 px, so the button reads with its warning rather than with the actions below; a long Retry label at a large text size wraps inside the button instead of running off the screen. Answered: a last word alone on its line, the 32 px button height, and the faint button outline come from the shared status and button components and look the same before and after.
AI Disclosure
🤖 Generated with Claude Code