Skip to content

fix(web): put the ChatGPT retry buttons under a warning that doesn't fit - #4952

Merged
Quick104 merged 2 commits into
mainfrom
fix/chatgpt-retry-row-wrap
Nov 21, 2026
Merged

Quick104 merged 2 commits into
mainfrom
fix/chatgpt-retry-row-wrap

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (web admin settings page; the Apple, Android, and Roku apps have no ChatGPT settings screen)

On a phone, the ChatGPT tile in Settings → AI shows a "could not load" warning next to a Retry button when the account or the model list fails to load. The row didn't wrap, so when the two didn't fit on one line the warning shrank to whatever width the button left, and a long translated button label still ran off the screen. Since #4810 let status text break anywhere, the warning could shrink to a couple of characters per line: in Russian at 320 px, the models warning was 30 px wide across 63 lines and its button ended past the edge of the screen. This change, a fix-forward for #4810, moves the button below the warning when the two don't fit.

Approach

Both retry rows (account load failed, models failed) now wrap, with the 4 px row gap the other warning-and-button rows in admin settings use. A Retry label wider than the panel, which happens in Russian or Ukrainian at the app's larger text sizes, wraps inside the button. It uses the class #4895 gave the tile's Reconnect and Disconnect buttons, now named WRAPPING_BUTTON and shared by all four. Rows that fit on one line are unchanged, and a button on one line keeps its size.

English on a phone changes too: its models warning never fit on one line at phone widths, so the button now sits under the warning instead of beside a three-line warning.

The setup wizard's subtitles status drops min-w-0 [overflow-wrap:anywhere] from its live-region span. That was a local workaround from #4739, and SettingFieldStatus now provides the same wrapping, so the span lays out the same without it.

The sign-in setup field's "Saved" / "Will be cleared" row with Keep / Clear has the same shape but short text. With the longest translations at 320 px and x-large text it stays inside its column, so it's unchanged.

Validation

  • Reproduced in Chromium before the fix and checked after, in English, Russian, Ukrainian, German, French, and Arabic, from 320 to 1440 px, at the default and x-large text sizes, and with keyboard focus on Retry. A test server can't hold a connected ChatGPT account, so a temporary dev-only page rendered the real component inside the AI page's layout and fixtures answered the ChatGPT status and models requests. After the fix nothing runs off the screen, and rows that fit on one line measure the same as before.
  • Focused tests for the two changed components pass. Wrapping isn't observable in jsdom, so no test was added.
  • Web lint, format check, typecheck and build, bundle budget, changed-lines lint, and the local-path, case-collision, bidi, and size-ratchet checks pass.
  • Full web suite: the only failures are in auth, request-deadline, collections, and player tests that don't import the changed files, and they fail the same way on the base on the machine that ran them.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/pr-4952/

Risks

None identified. The change is class names on two rows and their buttons, and one redundant class removal.

Follow-ups

  • The saved-account "Reconnect" and "Disconnect" buttons in the same tile ran off the screen on a phone with a long label. fix(web): wrap long ChatGPT account button labels on phones #4895 fixed that on main; this branch merges it and shares its class.
  • Not confirmed: the setup wizard's subtitles "Test connection" error may not wrap a long request URL on a phone.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Background adversarial review: 1 round, reviewed 12cf0f2 (finished after the merge). The merge of main (2c59c46), which joined this change's Retry class with #4895's, merged before a second round could run.

Member Round 1
Sol (gpt-6.2-sol, xhigh) 8/10
Opus (claude-opus-5-5, high) 8.5/10, no findings
Gemini (gemini-4-neon, xhigh) unavailable (usage quota)

Resolved by the merge: S1, a long translated word (Ukrainian "завантажити") could stick out of the Retry button with a large browser font plus Silo's x-large text. The merged Retry buttons use #4895's class, which adds wrap-anywhere, the fix the review tested.

Visual review: 2 rounds, on captures from a dev-only page that rendered the real component. The evidence page now shows captures from 2c59c46, where wrapped labels are centered like #4895's buttons.

Member Round 1 Round 2
Sol better, 8/10 better, 9/10
Opus better, 8/10 better, 8.5/10
Gemini better, 8/10 unavailable (usage quota, retried once)

Fixed: the gap between a warning and its wrapped Retry button is now 4 px, so the button reads with its warning rather than with the actions below; a long Retry label at a large text size wraps inside the button instead of running off the screen. Answered: a last word alone on its line, the 32 px button height, and the faint button outline come from the shared status and button components and look the same before and after.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code, T3 Code, Codex (council review), Antigravity (council review), Playwright (captures)
  • Model(s): claude-opus-5-5 (implementation), claude-sonnet-5-5 (review finders), gpt-6.2-sol, gemini-4-neon
  • Involvement: Fully AI-generated. The agent verified it in a browser on a dev-only page that rendered the real component; a person has not verified it yet.
  • Adversarial review: a multi-agent code review on claude-opus-5-5 and claude-sonnet-5-5 (three finders and a validation pass in two rounds, then an xhigh sweep) found that a long Retry label still ran off the screen at large text sizes and that the row gap differed from the other warning rows; both are fixed. Its other findings were about older code next to the change and are listed under Follow-ups. The plan round was skipped because the fix is a few class names at the root cause. A simplify pass changed nothing. See Council review for the background and visual reviews.

🤖 Generated with Claude Code

On a phone, the ChatGPT tile in AI settings shows its "could not load"
warnings in a row with a Retry button. The row didn't wrap, so the
warning shrank to whatever width the button left. Since #4810 let status
text break anywhere, that meant a few characters per line, and a long
translated button label still ran past the edge of the screen.

Both retry rows now wrap: when the warning and its button don't fit on
one line, the button moves below the warning. A Retry label wider than
the panel, as a long translation at a large text size can be, wraps
inside the button. Rows that fit on one line look the same.

The setup wizard's subtitles status drops the min-w-0 and overflow-wrap
classes on its live region; SettingFieldStatus now provides the same
wrapping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The ChatGPT connection settings update button and error-row wrapping classes. The subtitle setup step removes two wrapping-related classes from its failure-status span.

Changes: UI layout adjustments

Layer / File(s) Summary
ChatGPT connection actions and errors
web/src/pages/admin-settings/ChatGPTConnection.tsx
Retry, reconnect, and disconnect buttons use the WRAPPING_BUTTON class. Load-error and model-error rows use wrapping flex layouts with horizontal and vertical gaps.
Subtitle failure status
web/src/pages/setup-wizard/steps/SubtitlesStep.tsx
The failure-status span no longer has the min-w-0 and [overflow-wrap:anywhere] classes.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 2c59c

This change adjusts how ChatGPT retry buttons and warning text wrap on narrow screens, and removes redundant wrapping classes from a setup status message. The effect is limited to layout, and no functional risk is evident. It is ready to merge.

Security architecture risk: Minimal · up to 2c59c

This change adjusts how warnings and buttons fit on narrow screens. The inspected changes do not introduce or worsen risks to access controls, account ownership, failure recovery, or deployment behavior.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the ChatGPT retry buttons are moved under a warning when the two do not fit on one line. It matches the changeset (ChatGPTConnection.tsx wrapping changes) and the PR o…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is specific and on-topic. It names the ChatGPT retry rows in the admin AI settings page, the WRAPPING_BUTTON class change, and the removal of min-w-0 and overflow-wrap classes from the…
Full details: Title check

Explanation

The title names the main change: the ChatGPT retry buttons are moved under a warning when the two do not fit on one line. It matches the changeset (ChatGPTConnection.tsx wrapping changes) and the PR objectives. It uses the fix() prefix, and the wording is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description is specific and on-topic. It names the ChatGPT retry rows in the admin AI settings page, the WRAPPING_BUTTON class change, and the removal of min-w-0 and overflow-wrap classes from the setup wizard subtitles status span. It also lists the validation performed and the follow-ups. This matches the changeset described in the raw summary and the PR objectives.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 31651c9e-6895-40d3-b3e2-7bca95ab06fa
Commits

Reviewing files that changed from the base of the PR and between 1a93371 and 2c59c46.

Files selected for processing: 2

  • web/src/pages/admin-settings/ChatGPTConnection.tsx
  • web/src/pages/setup-wizard/steps/SubtitlesStep.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T06:45:42.437941Z 2c59c46 New commits
🔒 Security Review ✅ Completed 2026-11-21T06:47:13.737191Z 2c59c46 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
#4895 gave the saved-account Reconnect and Disconnect buttons a class
that lets a long label wrap inside the button. This branch's Retry
buttons needed the same thing, so the two constants become one,
WRAPPING_BUTTON, used by all four buttons in the ChatGPT tile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Quick104
Quick104 merged commit 9982fcb into main Nov 21, 2026
18 checks passed
@Quick104
Quick104 deleted the fix/chatgpt-retry-row-wrap branch November 21, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant