Skip to content

fix(web): wrap long ChatGPT account button labels on phones - #4895

Merged
Quick104 merged 1 commit into
mainfrom
fix/chatgpt-account-buttons-wrap
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/chatgpt-account-buttons-wrap

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none

Other clients: N/A (web admin only; the Apple, Android, and Roku apps have no ChatGPT plan settings)

On a phone, the ChatGPT plan panel in Settings → AI → Text model cut off the saved-account buttons. "Reconnect " and "Disconnect " never wrapped, so a long email or a longer translation ran the button past the screen's edge, where the admin layout clips it. At 390 px, "Reconnect" with a 43-character email ended about 90 px off screen. At 320 px, the Russian "Переподключить" ran past the edge even with an 18-character email. In Arabic the buttons ran off the left edge.

Found in review of #4810.

Approach

These two buttons now let their label wrap inside the button, and an email can break at any character, since it has no spaces. They grow taller instead of wider. That's the same set of overrides RestoreReview uses for its long refusal action (h-auto min-h-8 max-w-full py-1 whitespace-normal), plus wrap-anywhere for the email. A label that already fits on one line keeps its 32 px button, so tablet and desktop don't change.

Validation

  • Reproduced before the fix and checked after it on a temporary dev-only route that rendered the real ChatGPTConnection inside the AI settings page's wrappers, with the ChatGPT status mocked in the browser. A connected ChatGPT account can't be set up on a dev deployment. I measured each email button's edges against the viewport in English, Russian, and Arabic at 320, 390, 820, 1280, and 1440 px. Before: 14 of 18 email buttons at phone widths fell outside the screen. After: none did, and the tablet and desktop positions and heights were unchanged.
  • ChatGPTConnection unit tests, tsc -b, ESLint, and Prettier on the changed file pass.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/pr-4895/

Risks

None identified. The change touches CSS classes on two buttons in one panel.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Ran as a follow-up of #4810's review, so with one reviewer per round instead of three.

Background review: 1 round, last reviewed 96347b3

Member Round 1
Sol (gpt-6.2-sol, high) 9/10, no findings

Visual review: 1 round, captures from 96347b3 (also Arabic keyboard focus and a Russian recapture after fonts loaded)

Member Round 1
Sol (gpt-6.2-sol, high) better, 8/10

Answered: the faint hover fill on outline buttons and the account select clipping a long email without an ellipsis look the same before this change. A Russian intro paragraph that wrapped differently between captures has the same 240 px box in both, so nothing above the buttons moved. An email breaking mid-word is the fallback only when no space or hyphen fits.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; T3 Code delegated tasks (Codex provider) for the visual and background reviews; headless Chromium (Playwright) for measurements and captures
  • Model(s): claude-opus-5-5 (implementation, code review); claude-sonnet-5-5 (code-review cleanup finder and validation check); gpt-6.2-sol (visual and adversarial review)
  • Involvement: Fully AI-generated; the agent verified it in a dev-only harness, a person hasn't yet
  • Adversarial review: code review at medium (three finders and a validation check). It found no defects and dropped a redundant max-w-full on the row wrapper, which measured the same without it. The plan round was skipped because the fix is mechanical. See Council review.

🤖 Generated with Claude Code

The saved-account Reconnect and Disconnect buttons name the account's
email and never wrapped, so a long email, or a longer language such as
Russian, ran past the screen's edge on a phone. The label now wraps
inside the button and breaks the email where it has to.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2a15f175-c4f8-4cfe-b2e6-a2f268ed4a57
Commits

Reviewing files that changed from the base of the PR and between 9797a50 and 96347b3.

Files selected for processing: 1

  • web/src/pages/admin-settings/ChatGPTConnection.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T04:47:49.108578Z 96347b3 PR opened
🔒 Security Review ✅ Completed 2026-11-21T04:49:28.297009Z 96347b3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit 9f99bed into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/chatgpt-account-buttons-wrap branch November 21, 2026 05:10
Quick104 added a commit that referenced this pull request Nov 21, 2026
#4895 gave the saved-account Reconnect and Disconnect buttons a class
that lets a long label wrap inside the button. This branch's Retry
buttons needed the same thing, so the two constants become one,
WRAPPING_BUTTON, used by all four buttons in the ChatGPT tile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant