Repository navigation
fix(web): wrap long ChatGPT account button labels on phones - #4895
Conversation
The saved-account Reconnect and Disconnect buttons name the account's email and never wrapped, so a long email, or a longer language such as Russian, ran past the screen's edge on a phone. The label now wraps inside the button and breaks the email where it has to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 50 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
#4895 gave the saved-account Reconnect and Disconnect buttons a class that lets a long label wrap inside the button. This branch's Retry buttons needed the same thing, so the two constants become one, WRAPPING_BUTTON, used by all four buttons in the ChatGPT tile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (web admin only; the Apple, Android, and Roku apps have no ChatGPT plan settings)
On a phone, the ChatGPT plan panel in Settings → AI → Text model cut off the saved-account buttons. "Reconnect " and "Disconnect " never wrapped, so a long email or a longer translation ran the button past the screen's edge, where the admin layout clips it. At 390 px, "Reconnect" with a 43-character email ended about 90 px off screen. At 320 px, the Russian "Переподключить" ran past the edge even with an 18-character email. In Arabic the buttons ran off the left edge.
Found in review of #4810.
Approach
These two buttons now let their label wrap inside the button, and an email can break at any character, since it has no spaces. They grow taller instead of wider. That's the same set of overrides
RestoreReviewuses for its long refusal action (h-auto min-h-8 max-w-full py-1 whitespace-normal), pluswrap-anywherefor the email. A label that already fits on one line keeps its 32 px button, so tablet and desktop don't change.Validation
ChatGPTConnectioninside the AI settings page's wrappers, with the ChatGPT status mocked in the browser. A connected ChatGPT account can't be set up on a dev deployment. I measured each email button's edges against the viewport in English, Russian, and Arabic at 320, 390, 820, 1280, and 1440 px. Before: 14 of 18 email buttons at phone widths fell outside the screen. After: none did, and the tablet and desktop positions and heights were unchanged.ChatGPTConnectionunit tests,tsc -b, ESLint, and Prettier on the changed file pass.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/pr-4895/
Risks
None identified. The change touches CSS classes on two buttons in one panel.
Checklist
Council review
Ran as a follow-up of #4810's review, so with one reviewer per round instead of three.
Background review: 1 round, last reviewed 96347b3
Visual review: 1 round, captures from 96347b3 (also Arabic keyboard focus and a Russian recapture after fonts loaded)
Answered: the faint hover fill on outline buttons and the account select clipping a long email without an ellipsis look the same before this change. A Russian intro paragraph that wrapped differently between captures has the same 240 px box in both, so nothing above the buttons moved. An email breaking mid-word is the fallback only when no space or hyphen fits.
AI Disclosure
max-w-fullon the row wrapper, which measured the same without it. The plan round was skipped because the fix is mechanical. See Council review.🤖 Generated with Claude Code