Repository navigation
fix(web): wrap a long connection check result inside its panel - #4933
Conversation
A failed plugin connection check shows the plugin's own error, which can quote a request URL with no break opportunity. The result span is a flex item, so that word set its minimum width: on a phone the message ran past the settings panel, where the admin layout clips it, and the form's fieldset widened with it, pushing the API key input out too. `wrap-anywhere` lets the span shrink below its longest word and break inside it where it has to, the same fix #4810 made for SettingFieldStatus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 1 minute. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
Related issue: N/A
Validation tasks: none
Other clients: N/A (web admin only; Apple, Android, and Roku don't run admin connection checks)
On a phone, a failed plugin connection check whose message contains a long URL runs past the settings panel, and the admin layout cuts it off at the screen edge. It also pushes the plugin's API key input out of the panel. This change wraps the message inside the panel, breaking inside the URL only where it has to.
A plugin's check returns the plugin's own error text, and Go's HTTP errors quote the request URL as one word with no break point. When TheIntroDB's API can't be reached, the check shows
Connection check failed: introdb: stats request failed: Get "https://api.theintrodb.org/v4/user/stats": dial tcp: …, which overflows a 320 px screen. A longer URL, such as a self-hosted plugin endpoint, overflows at 393 px too. The message is a flex item, so its longest word set its minimum width. The plugin form is a fieldset, whose minimum width follows its content, so the whole form widened with it.Found in review of #4810.
Approach
Add
wrap-anywhereto the result inConnectionCheckAction, the same fix #4810 made forSettingFieldStatus. Unlikebreak-words, it lets the flex item shrink below its longest word.The Storage, Redis, Search, and Recommendations settings and the setup wizard use the same component. Their checks only return text the server wrote, which already wraps, so they look the same.
The red failure text measures 3.56:1 against the panel, below 4.5:1. That was already the case, and its fix changes the same line, so #4934 tracks it to follow this pull request.
Validation
make test-web: 7 files fail on my machine and fail the same way onmain; none of them touches this component. The tests for its callers pass.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/connection-check-wrap/
Risks
None identified. A short message or a wide screen renders as before.
Checklist
Council review
Background review: 1 round, reviewed 08c591b; no findings, nothing posted.
Visual review: 2 rounds, round 2 captures from 08c591b
Fixed: capture pairs had different focus states, so round 2 retook them with focus cleared and added a success message and a medium-length failure at 320 px. Answered: breaking inside a URL is the intended fallback; button size, the missing status icon, button emphasis, and label casing were already there and are outside this change. Split out: the red text contrast, #4934.
AI Disclosure
🤖 Generated with Claude Code
Note
Fix connection-check result overflow with
wrap-anywhereclassThe connection-check result message could overflow its panel when it contained a long unbreakable word, because the flex item could not shrink. Adds the
wrap-anywhereclass to the result message span in ConnectionCheckAction.tsx so it wraps at arbitrary points and fits inside the panel.Macroscope summarized 08c591b.