Skip to content

fix(web): wrap a long connection check result inside its panel - #4933

Merged
Quick104 merged 1 commit into
mainfrom
fix/wrap-connection-check-errors
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/wrap-connection-check-errors

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none
Other clients: N/A (web admin only; Apple, Android, and Roku don't run admin connection checks)

On a phone, a failed plugin connection check whose message contains a long URL runs past the settings panel, and the admin layout cuts it off at the screen edge. It also pushes the plugin's API key input out of the panel. This change wraps the message inside the panel, breaking inside the URL only where it has to.

A plugin's check returns the plugin's own error text, and Go's HTTP errors quote the request URL as one word with no break point. When TheIntroDB's API can't be reached, the check shows Connection check failed: introdb: stats request failed: Get "https://api.theintrodb.org/v4/user/stats": dial tcp: …, which overflows a 320 px screen. A longer URL, such as a self-hosted plugin endpoint, overflows at 393 px too. The message is a flex item, so its longest word set its minimum width. The plugin form is a fieldset, whose minimum width follows its content, so the whole form widened with it.

Found in review of #4810.

Approach

Add wrap-anywhere to the result in ConnectionCheckAction, the same fix #4810 made for SettingFieldStatus. Unlike break-words, it lets the flex item shrink below its longest word.

The Storage, Redis, Search, and Recommendations settings and the setup wizard use the same component. Their checks only return text the server wrote, which already wraps, so they look the same.

The red failure text measures 3.56:1 against the panel, below 4.5:1. That was already the case, and its fix changes the same line, so #4934 tracks it to follow this pull request.

Validation

  • Chromium, on a temporary dev-only page (not in this PR) that renders the real plugin form inside the admin layout and plugin settings panel, with TheIntroDB's catalog schema and the error text traced from the server and plugin source. A dev deployment couldn't start because its host had run out of Docker network address pools, and it couldn't make one plugin's API unreachable anyway.
  • Before: TheIntroDB's message ran 38 px past the panel at 320 px; a 63-character URL ran 202 px past at 320 px and 129 px at 393 px. The API key input moved out by the same amount each time.
  • After: the message and the input stay inside the panel at 320, 393, 820, and 1440 px. Tablet, desktop, a short success message, and a medium-length failure look the same as before.
  • Web lint (no errors), format check, build, bundle budget, and the local-path, bidi, and case-collision checks pass.
  • make test-web: 7 files fail on my machine and fail the same way on main; none of them touches this component. The tests for its callers pass.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/connection-check-wrap/

Risks

None identified. A short message or a wide screen renders as before.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Background review: 1 round, reviewed 08c591b; no findings, nothing posted.

Member Round 1
Sol (gpt-6.2-sol, xhigh) 10/10
Opus (claude-opus-5-5, high) 9/10
Gemini (gemini-4-neon, xhigh) unavailable (provider quota)

Visual review: 2 rounds, round 2 captures from 08c591b

Member Round 1 Round 2
Sol better, 8/10 better, 8/10
Opus better, 7/10 better, 8/10
Gemini better, 7/10 unavailable (provider quota)

Fixed: capture pairs had different focus states, so round 2 retook them with focus cleared and added a success message and a medium-length failure at 320 px. Answered: breaking inside a URL is the intended fallback; button size, the missing status icon, button emphasis, and label casing were already there and are outside this change. Split out: the red text contrast, #4934.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; Codex and Antigravity (council review); Playwright Chromium (captures)
  • Model(s): claude-opus-5-5 (implementation and code review), claude-sonnet-5-5 (review finder), gpt-6.2-sol, gemini-4-neon
  • Involvement: Fully AI-generated. The agent verified it in Chromium on the dev-only page described above; a person has not verified it yet.
  • Adversarial review: a multi-agent code review at xhigh (three finders and a sweep) found no defects. Two finders noted that the new comment named only plugin checks, and it now gives the general reason. The plan round was skipped because the fix is one class at the root cause, and a simplify pass changed nothing. See Council review for the background and visual reviews.

🤖 Generated with Claude Code

Note

Fix connection-check result overflow with wrap-anywhere class

The connection-check result message could overflow its panel when it contained a long unbreakable word, because the flex item could not shrink. Adds the wrap-anywhere class to the result message span in ConnectionCheckAction.tsx so it wraps at arbitrary points and fits inside the panel.

Macroscope summarized 08c591b.

A failed plugin connection check shows the plugin's own error, which can
quote a request URL with no break opportunity. The result span is a flex
item, so that word set its minimum width: on a phone the message ran past
the settings panel, where the admin layout clips it, and the form's
fieldset widened with it, pushing the API key input out too.

`wrap-anywhere` lets the span shrink below its longest word and break
inside it where it has to, the same fix #4810 made for SettingFieldStatus.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 147186a5-c71e-46df-93d6-a4c557500098
Commits

Reviewing files that changed from the base of the PR and between e99fdd2 and 08c591b.

Files selected for processing: 1

  • web/src/components/admin/ConnectionCheckAction.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T05:45:19.512570Z 08c591b PR opened
🔒 Security Review ✅ Completed 2026-11-21T05:47:25.776898Z 08c591b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have javascript Pull requests that update javascript code priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit 5ce0f18 into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/wrap-connection-check-errors branch November 21, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have javascript Pull requests that update javascript code priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant