Repository navigation
Conversation
This was referenced Oct 3, 2026
6 tasks done
tang-vu
force-pushed
the
fix/native-quality-batch-20261003
branch
from
October 4, 2026 09:54
2a28e33 to
3273c97
Compare
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7298. Windows
ods.ps1 chatcurrently bypasses an enabled switchboard and sends neither the native llama-server credential nor UTF-8 prompt bytes. Useods/currentwith the saved gateway port/key when the switchboard is enabled; otherwise honor the resolved native endpoint'sLLAMA_SERVER_API_KEYand saved GGUF alias. Missing required keys refuse the request. Failed requests remain on the selected route.This current-main maintenance removes the retired Lemonade branch and replaces its obsolete wire tests. Docker llama-server retains the existing default-model behavior, configured port/API path, and no native-key forwarding.
Why this matters
The shipped Windows CLI is a real client of the configured inference route. On current main,
ods.ps1 chatbypasses a selected switchboard; direct native requests omit the required credential, and Windows PowerShell 5.1 string serialization can corrupt Unicode prompts. This restores that public command across the supported current endpoints without bypassing a failed selected route.Overlap check
Reviewed current main's endpoint resolver and native llama startup contract, plus the existing PR's original scope. This updates #7214 in place; it does not reintroduce the retired Lemonade runtime. The other maintained tang-vu model/UI PRs concern download staging and remote-peer inventory, not Windows CLI request routing. Existing endpoint/readiness contracts remain intact.
Validation
Base:
36b950130c7378c83946213569c3766d2e2b3c8b. Candidate:f6409e57d8283250dce5647694e310b6c7675a98.The original published head
3273c97e8e8db6d60b662e03a907772242605bf3is preserved as an ancestor through a normal main merge. Its eight historical wire tests fail five retired-Lemonade assumptions after integration onto this main. The first eight replacement regressions fail seven cases on exact unmodified main, including missing routing/auth and Unicode handling; the unchanged Docker control passes.Agent-executed native Windows checks on the candidate source (including an independent root replay of all nine HTTP-wire cases at this exact candidate):
Existing Windows workflow explicitly executes
test-windows-cli-chat.py; no test-only file is left unexecuted. Root also ran the available portable PSScriptAnalyzer against the CLI with the exact CI settings: zero warnings/errors. Hosted current-head checks are monitored separately.AI Assistance
Tang Vu (
tang-vu) provided project direction, scope decisions and environment setup. Codex assisted source analysis, implementation, isolated tests and review preparation. Commands above were agent-executed; personal human verification or independent maintainer release acceptance is not inferred.Release Lane
mainChanged Surface
Risk And Validation
Risk: High (Windows CLI model routing/authentication). Loopback fixtures exercised the public CLI without touching an installed service, customer configuration or real model. Full installed model/GPU/Portal, fleet, and independent human/maintainer release approval remain deferred. The command's existing error-reporting/exit convention is unchanged. Rollback is reverting this source scope; no stored data migration is introduced.
Operational Change Check