Repository navigation
Conversation
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The Models page could show the loaded model while Benchmark discarded its installed route's TLS, API prefix and authentication. It could also treat a saved
GGUF_FILEas a live loaded identity after the runtime reported no loaded model or its health endpoint failed, then send a completion request that implicitly loaded that stale model.Benchmark now uses the existing destination-bound chat route resolver and requires an observed loaded identity before sending inference. Direct runtimes receive that observed identity; the shipped LiteLLM gateway receives
ods/current. Missing runtime evidence returns 503 without a completion request or saved performance sample. After the owner loads a model, a fresh request can benchmark it normally.Validation on
37510d0b4d110c8d14280c98eb31b5c5310af73e, based on current upstream main49c1e6e376ce1771cbe9572426de1d0a2ca0477d, native Windows and Python 3.14:The existing PR history is preserved; current main was merged without conflicts. Only
routers/models.pyandtests/test_benchmark_transport.pyare changed against main. #2471 validates malformed model-observation shapes; this change does not duplicate its observer hunks. #6992 repairs registered-store activation idempotence independently.The shipped Lemonade v10.2.0 server specification documents that chat completions auto-load a model that is not already loaded. The HTTP fixture verifies ODS request behavior; it is not a live Lemonade or GPU performance claim.
No fresh Docker/WSL installation, live Lemonade process, model inference or browser end-to-end validation ran. Concurrent replacement after a valid initial observation remains an existing limitation. Request usage/wall-time measurements retain their explicit label and include gateway and transport overhead.
Overlap check
Searched open and closed upstream PRs for benchmark transport, TLS/prefix authentication, observed model identity and no-loaded-model behavior; inspected changes to routers/models.py. #2471 handles malformed observation shapes and is not duplicated. #6992 covers registered-store reloads, and #7213 covers Hugging Face credentials. This updates the existing canonical #6990 rather than opening a competing PR.
AI Assistance
Codex implemented the original route fix and this observed-model safety follow-up, reproduced the failure and conducted an independent final-head review. Human review remains required before merge.
Release Lane
Changed Surface
Risk And Validation
Medium risk. The exact-SHA focused and related receipts above passed; independent reviewer reran 13 transport tests without blocking findings. git diff --check passed. No data migration is introduced.
Operational Change Check
Combined batch validation
These five independently useful PRs were merged without conflicts onto synthetic integration head
0f8d40fa2116a0ea4111d1aff4905f8a9c07a549, based on main49c1e6e376ce1771cbe9572426de1d0a2ca0477d: #7212, #7213, #6990, #3835, #7214. This records the tested order, not a merge dependency.Combined native validation: 339 dashboard API/models/performance/workflows/agent tests passed, 3 live n8n-key tests passed, and 8 native PowerShell 5.1 CLI HTTP tests passed.
git diff --checkand the PowerShell parser passed. The HTTP/SDK fixture and unavailable live Docker/model/Portal limits stated above still apply; integration success does not close those gates.