Repository navigation
Conversation
This was referenced Oct 3, 2026
tang-vu
force-pushed
the
fix/hf-token-live-rotation
branch
from
October 4, 2026 09:54
e6de6ad to
ae482b2
Compare
Collaborator
|
Thanks for looking at credential handling. As written, an empty saved token makes the host agent pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read persisted credentials with removal semantics; bind retries and caches to a captured credential identity; explicitly disable cached Hub credentials after removal.
Reconstructed only the reviewed #7213 scope on current upstream
mainb4f015a921c59eeb20317c5f48adf2dfb43b1430. Local candidate0d238ded4dfe2bb6d1c0d0f5f6800d8729e2932c; previous published heade6de6ad9065664356c7650410aa35f9d5a7d68fdis retained locally underrefs/archive/ods-20261004/pr-7213. No behavioral changes were added during reconstruction; current-main changes outside this scope are preserved.Issue association: Closes #7299.
AI Assistance
The human contributor and Codex collaborated on this PR. The contributor provided project direction, scope decisions and environment setup; Codex assisted with analysis, implementation or reconstruction, tests, review and PR preparation. The validation commands were executed by Codex, with results and limitations documented in this PR. The human contributor remains responsible for the final changes and validation claims. Maintainer review and applicable release gates remain required before merge. Earlier independent AI review receipts apply only to their recorded heads; current-candidate validation is identified separately in this PR.
Release Lane
mainChanged Surface
Risk And Validation
Risk level: High
git diff --check
Focused tests
Commit identity gate against exact current-main base/candidate
579 models/host-agent tests passed, 11 skipped.
The focused results were run on the exact candidate file tree before committing; the commit only recorded that tested tree. Original-head/full native and combined integration receipts remain archived, and are inherited evidence rather than fresh install or new-head hosted CI results.
CI execution: dashboard.yml discovers model and host-agent tests.
Operational Change Check
Notes For Reviewers
Metadata retry and SDK child boundaries are exercised with fixtures; real gated Hub download/token rotation is unverified.
Rollback: revert this scope; preserve existing recovery receipts and configured data. Local native tests and green original-head CI do not replace human review or deployed-runtime gates.
CI follow-up
The new mypy ratchet rejected assigning an invented attribute directly to ModuleType. Installing hf_hub_download via monkeypatch preserves the SDK fixture behavior. Eight HF credential tests passed; mypy 2.4.0 reports no new errors in the changed file (22 existing baseline errors remain).