Repository navigation
fix(cli): authenticate native chat and fail when no answer is returned - #7877
Merged
Lightheartdevs merged 2 commits intoOct 22, 2026
Merged
Conversation
tang-vu
force-pushed
the
fix/cli-chat-error-exit-20261021
branch
from
October 22, 2026 05:02
0d335a7 to
2b66b2d
Compare
This was referenced Oct 22, 2026
Collaborator
|
Thanks for making chat failures visible to scripts and adding real HTTP response coverage for both native CLIs. Advisory status: not ready yet Quickest path to merge:
What I checked:
|
Merged
5 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ods chatcan report success even though the server returned an error or no answer. On Windows, native llama-server also requires a credential that the endpoint resolver returns but the chat command did not send. This change returns a nonzero exit code for HTTP/API failures and missing, empty, whitespace-only or non-string assistant text, and sends the configured native credential as an HTTP header. Successful answer text retains its surrounding whitespace.The Windows command exits 1 through its existing command dispatcher. The macOS command returns 1 to the script. Neither path logs the credential or changes model/runtime configuration.
Validation at
9603f2655945954186567a5f56360b5ffeda2b74, based on current mainc99f52822f2c37813fd880004f964ca83dfc5a35:ODS_HOMEand a loopback HTTP server. They no longer extract functions or stub the route resolver.ODS CLI LIVE 7877with exit 0. These used candidate CLI files in isolated source locations; they did not replace installed files.git diff --checkpass. Updated-head CI is required before merge.Scope: the native Windows credential behavior is verified through the real resolver and an authenticated HTTP fixture. Strixy is unreachable, so this is not a physical Strixy/native-AMD model qualification. These CLI results do not establish fleet green or browser/Portal acceptance.
AI assistance: the original change and this fleet-driven repair used AI assistance. Codex ran and reviewed the tests under the owner's authorization, with bounded Tower2 review. Local review findings were checked against source and runtime evidence; no independent human review is implied.