Repository navigation
fix(pixel-gateway): validate stop parameter type and length - #6333
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admits the optionalstopgeneration parameter without validating type or sequence bounds. Callers can submit arbitrary types (e.g., numbers, dictionaries, nulls) or lists exceeding the standard maximum of 4 stop sequences, leading to unhandled downstream serialization errors or backend tokenizer crashes.This change surgically enforces that
stopmust be either a single string or a list of at most 4 strings invalidate_request, rejecting invalid configurations withinvalid-inference-request. Valid string and list sequences remain fully supported.Validation
stop: 123,stop: ["1","2","3","4","5"], orstop: [None]were accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Valid stop tokens pass cleanly.Overlap check
Recent PRs #6332 (presence/frequency penalty bounds in runtime gateway), #6331 (seed integer validation in runtime gateway), and #6330 (temperature bounds in runtime gateway) address independent parameters in
runtime_gateway.py. This PR isolates verification to thestopparameter without overlapping with penalty or sampling logic.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6332 at a7279ab without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.