Repository navigation
fix(pixel-gateway): validate user parameter string type and length - #6336
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admits the optionaluserclient identifier without verifying string type or bounding length. Incoming requests with non-string representations (such as integers, booleans, or objects), empty strings, or unconstrained oversized payloads pass admission checks and trigger serialization failures or telemetry storage issues downstream.This change surgically enforces that
usermust be a non-empty string of at most 512 characters (isinstance(payload['user'], str) and 1 <= len(payload['user']) <= 512) invalidate_request, rejecting invalid configurations withinvalid-inference-request. Standard user identifiers and email/UUID tokens remain fully supported.Validation
user: "",user: 123,user: True, or strings longer than 512 characters were accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Valid strings pass cleanly.Overlap check
Recent PRs #6335 (reasoning_effort values in runtime gateway), #6334 (logprobs bounds in runtime gateway), and #6333 (stop parameter validation in runtime gateway) harden separate request parameters. This PR focuses exclusively on the
userparameter inods/bin/pixel_provider/runtime_gateway.pywithout conflicting.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6335 at 3f7dd7a without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.