Repository navigation
fix(pixel-gateway): validate logprobs boolean and top_logprobs integer bounds - #6334
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In$[0, 20]$ integer range, or
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admitslogprobsandtop_logprobswithout verifying boolean constraints, integer limits, or mutual dependency. Clients supplying non-boolean values forlogprobs(e.g. string"true"or integers1/0),top_logprobsvalues outside the allowedtop_logprobswithout enablinglogprobs: Truebypass validation and trigger unhandled downstream API errors or backend inference failures.This change surgically enforces that
logprobsmust be a boolean andtop_logprobsmust be an integer between 0 and 20 requiringlogprobs: Trueinvalidate_request, rejecting invalid configurations withinvalid-inference-request. Valid token log probability configurations remain fully supported.Validation
logprobs: "true",top_logprobs: 25, ortop_logprobs: 5withoutlogprobs: Truewere accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Valid boolean flags and top_logprobs inOverlap check
Recent PRs #6333 (stop parameter validation in runtime gateway), #6332 (presence and frequency penalty bounds in runtime gateway), and #6331 (seed integer type guard in runtime gateway) harden other request attributes in
runtime_gateway.py. This PR isolates checks exclusively tologprobsandtop_logprobswithout conflicting with adjacent parameters.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6333 at bd263e6 without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.