Repository navigation
fix(pixel-gateway): validate reasoning_effort values in runtime gateway - #6335
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admits the reasoning model parameterreasoning_effortwithout verifying that its value belongs to the allowed enumeration. When callers supply unsupported reasoning levels (e.g."extreme","none", or empty strings) or non-string types, the request is forwarded to backend inference workers and causes upstream argument rejection or unhandled 500 exceptions.This change surgically enforces that
reasoning_effortmust be one of('low', 'medium', 'high')invalidate_request, rejecting malformed or unsupported values withinvalid-inference-request. Valid reasoning effort options remain fully supported.Validation
reasoning_effort: "extreme",reasoning_effort: "", orreasoning_effort: 123were accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Permitted values ("low","medium","high") pass cleanly.Overlap check
Recent PRs #6334 (logprobs bounds in runtime gateway), #6333 (stop parameter validation in runtime gateway), and #6332 (presence/frequency penalty bounds in runtime gateway) cover distinct request fields. This PR isolates verification to
reasoning_effortinods/bin/pixel_provider/runtime_gateway.pywithout overlap.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6334 at f7cc1af without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.