Skip to content

fix(pixel-gateway): validate reasoning_effort values in runtime gateway - #6335

Closed
vaibhavsrv wants to merge 1 commit into
Osmantic:public-betafrom
vaibhavsrv:fix/pixel-gateway-reasoning-effort
Closed

vaibhavsrv wants to merge 1 commit into
Osmantic:public-betafrom
vaibhavsrv:fix/pixel-gateway-reasoning-effort

Conversation

@vaibhavsrv

Copy link
Copy Markdown
Contributor

Why this matters

In ods/bin/pixel_provider/runtime_gateway.py, the validate_request routine admits the reasoning model parameter reasoning_effort without verifying that its value belongs to the allowed enumeration. When callers supply unsupported reasoning levels (e.g. "extreme", "none", or empty strings) or non-string types, the request is forwarded to backend inference workers and causes upstream argument rejection or unhandled 500 exceptions.

This change surgically enforces that reasoning_effort must be one of ('low', 'medium', 'high') in validate_request, rejecting malformed or unsupported values with invalid-inference-request. Valid reasoning effort options remain fully supported.

Validation

  • Baseline reproduction: Payloads specifying reasoning_effort: "extreme", reasoning_effort: "", or reasoning_effort: 123 were accepted by validate_request.
  • Post-fix behavior: Requests with unsupported reasoning levels or non-string types raise RuntimeErrorCode('invalid-inference-request'). Permitted values ("low", "medium", "high") pass cleanly.
  • Telemetry: Pixel gateway suites: 2 passed. New-test Ruff, ShellCheck, and diff checks pass; new regressions wired into Linux CI.

Overlap check

Recent PRs #6334 (logprobs bounds in runtime gateway), #6333 (stop parameter validation in runtime gateway), and #6332 (presence/frequency penalty bounds in runtime gateway) cover distinct request fields. This PR isolates verification to reasoning_effort in ods/bin/pixel_provider/runtime_gateway.py without overlap.

Risk / AI disclosure

AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.

Follow-up integration evidence

Composed with #6334 at f7cc1af without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants