Repository navigation
fix(pixel-gateway): validate presence and frequency penalty bounds - #6332
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In$[-2.0, 2.0]$ (e.g. $-3.0$ or $5.0$ ) or pass non-numeric types such as booleans or strings, requests bypass validation and trigger backend runtime errors or severe token repetition distortion.
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admits the optionalpresence_penaltyandfrequency_penaltyparameters without verifying range boundaries or types. When callers pass values outside the OpenAI/ODS standard rangeThis change surgically enforces$[-2.0, 2.0]$ boundaries and numeric types (
type in (int, float)) for bothpresence_penaltyandfrequency_penaltyinvalidate_request, rejecting out-of-bounds or malformed configurations withinvalid-inference-request. Valid penalties within the supported range remain unaffected.Validation
presence_penalty: -2.5,frequency_penalty: 3.0, orpresence_penalty: Truewere accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Valid penalties from -2.0 to 2.0 pass cleanly.Overlap check
Recent PRs #6331 (seed integer validation in runtime gateway), #6330 (temperature bounds in runtime gateway), and #6329 (top_p bounds in runtime gateway) cover distinct sampling parameters. This PR focuses strictly on
presence_penaltyandfrequency_penaltywithinods/bin/pixel_provider/runtime_gateway.pywithout conflicting with adjacent checks.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6331 at 23a92c1 without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.