Skip to content

fix(pixel-gateway): reject non-integer and boolean seed in runtime gateway - #6331

Closed
vaibhavsrv wants to merge 1 commit into
Osmantic:public-betafrom
vaibhavsrv:fix/pixel-gateway-seed-integer-type
Closed

vaibhavsrv wants to merge 1 commit into
Osmantic:public-betafrom
vaibhavsrv:fix/pixel-gateway-seed-integer-type

Conversation

@vaibhavsrv

Copy link
Copy Markdown
Contributor

Why this matters

In ods/bin/pixel_provider/runtime_gateway.py, the validate_request routine admits the optional seed parameter without strict type validation. Because Python booleans are instances of int and unconstrained JSON inputs may supply floating-point or string representations, requests containing seed: True, seed: 1.0, or seed: "42" bypass validation, resulting in subtle RNG misconfiguration or downstream engine crashes.

This change surgically enforces type(payload['seed']) is int in validate_request, rejecting non-integer and boolean seeds with invalid-inference-request. Valid integer seeds across arbitrary signed 32/64-bit boundaries remain fully supported.

Validation

  • Baseline reproduction: Payloads specifying seed: True, seed: False, seed: 1.0, or seed: "42" were accepted by validate_request.
  • Post-fix behavior: Requests with boolean or non-integer seed types raise RuntimeErrorCode('invalid-inference-request'). Standard integer seeds pass cleanly.
  • Telemetry: Pixel gateway suites: 2 passed. New-test Ruff, ShellCheck, and diff checks pass; new regressions wired into Linux CI.

Overlap check

Recent PRs #6330 (temperature bounds in runtime gateway), #6329 (top_p bounds in runtime gateway), and #6328 (rollback snapshot permissions in ods-update.sh) touch independent parameters and subsystems. This PR focuses exclusively on the seed parameter type guard in ods/bin/pixel_provider/runtime_gateway.py without conflict.

Risk / AI disclosure

AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.

Follow-up integration evidence

Composed with #6330 at 0dde07e without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants