Repository navigation
fix(pixel-gateway): reject non-integer and boolean seed in runtime gateway - #6331
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admits the optionalseedparameter without strict type validation. Because Python booleans are instances ofintand unconstrained JSON inputs may supply floating-point or string representations, requests containingseed: True,seed: 1.0, orseed: "42"bypass validation, resulting in subtle RNG misconfiguration or downstream engine crashes.This change surgically enforces
type(payload['seed']) is intinvalidate_request, rejecting non-integer and boolean seeds withinvalid-inference-request. Valid integer seeds across arbitrary signed 32/64-bit boundaries remain fully supported.Validation
seed: True,seed: False,seed: 1.0, orseed: "42"were accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Standard integer seeds pass cleanly.Overlap check
Recent PRs #6330 (temperature bounds in runtime gateway), #6329 (top_p bounds in runtime gateway), and #6328 (rollback snapshot permissions in
ods-update.sh) touch independent parameters and subsystems. This PR focuses exclusively on theseedparameter type guard inods/bin/pixel_provider/runtime_gateway.pywithout conflict.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6330 at 0dde07e without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.