Repository navigation
fix(pixel-gateway): validate temperature bounds in runtime gateway - #6330
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine permits the optionaltemperaturesampling parameter without verifying bounds or type constraints. When clients send out-of-range values (such as negative numbers or values exceeding standard upper bound 2.0) or invalid types (booleans, strings, or nulls), the request bypasses admission validation and is forwarded to provider endpoints, leading to downstream runtime errors or corrupted sampling distributions.This change surgically adds bounds ($[0.0, 2.0]$ ) and numeric type checks ($[0.0, 2.0]$ remain supported.
type(payload['temperature']) in (int, float)) fortemperatureinvalidate_request, rejecting invalid configurations withinvalid-inference-request. Valid values across the full standard rangeValidation
temperature: -0.5,temperature: 3.0, ortemperature: Truewere accepted byvalidate_request.RuntimeErrorCode('invalid-inference-request'). Standard temperatures (e.g. 0.0, 0.7, 1.0, 2.0) validate cleanly.Overlap check
Recent PRs #6329 (top_p validation in runtime gateway), #6328 (rollback snapshot permissions in
ods-update.sh), and #6326 (multiple backup args inods-restore.sh) focus on distinct parameters or subsystems. This PR focuses strictly on thetemperatureparameter withinods/bin/pixel_provider/runtime_gateway.pywithout overlapping or altering existing sampling logic.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6329 at 02f5766 without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.