Repository navigation
fix(pixel-gateway): validate top_p probability bounds in runtime gateway - #6329
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In$[0.0, 1.0]$ (e.g., negative floats or values $> 1.0$ ), the request bypasses admission validation and triggers downstream model runner exceptions or unpredictable token nucleus sampling.
ods/bin/pixel_provider/runtime_gateway.py, thevalidate_requestroutine admits the optionaltop_pparameter without type or probability boundary enforcement. When external clients supply non-numeric values (such as strings or booleans) or numeric values outside the standard probability rangeThis change surgically adds bounds and type verification for$[0.0, 1.0]$ with
top_pinvalidate_request, rejecting invalid types and values outsideinvalid-inference-request. Valid probabilities, integers 0 and 1, and existing inference parameters remain unaffected.Validation
top_p: -0.5,top_p: 2.0, ortop_p: Truepassedvalidate_requestwithout error.RuntimeErrorCode('invalid-inference-request'), while valid floats between 0.0 and 1.0 are admitted.Overlap check
Recent PRs #6328 (snapshot permissions in
ods-update.sh), #6326 (argument count validation inods-restore.sh), and #5715 (top_p parameter validation inpixel-inference) operate on different modules. Specifically, #5715 scoped validation to the FastAPI inference worker, whereas this PR hardens the independent runtime provider gateway inods/bin/pixel_provider/runtime_gateway.pywithout overlap.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens an API validation check, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6328 at 17fe420 without conflicts. Production and test diffs passed together; gateway and runtime checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.