Repository navigation
fix(update): restrict permissions on rollback snapshot directory in ods-update.sh - #6328
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
During
snapshot_pre_updateandcmd_backupinods/ods-update.sh, rollback snapshot and backup directories are created viamkdir -pwithout explicitly restricting filesystem permissions. Because live.envand.env.*configuration files containing sensitive database passwords, external tokens, and credentials are copied into these directories, default umask settings (e.g.,0022) leave the target directory world-readable or group-readable, resulting in accidental credential exposure on shared or multi-tenant hosts.This change surgically adds
chmod 700immediately following directory creation in bothsnapshot_pre_updateandcmd_backup. The fix ensures private state and secrets remain restricted strictly to the executing user without altering backup filenames, copy semantics, or migration lifecycle logic.Validation
0755), allowing non-owner accounts read access to copied.envcredentials.snapshot_pre_updateandcmd_backupenforce0700(rwx------) permissions upon creation.Overlap check
Recent PRs #6326 (multiple backup arg validation in
ods-restore.sh), #6325 (option validation inods-backup.sh), and #6324 (atomic write in hermes) address argument parsing and context generation across separate utilities. None touch the pre-update snapshot directory creation inods-update.sh. This PR operates strictly withinods/ods-update.shand does not duplicate or conflict with their changes.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens filesystem permissions on backup directories, not runtime admission. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #6326 at af95a5f without conflicts. Production and test diffs passed together; backup and restore checks remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.